Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Zhao Zhili <quinkblack@foxmail.com>
To: Samuel Raposo Vieira Mira <samuel.mira@qt.io>,
	FFmpeg development discussions and patches
	<ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] avcodec/mediacodec: Add VP8 encoder
Date: Sun, 07 May 2023 16:26:08 +0800
Message-ID: <tencent_74574B9CF8E08E5AB835A5819C34093F9309@qq.com> (raw)
In-Reply-To: <DBAPR02MB61656446F17F24BF8BE056E2ED6B9@DBAPR02MB6165.eurprd02.prod.outlook.com>

On Fri, 2023-04-28 at 11:07 +0000, Samuel Raposo Vieira Mira wrote:
> Connected FFmpeg to Mediacodec VP8 encoder.
> Minor Version bump.
> ---
> configure                       |  1 +
> libavcodec/Makefile             |  1 +
> libavcodec/allcodecs.c          |  1 +
> libavcodec/mediacodec_wrapper.c |  4 ++++
> libavcodec/mediacodecenc.c      | 29 +++++++++++++++++++++++++++++
> libavcodec/version.h            |  2 +-
> 6 files changed, 37 insertions(+), 1 deletion(-)

The patch file format is broken (missing a space before unchanged lines).
Please send it via git send-email or add the patch as attachment.

> 
> @@ -387,6 +389,8 @@ int ff_AMediaCodecProfile_getProfileFromAVCodecContext(AVCodecContext *avctx)
>          case FF_PROFILE_HEVC_MAIN_10:
>              return HEVCProfileMain10;
>          }
> +    } else if (avctx->codec_id == AV_CODEC_ID_VP8) {
> +        return VP8ProfileMain;
>      } else if (avctx->codec_id == AV_CODEC_ID_VP9) {
>          switch (avctx->profile) {
>          case FF_PROFILE_VP9_0:

The function is a map from avctx->profile to MediaCodec profile.
It's not supposed to select a default profile.

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  parent reply	other threads:[~2023-05-07  8:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-28 11:07 Samuel Raposo Vieira Mira
2023-05-02 11:39 ` Tomas Härdin
2023-05-07  8:26 ` Zhao Zhili [this message]
2023-05-16 16:16   ` Samuel Raposo Vieira Mira
2023-05-16 17:02     ` Zhao Zhili
  -- strict thread matches above, loose matches on Subject: below --
2023-04-26 14:00 Samuel Raposo Vieira Mira
2023-04-27 12:36 ` Tomas Härdin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tencent_74574B9CF8E08E5AB835A5819C34093F9309@qq.com \
    --to=quinkblack@foxmail.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    --cc=samuel.mira@qt.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git