[FFmpeg-devel] Bump major version of swresample

[FFmpeg-devel] Bump major version of swresample

[Wang Bin]

[-- Attachment #1: Type: text/plain, Size: 1 bytes --]



[-- Attachment #2: 0001-Bump-major-version-of-swresample.patch --]
[-- Type: application/octet-stream, Size: 681 bytes --]

[-- Attachment #3: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] Bump major version of swresample

[Michael Niedermayer]

[-- Attachment #1.1: Type: text/plain, Size: 1660 bytes --]

essOn Sat, Feb 25, 2023 at 12:03:02AM +0800, Wang Bin wrote:
> 

>  version_major.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> a87056c2fe65d68b2cf5d1de06be28ea40c69b73  0001-Bump-major-version-of-swresample.patch
> From e3e6a3833f2fba743ee9c05962e804e9e570dd75 Mon Sep 17 00:00:00 2001
> From: wang-bin <wbsecg1@gmail.com>
> Date: Fri, 24 Feb 2023 23:54:51 +0800
> Subject: [PATCH] Bump major version of swresample
> 
> ---
>  libswresample/version_major.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libswresample/version_major.h b/libswresample/version_major.h
> index 7f265c2073..dd13f2bbe3 100644
> --- a/libswresample/version_major.h
> +++ b/libswresample/version_major.h
> @@ -26,6 +26,6 @@
>   * Libswresample version macros
>   */
>  
> -#define LIBSWRESAMPLE_VERSION_MAJOR   4
> +#define LIBSWRESAMPLE_VERSION_MAJOR   5

No oppinion if this should be changed now before 6.0 or not
but if its done it should be done on master and release/6.0 at the same time
and LIBSWRESAMPLE_VERSION_MINOR needs to be reset too while
LIBSWRESAMPLE_VERSION_MINOR needs to be +1 on master compared to release/6.0

oppinon from others is welcome here. Iam not a user of the releases so its
hard for me to really guess which way is better. Its a little messy to
change now

thx

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Rewriting code that is poorly written but fully understood is good.
Rewriting code that one doesnt understand is a sign that one is less smart
than the original author, trying to rewrite it will not make it better.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] Bump major version of swresample

["zhilizhao(赵志立)"]

> On Feb 27, 2023, at 18:03, Michael Niedermayer <michael@niedermayer.cc> wrote:
> 
> essOn Sat, Feb 25, 2023 at 12:03:02AM +0800, Wang Bin wrote:
>> 
> 
>> version_major.h |    2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> a87056c2fe65d68b2cf5d1de06be28ea40c69b73  0001-Bump-major-version-of-swresample.patch
>> From e3e6a3833f2fba743ee9c05962e804e9e570dd75 Mon Sep 17 00:00:00 2001
>> From: wang-bin <wbsecg1@gmail.com>
>> Date: Fri, 24 Feb 2023 23:54:51 +0800
>> Subject: [PATCH] Bump major version of swresample
>> 
>> ---
>> libswresample/version_major.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/libswresample/version_major.h b/libswresample/version_major.h
>> index 7f265c2073..dd13f2bbe3 100644
>> --- a/libswresample/version_major.h
>> +++ b/libswresample/version_major.h
>> @@ -26,6 +26,6 @@
>>  * Libswresample version macros
>>  */
>> 
>> -#define LIBSWRESAMPLE_VERSION_MAJOR   4
>> +#define LIBSWRESAMPLE_VERSION_MAJOR   5
> 
> No oppinion if this should be changed now before 6.0 or not
> but if its done it should be done on master and release/6.0 at the same time
> and LIBSWRESAMPLE_VERSION_MINOR needs to be reset too while
> LIBSWRESAMPLE_VERSION_MINOR needs to be +1 on master compared to release/6.0
> 
> oppinon from others is welcome here. Iam not a user of the releases so its
> hard for me to really guess which way is better. Its a little messy to
> change now

There is no major changes since last bump. Is it an option to keep current
major version?

> 
> thx
> 
> [...]
> 
> -- 
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
> 
> Rewriting code that is poorly written but fully understood is good.
> Rewriting code that one doesnt understand is a sign that one is less smart
> than the original author, trying to rewrite it will not make it better.
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
> 

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] Bump major version of swresample

[Wang Bin]

>
>
> There is no major changes since last bump. Is it an option to keep current
> major version?
>
>
libpostproc changes less
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] Bump major version of swresample

[James Almer]

On 2/27/2023 7:03 AM, Michael Niedermayer wrote:
> essOn Sat, Feb 25, 2023 at 12:03:02AM +0800, Wang Bin wrote:
>>
> 
>>   version_major.h |    2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>> a87056c2fe65d68b2cf5d1de06be28ea40c69b73  0001-Bump-major-version-of-swresample.patch
>>  From e3e6a3833f2fba743ee9c05962e804e9e570dd75 Mon Sep 17 00:00:00 2001
>> From: wang-bin <wbsecg1@gmail.com>
>> Date: Fri, 24 Feb 2023 23:54:51 +0800
>> Subject: [PATCH] Bump major version of swresample
>>
>> ---
>>   libswresample/version_major.h | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/libswresample/version_major.h b/libswresample/version_major.h
>> index 7f265c2073..dd13f2bbe3 100644
>> --- a/libswresample/version_major.h
>> +++ b/libswresample/version_major.h
>> @@ -26,6 +26,6 @@
>>    * Libswresample version macros
>>    */
>>   
>> -#define LIBSWRESAMPLE_VERSION_MAJOR   4
>> +#define LIBSWRESAMPLE_VERSION_MAJOR   5
> 
> No oppinion if this should be changed now before 6.0 or not
> but if its done it should be done on master and release/6.0 at the same time
> and LIBSWRESAMPLE_VERSION_MINOR needs to be reset too while
> LIBSWRESAMPLE_VERSION_MINOR needs to be +1 on master compared to release/6.0
> 
> oppinon from others is welcome here. Iam not a user of the releases so its
> hard for me to really guess which way is better. Its a little messy to
> change now
> 
> thx

I don't think it's a good idea to do it now. No API was removed from it 
so leaving the major as is should be fine.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] Bump major version of swresample

[Wang Bin]

James Almer <jamrial@gmail.com> 于2023年2月27日周一 20:00写道：

> On 2/27/2023 7:03 AM, Michael Niedermayer wrote:
> > essOn Sat, Feb 25, 2023 at 12:03:02AM +0800, Wang Bin wrote:
> >>
> >
> >>   version_major.h |    2 +-
> >>   1 file changed, 1 insertion(+), 1 deletion(-)
> >> a87056c2fe65d68b2cf5d1de06be28ea40c69b73
> 0001-Bump-major-version-of-swresample.patch
> >>  From e3e6a3833f2fba743ee9c05962e804e9e570dd75 Mon Sep 17 00:00:00 2001
> >> From: wang-bin <wbsecg1@gmail.com>
> >> Date: Fri, 24 Feb 2023 23:54:51 +0800
> >> Subject: [PATCH] Bump major version of swresample
> >>
> >> ---
> >>   libswresample/version_major.h | 2 +-
> >>   1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/libswresample/version_major.h
> b/libswresample/version_major.h
> >> index 7f265c2073..dd13f2bbe3 100644
> >> --- a/libswresample/version_major.h
> >> +++ b/libswresample/version_major.h
> >> @@ -26,6 +26,6 @@
> >>    * Libswresample version macros
> >>    */
> >>
> >> -#define LIBSWRESAMPLE_VERSION_MAJOR   4
> >> +#define LIBSWRESAMPLE_VERSION_MAJOR   5
> >
> > No oppinion if this should be changed now before 6.0 or not
> > but if its done it should be done on master and release/6.0 at the same
> time
> > and LIBSWRESAMPLE_VERSION_MINOR needs to be reset too while
> > LIBSWRESAMPLE_VERSION_MINOR needs to be +1 on master compared to
> release/6.0
> >
> > oppinon from others is welcome here. Iam not a user of the releases so
> its
> > hard for me to really guess which way is better. Its a little messy to
> > change now
> >
> > thx
>
> I don't think it's a good idea to do it now. No API was removed from it
> so leaving the major as is should be fine.
>

Currently no api change and even no abi change. But AVFrame is used in the
public api swr_convert_frame, AVFrame abi changes may break swresample
binary compatibility without swresample code change. All other modules
except postproc and avutil public apis also depend on structs from another
module. So it's better to bump major version of all modules.

Regards
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] Bump major version of swresample

[Zhao Zhili]

> 在 2023年2月28日，09:43，Wang Bin <wbsecg1@gmail.com> 写道：
> 
> James Almer <jamrial@gmail.com> 于2023年2月27日周一 20:00写道：
> 
>>> On 2/27/2023 7:03 AM, Michael Niedermayer wrote:
>>> essOn Sat, Feb 25, 2023 at 12:03:02AM +0800, Wang Bin wrote:
>>>> 
>>> 
>>>>  version_major.h |    2 +-
>>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>> a87056c2fe65d68b2cf5d1de06be28ea40c69b73
>> 0001-Bump-major-version-of-swresample.patch
>>>> From e3e6a3833f2fba743ee9c05962e804e9e570dd75 Mon Sep 17 00:00:00 2001
>>>> From: wang-bin <wbsecg1@gmail.com>
>>>> Date: Fri, 24 Feb 2023 23:54:51 +0800
>>>> Subject: [PATCH] Bump major version of swresample
>>>> 
>>>> ---
>>>>  libswresample/version_major.h | 2 +-
>>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>> 
>>>> diff --git a/libswresample/version_major.h
>> b/libswresample/version_major.h
>>>> index 7f265c2073..dd13f2bbe3 100644
>>>> --- a/libswresample/version_major.h
>>>> +++ b/libswresample/version_major.h
>>>> @@ -26,6 +26,6 @@
>>>>   * Libswresample version macros
>>>>   */
>>>> 
>>>> -#define LIBSWRESAMPLE_VERSION_MAJOR   4
>>>> +#define LIBSWRESAMPLE_VERSION_MAJOR   5
>>> 
>>> No oppinion if this should be changed now before 6.0 or not
>>> but if its done it should be done on master and release/6.0 at the same
>> time
>>> and LIBSWRESAMPLE_VERSION_MINOR needs to be reset too while
>>> LIBSWRESAMPLE_VERSION_MINOR needs to be +1 on master compared to
>> release/6.0
>>> 
>>> oppinon from others is welcome here. Iam not a user of the releases so
>> its
>>> hard for me to really guess which way is better. Its a little messy to
>>> change now
>>> 
>>> thx
>> 
>> I don't think it's a good idea to do it now. No API was removed from it
>> so leaving the major as is should be fine.
>> 
> 
> Currently no api change and even no abi change. But AVFrame is used in the
> public api swr_convert_frame, AVFrame abi changes may break swresample
> binary compatibility without swresample code change.

I don’t think that’s how ABI and so version works.

> All other modules
> except postproc and avutil public apis also depend on structs from another
> module. So it's better to bump major version of all modules.
> 
> Regards
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org wit

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".