From: "\"zhilizhao(赵志立)\"" <quinkblack@foxmail.com> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Subject: Re: [FFmpeg-devel] Bump major version of swresample Date: Mon, 27 Feb 2023 20:00:05 +0800 Message-ID: <tencent_7378F5C46900EEBEA555531D884673E2B305@qq.com> (raw) In-Reply-To: <20230227100318.GF1949656@pb2> > On Feb 27, 2023, at 18:03, Michael Niedermayer <michael@niedermayer.cc> wrote: > > essOn Sat, Feb 25, 2023 at 12:03:02AM +0800, Wang Bin wrote: >> > >> version_major.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> a87056c2fe65d68b2cf5d1de06be28ea40c69b73 0001-Bump-major-version-of-swresample.patch >> From e3e6a3833f2fba743ee9c05962e804e9e570dd75 Mon Sep 17 00:00:00 2001 >> From: wang-bin <wbsecg1@gmail.com> >> Date: Fri, 24 Feb 2023 23:54:51 +0800 >> Subject: [PATCH] Bump major version of swresample >> >> --- >> libswresample/version_major.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/libswresample/version_major.h b/libswresample/version_major.h >> index 7f265c2073..dd13f2bbe3 100644 >> --- a/libswresample/version_major.h >> +++ b/libswresample/version_major.h >> @@ -26,6 +26,6 @@ >> * Libswresample version macros >> */ >> >> -#define LIBSWRESAMPLE_VERSION_MAJOR 4 >> +#define LIBSWRESAMPLE_VERSION_MAJOR 5 > > No oppinion if this should be changed now before 6.0 or not > but if its done it should be done on master and release/6.0 at the same time > and LIBSWRESAMPLE_VERSION_MINOR needs to be reset too while > LIBSWRESAMPLE_VERSION_MINOR needs to be +1 on master compared to release/6.0 > > oppinon from others is welcome here. Iam not a user of the releases so its > hard for me to really guess which way is better. Its a little messy to > change now There is no major changes since last bump. Is it an option to keep current major version? > > thx > > [...] > > -- > Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB > > Rewriting code that is poorly written but fully understood is good. > Rewriting code that one doesnt understand is a sign that one is less smart > than the original author, trying to rewrite it will not make it better. > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-02-27 12:00 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-02-24 16:03 Wang Bin 2023-02-27 10:03 ` Michael Niedermayer 2023-02-27 12:00 ` "zhilizhao(赵志立)" [this message] 2023-02-27 16:01 ` Wang Bin 2023-02-27 12:00 ` James Almer 2023-02-28 1:43 ` Wang Bin 2023-02-28 2:34 ` Zhao Zhili
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=tencent_7378F5C46900EEBEA555531D884673E2B305@qq.com \ --to=quinkblack@foxmail.com \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git