From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 6E41444B0C for ; Wed, 23 Jul 2025 08:31:32 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 93E6168D475; Wed, 23 Jul 2025 11:31:27 +0300 (EEST) Received: from out203-205-221-240.mail.qq.com (out203-205-221-240.mail.qq.com [203.205.221.240]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 7675368D173 for ; Wed, 23 Jul 2025 11:31:19 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1753259476; bh=geneRCiyb/EHKarVzyCqVgC/1DXDv/S9ANiPfJopEoU=; h=Subject:From:In-Reply-To:Date:Cc:References:To; b=d4mPi8SSHAF5kWbv4KGmRPt6F7WUEKdYBXPunSwlDD/xZpSjPtaTGAxU8BQATnWX2 BEntcZirerQSDfN8SwQ44+sRX1QuN52ovCqbm3x4h3npQzYxvi69KGj9183lK6l8Bb 4kvccg00kgK3NSpuZbt920If3Jxm7DFLZTcqF4to= Received: from smtpclient.apple ([119.147.10.242]) by newxmesmtplogicsvrszb21-0.qq.com (NewEsmtp) with SMTP id 64B8EAD6; Wed, 23 Jul 2025 16:25:11 +0800 X-QQ-mid: xmsmtpt1753259111trkafzm43 Message-ID: X-QQ-XMAILINFO: MmPNY57tR1XnOIYqnF8jOm+JD2k90NeDgSPSkTKiasSPfQYe4vX8/N1/yLXbYg aL5QxpWi+K8xbmLK9CbFc10Oe5UNUKCEMXvjt4BLqx2s8s9SovY9n0ogRxkJqHangWLsPT0J4diC iDinCtbSazTIv9LhpAYK8mjLAh/4/y2SKozKPlwgDTCox5Hv0DM9qIB/ZY6gmZEuGrhlK8F/Pqj+ IIxvoTBfubM02yDFFync55cYZKQ15LmsZAd9sGWfRH7gGFR2wbcy52lIy8Lih9vTyovXJhbMmvPW KdqrI/G1WDShHvs+0QYnWFWhrCLMCch0LhPTX58k5XzH+osK5nNeoc081DQWsCibmrv0T57ZNWU5 WQSOPDH982cbzGQwG0hugs9f/Jvv9zOj1PD87kULEI6dpVYaqt1m8zupvNwih+Swfw+baOWTqdmM 6qvB/nSkwVTEoNDOCcU8SnHBXa3R8DJteCoHKPe4863jnYYqr/NTYtFLQm0QH+jyv23W8xN5fF83 YdiaPSddf72vw0b9iQOir8tHhcUA4Sc8x5IisrFwvxAwUDRCB/d9NTqL2H8XrxAO4G+dzaCL2Mq1 yHrbNWmDSkD6Wg18aHv+Y7q2P8yzTCfDTFMj5N6WoY1RWckB3XuyvS6Ac3zVIYjUykMRCctRigD3 ODZpvoQgdS5iW5m8rd0o4lVTP2G5tp3sYswfxXVXnycfzMr+GGZ9k7zMu9oFCQBSBYUYjMLW/qSc HZyuGVJj0ynGVgZWLq+f2/RKS5cwMZtLeq2xwXbKvkHnUI6y3iiYrnJxF5zvfSN+eRvimYOiv2j8 2ytTQfHnen2B3trhSAaMnG23xEtCqkRJ0neArn30TtHwNLYbMx18sj2Fobn3uMelrSHnprRcVvcD OXUmPrrRBo8lph24sAgrBDrncKbnfekIPD7uvuyra0GmEHLwnI6Qb3PW/DYV1o8WJS4C37MVlMcx 9g2wkOTUfB4o9jHAhA4DrHPLBBXt114au54xj7n2PpINbOuAXQiVdTfDFp6TgLyzCdIv3PUd10NP 3JsxL2zeAR13n9FnaurRH6vv81Pid3ODw1YdAp+v5RY3DANyOQSg8JiU1JXSm4Ct7MRBxKvBzj63 iIfhhuTiXWeolsr5Fssr1FMwCZ+A== X-QQ-XMRINFO: NS+P29fieYNw95Bth2bWPxk= Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.500.181.1.5\)) From: Zhao Zhili In-Reply-To: <20250723025137.214-1-15083277223@163.com> Date: Wed, 23 Jul 2025 16:25:01 +0800 X-OQ-MSGID: <2A63D1B5-24A9-47DB-93FF-324D692FE283@foxmail.com> References: <20250723025137.214-1-15083277223@163.com> To: FFmpeg development discussions and patches X-Mailer: Apple Mail (2.3826.500.181.1.5) Subject: Re: [FFmpeg-devel] [PATCH v2] libavformat/mov.c : rm 'statement will never be executed' warning X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: zhaozhenghang <15083277223@163.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Please reword the commit subject description. > On Jul 23, 2025, at 10:51, zhaozhenghang <15083277223@163.com> wrote: > > remove the conditional compilation inside the switch to avoid warnings. > > Signed-off-by: zhaozhenghang <15083277223@163.com> > --- > libavformat/mov.c | 10 ++-------- > 1 file changed, 2 insertions(+), 8 deletions(-) > > diff --git a/libavformat/mov.c b/libavformat/mov.c > index 4a4641d51b..5307e9d6a5 100644 > --- a/libavformat/mov.c > +++ b/libavformat/mov.c > @@ -5222,22 +5222,16 @@ static int mov_read_trak(MOVContext *c, AVIOContext *pb, MOVAtom atom) > return ret; > } > > -#if CONFIG_H261_DECODER || CONFIG_H263_DECODER || CONFIG_MPEG4_DECODER The patch should be based on git master branch, not based on patch v1, which has been dropped. > switch (st->codecpar->codec_id) { > -#if CONFIG_H261_DECODER > case AV_CODEC_ID_H261: > -#endif > -#if CONFIG_H263_DECODER > case AV_CODEC_ID_H263: > -#endif > -#if CONFIG_MPEG4_DECODER > case AV_CODEC_ID_MPEG4: > -#endif > st->codecpar->width = 0; /* let decoder init width/height */ > st->codecpar->height= 0; > break; > + default: > + break; > } > -#endif > // If the duration of the mp3 packets is not constant, then they could need a parser > if (st->codecpar->codec_id == AV_CODEC_ID_MP3 > && sc->time_scale == st->codecpar->sample_rate) { > -- > 2.50.1.windows.1 > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".