[FFmpeg-devel] [PATCH v2] libavformat/mov.c : rm 'statement will never be executed' warning

[FFmpeg-devel] [PATCH v2] libavformat/mov.c : rm 'statement will never be executed' warning

[zhaozhenghang]

remove the conditional compilation inside the switch to avoid warnings.

Signed-off-by: zhaozhenghang <15083277223@163.com>
---
 libavformat/mov.c | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/libavformat/mov.c b/libavformat/mov.c
index 4a4641d51b..5307e9d6a5 100644
--- a/libavformat/mov.c
+++ b/libavformat/mov.c
@@ -5222,22 +5222,16 @@ static int mov_read_trak(MOVContext *c, AVIOContext *pb, MOVAtom atom)
             return ret;
     }
 
-#if CONFIG_H261_DECODER || CONFIG_H263_DECODER || CONFIG_MPEG4_DECODER
     switch (st->codecpar->codec_id) {
-#if CONFIG_H261_DECODER
     case AV_CODEC_ID_H261:
-#endif
-#if CONFIG_H263_DECODER
     case AV_CODEC_ID_H263:
-#endif
-#if CONFIG_MPEG4_DECODER
     case AV_CODEC_ID_MPEG4:
-#endif
         st->codecpar->width = 0; /* let decoder init width/height */
         st->codecpar->height= 0;
         break;
+    default:
+        break;
     }
-#endif
     // If the duration of the mp3 packets is not constant, then they could need a parser
     if (st->codecpar->codec_id == AV_CODEC_ID_MP3
         && sc->time_scale == st->codecpar->sample_rate) {
-- 
2.50.1.windows.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v2] libavformat/mov.c : rm 'statement will never be executed' warning

[Zhao Zhili]

Please reword the commit subject description.

> On Jul 23, 2025, at 10:51, zhaozhenghang <15083277223@163.com> wrote:
> 
> remove the conditional compilation inside the switch to avoid warnings.
> 
> Signed-off-by: zhaozhenghang <15083277223@163.com>
> ---
> libavformat/mov.c | 10 ++--------
> 1 file changed, 2 insertions(+), 8 deletions(-)
> 
> diff --git a/libavformat/mov.c b/libavformat/mov.c
> index 4a4641d51b..5307e9d6a5 100644
> --- a/libavformat/mov.c
> +++ b/libavformat/mov.c
> @@ -5222,22 +5222,16 @@ static int mov_read_trak(MOVContext *c, AVIOContext *pb, MOVAtom atom)
>             return ret;
>     }
> 
> -#if CONFIG_H261_DECODER || CONFIG_H263_DECODER || CONFIG_MPEG4_DECODER

The patch should be based on git master branch, not based on patch v1, which has been dropped.

>     switch (st->codecpar->codec_id) {
> -#if CONFIG_H261_DECODER
>     case AV_CODEC_ID_H261:
> -#endif
> -#if CONFIG_H263_DECODER
>     case AV_CODEC_ID_H263:
> -#endif
> -#if CONFIG_MPEG4_DECODER
>     case AV_CODEC_ID_MPEG4:
> -#endif
>         st->codecpar->width = 0; /* let decoder init width/height */
>         st->codecpar->height= 0;
>         break;
> +    default:
> +        break;
>     }
> -#endif
>     // If the duration of the mp3 packets is not constant, then they could need a parser
>     if (st->codecpar->codec_id == AV_CODEC_ID_MP3
>         && sc->time_scale == st->codecpar->sample_rate) {
> -- 
> 2.50.1.windows.1
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".