Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Zhao Zhili <quinkblack@foxmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: zhaozhenghang <15083277223@163.com>
Subject: Re: [FFmpeg-devel] [PATCH 1/1] libavformat/mov.c: Fix "statement will never be executed" warning
Date: Thu, 31 Jul 2025 11:39:58 +0800
Message-ID: <tencent_6FD0B7E6E7E7E0EA8C9331DC590BAA660406@qq.com> (raw)
In-Reply-To: <20250731012707.1594-1-15083277223@163.com>



> On Jul 31, 2025, at 09:27, zhaozhenghang <15083277223@163.com> wrote:
> 
> Fix "statement will never be executed" warning that occurs when
> CONFIG_H261_DECODER, CONFIG_H263_DECODER, and CONFIG_MPEG4_DECODER
> are set to 0 by default.

Pushed after rewords on the commit message, thanks.

> 
> Signed-off-by: zhaozhenghang <15083277223@163.com>
> ---
> libavformat/mov.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/libavformat/mov.c b/libavformat/mov.c
> index 55b0950b5e..5ff9b5ba1b 100644
> --- a/libavformat/mov.c
> +++ b/libavformat/mov.c
> @@ -5225,18 +5225,14 @@ static int mov_read_trak(MOVContext *c, AVIOContext *pb, MOVAtom atom)
>     }
> 
>     switch (st->codecpar->codec_id) {
> -#if CONFIG_H261_DECODER
>     case AV_CODEC_ID_H261:
> -#endif
> -#if CONFIG_H263_DECODER
>     case AV_CODEC_ID_H263:
> -#endif
> -#if CONFIG_MPEG4_DECODER
>     case AV_CODEC_ID_MPEG4:
> -#endif
>         st->codecpar->width = 0; /* let decoder init width/height */
>         st->codecpar->height= 0;
>         break;
> +    default:
> +        break;
>     }
> 
>     // If the duration of the mp3 packets is not constant, then they could need a parser
> -- 
> 2.50.1.windows.1
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

      reply	other threads:[~2025-07-31  3:46 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-31  1:27 zhaozhenghang
2025-07-31  3:39 ` Zhao Zhili [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tencent_6FD0B7E6E7E7E0EA8C9331DC590BAA660406@qq.com \
    --to=quinkblack@foxmail.com \
    --cc=15083277223@163.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git