Re: [FFmpeg-devel] [PATCH 2/2] lavf/movenc: sort options by name

[Zhao Zhili <quinkblack@foxmail.com>]

> On Jan 7, 2024, at 20:05, Stefano Sabatini <stefasab@gmail.com> wrote:
> 
> On date Sunday 2024-01-07 13:10:44 +0800, Zhao Zhili wrote:
> [...]
>> I'm not blocking the patch, however, I'm not sure whether the gain
>> outweighs the effort for such large code changes.  It's very
>> unlikely to introduce new issues, but possible (e.g., typo while do
>> copy paste), and it's hard to check while review.
> 
> It's true that it's hard to review, but in case of typos we should
> notice almost immediately (e.g. because compilation fails).

Typo doesn’t always lead to compilation fail, especially in AVOption
tables.

> 
> And the readability boost it gives (sorted options means you don't
> need to read through all the options to find a given one) is well
> worth it.

For user oriented documentation, sure. For AVOption tables, I use
keyword search most of times.

It’s kind of like formatting source code with clang-format. It do improve
readability, but there are various reasons not to apply clang-format
on whole file or whole project.

> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".