From: Zhao Zhili <quinkblack-at-foxmail.com@ffmpeg.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v3 2/3] avcodec/hevc/ps: Add basic HEVC_SCALABILITY_AUXILIARY support
Date: Thu, 6 Feb 2025 12:00:42 +0800
Message-ID: <tencent_6E1390B766DC27E5AA869315DC5C0BA9A606@qq.com> (raw)
In-Reply-To: <dad26af2-b274-4125-acc5-3227ac4a997f@gmail.com>
> On Feb 6, 2025, at 05:20, James Almer <jamrial@gmail.com> wrote:
>
> On 2/5/2025 12:10 PM, Zhao Zhili wrote:
>> - skip_bits1(gb); /* direct_depenency_all_layers_flag */
>> - direct_dep_type = get_bits_long(gb, direct_dep_type_len);
>> - if (direct_dep_type > HEVC_DEP_TYPE_BOTH) {
>> - av_log(avctx, AV_LOG_WARNING, "Unsupported direct_dep_type: %d\n",
>> - direct_dep_type);
>> - return AVERROR_PATCHWELCOME;
>> + /* direct_depenency_all_layers_flag */
>> + if (get_bits1(gb)) {
>> + direct_dep_type = get_bits_long(gb, direct_dep_type_len);
>> + if (direct_dep_type > HEVC_DEP_TYPE_BOTH) {
>> + av_log(avctx, AV_LOG_WARNING, "Unsupported direct_dep_type: %d\n",
>> + direct_dep_type);
>> + return AVERROR_PATCHWELCOME;
>> + }
>> }
>
> direct_dep_type is also coded if direct_depenency_all_layers_flag is false when (if I'm reading the spec right) vps->num_direct_ref_layers[1] is not 0.
Fixed in v4.
https://ffmpeg.org/pipermail/ffmpeg-devel/2025-February/339364.html
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2025-02-06 4:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-05 15:10 Zhao Zhili
2025-02-05 21:20 ` James Almer
2025-02-06 4:00 ` Zhao Zhili [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_6E1390B766DC27E5AA869315DC5C0BA9A606@qq.com \
--to=quinkblack-at-foxmail.com@ffmpeg.org \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git