From: "\"zhilizhao(赵志立)\"" <quinkblack@foxmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] avcodec/libuavs3d: fix access uninitialized variable when draining
Date: Mon, 23 May 2022 11:24:50 +0800
Message-ID: <tencent_6A6A2DE39A13405A9A309F7AAB374EF67008@qq.com> (raw)
In-Reply-To: <CACYjbn3BkNFoKbvKCfNvELeR622+mRMUaHdKzCzeHK88e5kY1Q@mail.gmail.com>
> On May 13, 2022, at 8:59 AM, mypopy@gmail.com wrote:
>
> On Thu, May 12, 2022 at 5:55 PM Zhao Zhili <quinkblack@foxmail.com> wrote:
>>
>> buf_ptr is uninitialized and accessed when function return.
>> ---
>> libavcodec/libuavs3d.c | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/libavcodec/libuavs3d.c b/libavcodec/libuavs3d.c
>> index 6966e00b62..23de4c8cd5 100644
>> --- a/libavcodec/libuavs3d.c
>> +++ b/libavcodec/libuavs3d.c
>> @@ -149,7 +149,7 @@ static int libuavs3d_decode_frame(AVCodecContext *avctx, AVFrame *frm,
>> const uint8_t *buf = avpkt->data;
>> int buf_size = avpkt->size;
>> const uint8_t *buf_end;
>> - const uint8_t *buf_ptr;
>> + const uint8_t *buf_ptr = buf;
>> int left_bytes;
>> int ret, finish = 0;
>>
>> @@ -170,7 +170,6 @@ static int libuavs3d_decode_frame(AVCodecContext *avctx, AVFrame *frm,
>> } else {
>> uavs3d_io_frm_t *frm_dec = &h->dec_frame;
>>
>> - buf_ptr = buf;
>> buf_end = buf + buf_size;
>> frm_dec->pkt_pos = avpkt->pos;
>> frm_dec->pkt_size = avpkt->size;
>> --
>> 2.35.3
> Sounds Good To Me
Applied, thanks!
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2022-05-23 3:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-12 9:55 Zhao Zhili
2022-05-13 0:59 ` mypopy
2022-05-23 3:24 ` "zhilizhao(赵志立)" [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_6A6A2DE39A13405A9A309F7AAB374EF67008@qq.com \
--to=quinkblack@foxmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git