From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 84BD342F1A for ; Fri, 13 May 2022 10:16:09 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3DB9C68B3C5; Fri, 13 May 2022 13:16:07 +0300 (EEST) Received: from out203-205-251-59.mail.qq.com (out203-205-251-59.mail.qq.com [203.205.251.59]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 10B5668B36E for ; Fri, 13 May 2022 13:15:59 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1652436956; bh=YCLlmurNSBUpErMaghrTlKWYB8HE5ibbWWkgj8sNuhI=; h=From:Subject:Date:References:To:In-Reply-To; b=RPMwuqoNJA40j7Z4WywirNtpm9QgYpgvUKt6Hh2qbYgy/aU/YsUx+Sjb3zEq4IdIm 132L9I/S/Qvh4XPNBXnEN4zp9/YcGCJVlO6MhRV23N9ced2JYS8qyj4DJVZJtLWa7c 3mSBhkw6fY0mTFyQtihM69FMwHRT8Sa1dzVrAOlw= Received: from [192.168.255.10] ([113.118.107.45]) by newxmesmtplogicsvrszc8.qq.com (NewEsmtp) with SMTP id 3F70E2CA; Fri, 13 May 2022 18:15:55 +0800 X-QQ-mid: xmsmtpt1652436955t34ecuxxb Message-ID: X-QQ-XMAILINFO: NYgiIjzyB8WBE7O6IrsHO5qAXoijdn9xckzLEwk+aWafEqcP0X/jrDS6QJRnea nsjxRUW4rScrcQ49vEFXWXZGqAwu3xjXeNFW2N0YAKCblyQx9J1QoYcMZyJegZdmMDhNygBfHoPD szL+m4jjkirMDZKKETLoiViK6ph+f68XQL+pxXFviCvghV+1U370uXSoSgGL0tV/1RfqjTh9IlMF B8zjIaPFuAYDCtAdeES+EusSarRYC7NqWfms1brgJ8QijBT/5pk7QDLOQHVgzhSjTGTWi7NwnqiW CUKo9Hm0tL7dDIW3M3yQJepm38PQIpVUVWGcr5Ji1Sd5S53Km6pom00WAhQin7+uhRw2RHM7PA4z nrbOpvpA1qzKRBnFw02p2C+onOrxxg4qe8GUNbRuINAEhPYvM5sre6VXBnJVBsvvJUiqcrgEpSPC Ve3y9mGCcQflBXQecpR/S/cmehrYCoFn9VjQZWPOGiSvX2JlntT4fwVX7cSNAtWkZMBM6FouIwiJ ikEDc5f+wGWhgMLN7uEMKwGofh3jyG4iiu/riT3KniGNV/cyS1GBqiUDGc96lMDdB/mR0r57YF6C OF9+AsDffcM4YCQR7da16xhscpkKdrL4aW9cvA9uQ2A8RWpZffbNrfiNKTBWvQYeFGerr4hG1MNw CGdA0WPcETs7poXJj2dAYchSkJUC26U14qJGtEJtqzGOEVrMTAIST7KkVGTtYAIWTGjgpMcQd7EZ CeSlHL8Da60X2LFUXlQmE/IG1jUPoTHAXa44pJ0iIKNjWcF4p+/n01oMOnOrJnZaY1S5FtZ0ywOf +fStEwX6TeLzGO8ylBfdVTTPrE8fkWruStZyzRt8JwFqkP94buACZG7u1P9IQ007yzqCVSCHc5Bn 0ERB7bbvLt+hm0KNIuFguFbzZjucgyvn9BpW3kN05GC5EI6b+YfS63QCOA0TIy/Q== From: =?utf-8?B?InpoaWxpemhhbyjotbXlv5fnq4spIg==?= Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\)) Date: Fri, 13 May 2022 18:15:55 +0800 References: To: FFmpeg development discussions and patches In-Reply-To: X-OQ-MSGID: X-Mailer: Apple Mail (2.3654.60.0.2.21) Subject: Re: [FFmpeg-devel] [PATCH 1/3] avcodec/avs3_parser: set has_b_frames properly X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > On May 13, 2022, at 5:43 PM, Andreas Rheinhardt wrote: > > Zhao Zhili: >> has_b_frames should be output_reorder_delay field in AVS3 sequence >> header and larger than 1. The parser implementation doesn't parse >> that field. Decoder can set has_b_frames properly, so use FFMAX >> here to avoid resetting has_b_frames from output_reorder_delay to 1. >> --- >> libavcodec/avs3_parser.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/libavcodec/avs3_parser.c b/libavcodec/avs3_parser.c >> index d04d96a03a..0d2e940d1e 100644 >> --- a/libavcodec/avs3_parser.c >> +++ b/libavcodec/avs3_parser.c >> @@ -114,7 +114,7 @@ static void parse_avs3_nal_units(AVCodecParserContext *s, const uint8_t *buf, >> // bitrate_high(12) >> skip_bits(&gb, 32); >> >> - avctx->has_b_frames = !get_bits(&gb, 1); >> + avctx->has_b_frames = FFMAX(avctx->has_b_frames, !get_bits(&gb, 1)); >> >> avctx->framerate.num = avctx->time_base.den = ff_avs3_frame_rate_tab[ratecode].num; >> avctx->framerate.den = avctx->time_base.num = ff_avs3_frame_rate_tab[ratecode].den; > > FFMAX can evaluate its arguments more than once which is not intended here. Good catch, thanks! Here is v2: http://ffmpeg.org/pipermail/ffmpeg-devel/2022-May/296396.html Use a variable low_delay to fix the FFMAX issue and serve as document. > > - Andreas > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".