Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
* [FFmpeg-devel] [PATCH 2/2] avcodec/jni: make global variables static
       [not found] <20230917033734.13342-1-quinkblack@foxmail.com>
@ 2023-09-17  3:37 ` Zhao Zhili
  2023-09-17  8:53   ` Matthieu Bouron
  0 siblings, 1 reply; 2+ messages in thread
From: Zhao Zhili @ 2023-09-17  3:37 UTC (permalink / raw)
  To: ffmpeg-devel; +Cc: Zhao Zhili

From: Zhao Zhili <zhilizhao@tencent.com>

Signed-off-by: Zhao Zhili <zhilizhao@tencent.com>
---
 libavcodec/jni.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/libavcodec/jni.c b/libavcodec/jni.c
index 85dcf2abaf..ae6490de9d 100644
--- a/libavcodec/jni.c
+++ b/libavcodec/jni.c
@@ -34,8 +34,8 @@
 #include "libavutil/log.h"
 #include "ffjni.h"
 
-void *java_vm;
-pthread_mutex_t lock = PTHREAD_MUTEX_INITIALIZER;
+static void *java_vm;
+static pthread_mutex_t lock = PTHREAD_MUTEX_INITIALIZER;
 
 int av_jni_set_java_vm(void *vm, void *log_ctx)
 {
-- 
2.34.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [FFmpeg-devel] [PATCH 2/2] avcodec/jni: make global variables static
  2023-09-17  3:37 ` [FFmpeg-devel] [PATCH 2/2] avcodec/jni: make global variables static Zhao Zhili
@ 2023-09-17  8:53   ` Matthieu Bouron
  0 siblings, 0 replies; 2+ messages in thread
From: Matthieu Bouron @ 2023-09-17  8:53 UTC (permalink / raw)
  To: FFmpeg development discussions and patches; +Cc: Zhao Zhili

On Sun, Sep 17, 2023 at 5:38 AM Zhao Zhili <quinkblack@foxmail.com> wrote:

> From: Zhao Zhili <zhilizhao@tencent.com>
>
> Signed-off-by: Zhao Zhili <zhilizhao@tencent.com>
> ---
>  libavcodec/jni.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/libavcodec/jni.c b/libavcodec/jni.c
> index 85dcf2abaf..ae6490de9d 100644
> --- a/libavcodec/jni.c
> +++ b/libavcodec/jni.c
> @@ -34,8 +34,8 @@
>  #include "libavutil/log.h"
>  #include "ffjni.h"
>
> -void *java_vm;
> -pthread_mutex_t lock = PTHREAD_MUTEX_INITIALIZER;
> +static void *java_vm;
> +static pthread_mutex_t lock = PTHREAD_MUTEX_INITIALIZER;
>
>  int av_jni_set_java_vm(void *vm, void *log_ctx)
>  {
> --
> 2.34.1
>
>
LGTM.

Thanks,
Matthieu
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-09-17  8:53 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20230917033734.13342-1-quinkblack@foxmail.com>
2023-09-17  3:37 ` [FFmpeg-devel] [PATCH 2/2] avcodec/jni: make global variables static Zhao Zhili
2023-09-17  8:53   ` Matthieu Bouron

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git