From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id EB333450BA for ; Thu, 5 Jan 2023 12:06:14 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 657FA68BD31; Thu, 5 Jan 2023 14:06:12 +0200 (EET) Received: from out203-205-221-192.mail.qq.com (out203-205-221-192.mail.qq.com [203.205.221.192]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id DD96468B6F0 for ; Thu, 5 Jan 2023 14:06:05 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1672920362; bh=DuTcrD3BAhCWGiBo4y+l7M6L6Rj6sITv0jmQ5g9P1wg=; h=From:Subject:Date:References:To:In-Reply-To; b=dmWHZvuHKZ135IVyPKVL0hLR8bKJzxKXSY7iqD72+JNNqXkitNWStuCeP8uxbNJCj H74+czsDLbWEsRODNtkdGoWD8p+859H/rpv9DC/DJpWAX/EyiyRs4uZQwjYCZ63QcS S4aQGSmJDVN2AgGL+82PtSP5IdOCNxeeCqxOkpGk= Received: from smtpclient.apple ([119.147.10.191]) by newxmesmtplogicsvrszb1-0.qq.com (NewEsmtp) with SMTP id 18138E05; Thu, 05 Jan 2023 20:06:01 +0800 X-QQ-mid: xmsmtpt1672920361t62jw1c3j Message-ID: X-QQ-XMAILINFO: NGsJ5Fy+2UsS3pB2uACDbPQfjRrqxihEncmJuAXzeHSJdVKiwntn9PNd7hlVAX JFepkLS5h0+/ylm8J0u3bTdeD3LXVOQMfOPebnC/Wfg6Vqi8qI0b84pOSP7WsMlm6qqlndo1E9kr rcVBcBD1T36Q3eIilpAuWNVbspdyRP4nIow291pA/Rofyf0RYDS08TZpLLiaBOOovjOPzvTjc8Sh y5g2udl2SEMG3PlzHmHst51ziUQfo/L5E/SQFIdJc+qCA+NB5JQ0w9/6l3vAry4HEPWSTTxvRfl8 j9gymcYPCj+FAoTWGqGg3bMyqFHr5gar5NQI5Us5m+mOYB0F359qr6yK5AEEXHtfoaKn6zyd7b0m y0aY1BoFxMjdKL8yUnqf2bFAKYifv+4qREQ72NdPTwdGOl64fxr7RwR+nyDPYL2ILL39++tmEBHV RHA8Xwzb/zOc9KIj57vuWSivsTj/m9sro85nFWNhwdQm8wMY5F+ksaFl0qFF1J3ll+4G0Y/Apm4o MyT9zE8K2AQhH6C/ZAiYNbEZy3+eLzDawqfhkFpuwkLma4Y77CVhHleCyoGfRqPD8YHeUr5mRT8j t4e6sidogOIVqqQlJcE1dSRvaRsnrZdJqVQtrm2wlE4wQXdD3HNIPFhfSu9ZDRHnJLqnwCV0BXTb rDJmjvkg8GmAsVgPChb785hP9BENegit0SWSLUOhslzes8/Dlf2huzoJdQf7kCB3YGiYnOG/pyiY GpE1IJSVPjydEM31xZVPfq/oPScFIi9I1AOStxVROdhQ3zJ9yvMlIGVaGHoaPvBMSFB8cDGkCBT/ Q9Po92CxO02rSOof53rvtFZRSo5vYkZpVEa3TwhTHeuxe2sW8LKE3X2cKalAarITqZZRJD69kOpi 4Ljt7Q/Q9icLz97d5Cv4LaDmsoATROZ8hST0EGu3WErIE3oBO9hqfYnp9KN5aWsBizz9DMDTVQcE 4kkH9dyrFgV+ce9W09LJ11M8TUzio3D+hU4Y4afUUW+RmIXMSHWGrzxrxY7rKTfo4fmkmp14eOlZ 9Ch7VtUhpxPk9e1rTojHzcKL+V6fpmIa4gyBIuUJaWU6MO2eoSp59zzopVtb4= From: =?utf-8?B?InpoaWxpemhhbyjotbXlv5fnq4spIg==?= Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Date: Thu, 5 Jan 2023 20:06:01 +0800 References: <20230105161416.194463-1-quinkblack@foxmail.com> To: FFmpeg development discussions and patches In-Reply-To: X-OQ-MSGID: <41D71DF4-8AEF-4DD8-A2C3-5FFC3D7BE2F6@foxmail.com> X-Mailer: Apple Mail (2.3696.120.41.1.1) Subject: Re: [FFmpeg-devel] [RFC PATCH 2/4] avcodec/cbs_h2645: keep nal->nuh_layer_id > 0 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > On Jan 5, 2023, at 19:18, James Almer wrote: > > On 1/5/2023 1:14 PM, Zhao Zhili wrote: >> From: Zhao Zhili >> --- >> libavcodec/cbs_h2645.c | 3 --- >> 1 file changed, 3 deletions(-) >> diff --git a/libavcodec/cbs_h2645.c b/libavcodec/cbs_h2645.c >> index 4ee06003c3..b12abede29 100644 >> --- a/libavcodec/cbs_h2645.c >> +++ b/libavcodec/cbs_h2645.c >> @@ -477,9 +477,6 @@ static int cbs_h2645_fragment_add_nals(CodedBitstreamContext *ctx, >> AVBufferRef *ref; >> size_t size = nal->size; >> - if (nal->nuh_layer_id > 0) >> - continue; > > Have you tested samples with NALUs with a layer > 0? How does CBS handle them in both reading and writing? Yes, only with hevc alpha layer encoding. Both reading and writing work fine. What is missing is parse VPS extension, SEI alpha channel info and so on. Patch 4/4 rewrite nuh_layer_id from non-zero to zero, and it works from my test (for independent non-base layer). > >> - >> // Remove trailing zeroes. >> while (size > 0 && nal->data[size - 1] == 0) >> --size; > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".