From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 882454397B for ; Mon, 4 Jul 2022 03:58:52 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 70CC468B99F; Mon, 4 Jul 2022 06:58:49 +0300 (EEST) Received: from out162-62-57-210.mail.qq.com (out162-62-57-210.mail.qq.com [162.62.57.210]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 80D0268B8B4 for ; Mon, 4 Jul 2022 06:58:41 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1656907116; bh=61lScj23r9w10iP+PxcZo+bSeQK1XRHKD68fDStWTRk=; h=From:Subject:Date:References:To:In-Reply-To; b=IqqSd69H5l+6+npZ2Rqx3Vpm0Edd9JKQE0OnRx+BOaDIvq+DLHh8zE9C/CGlakxuh xqXeIJEzdUB8stKqrQ+HiCw5Bj/IcbNuqeqCR0PbJGY+g+c61Z5i228YWfk+0jSVQf ncZl5jTcO0PcVBzhsTlf5e5rTJXvieTYwDVmKSl0= Received: from [192.168.255.10] ([113.108.77.72]) by newxmesmtplogicsvrsza5.qq.com (NewEsmtp) with SMTP id EA38C8C1; Mon, 04 Jul 2022 11:58:35 +0800 X-QQ-mid: xmsmtpt1656907115tmn09hn5k Message-ID: X-QQ-XMAILINFO: NZuv37oEiaZlF7+tlDVJmEuTLfkilu3990krR/4w1wJGWSsGECoqYi4ja1S5jj uWn9gdcKJ20YuU1T4s58j7As7V4zxa5QbtRSyCX+Rbco/docaWPadXrRXOcbcxNVFBDRHrHeF/zV fFZu9hw4cmu8OTuONfXoZxXd4MggrPM2tbthZ/YGKB7n74cCH6y2QuLBdg0xRFg9IjYLwiRwnba2 osOo2F/mnbnsTbXSHne7kGn3mqGQD6NXdpg611JeRs363lXN3jaWlPHI3xN7B+obiy71ax9mxYb8 mwWfVruq+LuOSEpItvdCo+rxo8Gws9HZ0zEhhsu2UBRAWdibhqPtnCB5d3B2ECnUJcNXjlETRbtf NrRKqfvylkUiOBYiJZIxMFoskgC77fmXSndOEq3Zeo5LolmbidDEjRslemDuGDrhr7orWBtuR5Q8 9UZEcLl/XrOCXb5Zz58TdJLWFjtsoXVZcSyoGCkbdZArsz8GHXzQA9DY/wxg0lBC2vZlvxzcuIOC irlBIcFstgiyBs9HUjK/+VSbBM0B5s4QIDlkbv+8xudwTfdDnrgxd62KF/03d+7mckwoygsPYNgo t7J8GiPcFutkTJH9YbJ5DuOCHud+5vJGjIO38ekFA4BOq0tRHfIePBNPCXF2TRkZvpD65nNhXGX8 7t8l1yW9IhdswA67MwDKRTH9xBmBTs4wqaefHZ7bZorkpaRmUwzNciOkiBE3LrujyaMFgmNvGO4p X+L5JL/sajtPAbliFq6PsEpTT2k8xu9Iasqa8Q930MV8C2EiFHr5M0tIZIoLFTV7zilAQ5d2x9Q9 jf4jTR1Y59EkgVLsSWAoHOtsfrbzw8rkUXeBcnM5/Kc2qOTkqkm8pIBhRdUchVBoUX30oxrikftC 5OHDnkLHsAnWE3BHY1i8m/ieokzlgPQoWN3Lekrw0z3PJZhSUMetO2NQGKqPi3mlHONei57bx9 From: =?utf-8?B?InpoaWxpemhhbyjotbXlv5fnq4spIg==?= Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\)) Date: Mon, 4 Jul 2022 11:58:34 +0800 References: To: FFmpeg development discussions and patches In-Reply-To: X-OQ-MSGID: X-Mailer: Apple Mail (2.3654.60.0.2.21) Subject: Re: [FFmpeg-devel] [PATCH] avcodec/libdavs2: workaround memory leak X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > On Jun 27, 2022, at 5:57 PM, Zhao Zhili wrote: > > davs2_decoder_close doesn't free those on the fly frames which > don't get output yet. It's a design bug, but easy to workaround. > > Before the patch: > Direct leak of 1198606 byte(s) in 2 object(s) allocated from: > #0 0x563af5e1e5f0 in malloc (ffmpeg+0x6675f0) > #1 0x563af9765ef3 in davs2_malloc davs2/source/common/common.h:1240 > #2 0x563af9765ef3 in davs2_alloc_picture davs2/source/common/header.cc:815 > > Indirect leak of 3595818 byte(s) in 6 object(s) allocated from: > #0 0x563af5e1e5f0 in malloc (ffmpeg+0x6675f0) > #1 0x563af9765ef3 in davs2_malloc davs2/source/common/common.h:1240 > #2 0x563af9765ef3 in davs2_alloc_picture davs2/source/common/header.cc:815 > > Signed-off-by: Zhao Zhili > --- > libavcodec/libdavs2.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavcodec/libdavs2.c b/libavcodec/libdavs2.c > index d7625718a2..c2040775ae 100644 > --- a/libavcodec/libdavs2.c > +++ b/libavcodec/libdavs2.c > @@ -177,6 +177,7 @@ static av_cold int davs2_end(AVCodecContext *avctx) > > /* close the decoder */ > if (cad->decoder) { > + davs2_flush(avctx); > davs2_decoder_close(cad->decoder); > cad->decoder = NULL; > } > -- > 2.35.3 > Applied as 066368e8373d18b496203fa91d98bf11a9b7f59f. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".