From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 0DABB4372F for ; Tue, 28 Jun 2022 03:03:19 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 941D668B8AE; Tue, 28 Jun 2022 06:03:16 +0300 (EEST) Received: from out203-205-221-202.mail.qq.com (out203-205-221-202.mail.qq.com [203.205.221.202]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 302E668B7DB for ; Tue, 28 Jun 2022 06:03:08 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1656385382; bh=8PvL9+yt/i7RuaMsj5r//ZpkCQLj/5szD1EAigot76s=; h=From:Subject:Date:References:To:In-Reply-To; b=Odd5aL3FC5eemscgTTBUUbhcjmBGGK8Y39aaU/XeInLG/lK6BSVss2AQ4CL23aUsC 6GpGqy7jW+fsnCYnbEgjLvA70/MZOjCv3I9zGVlH8NITaK1efCpvTX9rWnhf9n23SD NZsCqUTzlvjgq0ZtQM6um+WZ/Dry8klG1v1xaCvk= Received: from [192.168.255.10] ([59.37.125.120]) by newxmesmtplogicsvrsza5.qq.com (NewEsmtp) with SMTP id C12764F; Tue, 28 Jun 2022 11:03:01 +0800 X-QQ-mid: xmsmtpt1656385381tx31swjfd Message-ID: X-QQ-XMAILINFO: NhpLzBn2I3XwvTE43C035vboC86Kycpob4Oro7DtjlOb87CuVIbRWCz6XMZKD4 IaVKl3MulxrXQBRyY6zXiPusdF/liBJQJWA7k5dqIbx4JR//4uSnNAIfTJl3hARagJNli88UUSh8 mqgPVw/4Xezu16xSQ4F+RxD4XOnjFYb3B/K+LqyaPKd5cVcBCk/7WjnGic9GFOwhYB78Hp+LieM6 zDItqkAqxoSXG+UFpw3xrQdQCPhih/APPPg71ZMTG93hg4lkFwdTEDXTkRZQ1J0aWByKiklk9rhR Aa/YV9B0eudpUoGNp+d3SxvgmZBkdWkYuN+LQwQv6XSS9YiecjsjgbakSw+Fcql5UBw5kPLXTnqC uK1XVbwwjM4NoW58awjXtVGHNu93BKxjwtkrGU1ao9wXKNaj+VAdM7pOAC2UBx2C+aPRIxblfPV9 J0oLoyZqWGn83TMqJdFcYTJQlavGkt4S9hszWZmkYzcmjBjsCC1tebpQkmrdGUgQgr8q4De5Qmmj WEK2HADcXDDZ0y+WEPTRejpcMkPnGGciSxZSnPd0jUDkXqj80liFoTmv4ihtVs7cCQVEcn89/cXH fdV1sc6eyE+zSZJb/2oGJlbYYIgZF+d091V/XyrFyBc+2y5mOc+jQrQXMpnMgnH1UuPDs0ulNknF pqRK5bVdF0M99/1zqhRvt1waJbWkt8XtdWak0C+p4w3ELFenNXwLSWIlzPtk5cvk40ZCSnFpMQRG NyL0WfgpJuj1sqRaH1sGfE/SQUShr6mTgBwZGPMMJwypa7gWLyxDn/hInqzBJ7tOCxMMDTTUyJg0 PzxU8AD04g/GsVyUeR+L0v9IwzEzmc9PBEU+95VeyI16OM9/sraQwQysF5GlIBOuO/fcoTJUgzpO OP0uwJ5J8xBhG7tSjfLuHEehPwFD4NpeFdMMxb6bEj From: =?utf-8?B?InpoaWxpemhhbyjotbXlv5fnq4spIg==?= Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\)) Date: Tue, 28 Jun 2022 11:03:00 +0800 References: <20220627200241.7102-1-cus@passwd.hu> <20220627200241.7102-3-cus@passwd.hu> To: FFmpeg development discussions and patches In-Reply-To: <20220627200241.7102-3-cus@passwd.hu> X-OQ-MSGID: <48199B9F-D5AB-40CD-878F-D3CA9A5922C4@foxmail.com> X-Mailer: Apple Mail (2.3654.60.0.2.21) Subject: Re: [FFmpeg-devel] [PATCH 3/3] avformat/mov: disallow a zero sample size in trun atoms X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > On Jun 28, 2022, at 4:02 AM, Marton Balint wrote: > > In order to not generate 0 sized packets or create a huge index table > needlessly. > > Fixes: Timeout > Fixes: 43717/clusterfuzz-testcase-minimized-ffmpeg_IO_DEMUXER_fuzzer-5206008287330304 > Fixes: 45738/clusterfuzz-testcase-minimized-ffmpeg_IO_DEMUXER_fuzzer-6142535657979904 > > Signed-off-by: Marton Balint > --- > libavformat/mov.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavformat/mov.c b/libavformat/mov.c > index c6fbe511c0..d7ef6ba6d6 100644 > --- a/libavformat/mov.c > +++ b/libavformat/mov.c > @@ -5179,6 +5179,8 @@ static int mov_read_trun(MOVContext *c, AVIOContext *pb, MOVAtom atom) > distance++; > if (av_sat_add64(dts, sample_duration) != dts + (uint64_t)sample_duration) > return AVERROR_INVALIDDATA; > + if (!sample_size) > + return AVERROR_INVALIDDATA; > dts += sample_duration; > offset += sample_size; > sc->data_size += sample_size; LGTM. > -- > 2.35.3 > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".