From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id F40BC46FCE for ; Fri, 24 Nov 2023 17:01:42 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8BEE068CF41; Fri, 24 Nov 2023 19:01:39 +0200 (EET) Received: from out203-205-221-233.mail.qq.com (out203-205-221-233.mail.qq.com [203.205.221.233]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id AF79968CC8F for ; Fri, 24 Nov 2023 19:01:31 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1700845286; bh=bzHv50XcGXNoIsUwa1BVdeNyj9tvhAwIvGtn0yRZZ5Q=; h=From:Subject:Date:References:To:In-Reply-To; b=vfD7y4CkdsJgHpimKcGnM5dUGbJdILcFmElolClB1KVNvdVyyJ6Ur1q8WBOAwz+gz aXCeqUwSrDcJ/FUVfIZedx4nYr1miIGHQqWMfTyqpGfxzJazu8jMVdI5yfjEUwKqy3 ciA3/3/ko0dR3eQ82Nd+Hb+EOJl6IcWwEQdugWNE= Received: from smtpclient.apple ([121.35.185.242]) by newxmesmtplogicsvrsza7-0.qq.com (NewEsmtp) with SMTP id 5993213; Sat, 25 Nov 2023 01:01:25 +0800 X-QQ-mid: xmsmtpt1700845285tdxxdjmwf Message-ID: X-QQ-XMAILINFO: OakVxA/3u/8RChWQRqldTY56TKc57Vx7poDqz8IjZJ4fkyMbqZRDRjbqJIxAqY jd/DvEG7+/MJND2E3BG6LMX63XrOiM48RBQYzRriH+ZhEIwJbVwWD0OcF3E1OiYK+O3TUVNpdC5n y1aTAvB5P65yZFaSL+O0pUY2qOHcBT0eTygP8+p1L8rFA67UH1UKLxY1/lhdUIjJbY+OWDTQb262 +9sJCCrGNtn0kbBW5zmD5O3GTnQ05ZdV1K5iiVaM4HGhJFuBf23dChmBILjkcCeIUOw9jllgPDEc krbE9uKckZI8pU6G1zwPLON2Jfw7PlPMR2xMI9hIWrOeK2fnxuX8OxoBIqzzQMw0pt1+5RysgEMK miQDd9JtH0OpgMojpE2LL5BFDrdKWhpwDjp7e7k3S4H9sWsVrD3ge1qXD4NDpb1jSOfH2h/kg7pb XSRkTn7MRagjbgOeRxPqqnlUlVWzqCZC25e2l+ZALKLkHv5KUsauj7gMJdcdckzgdi53mrcdIUMH JvnKpVJy7NWHfH2sQv6uGuN8+rXzKAmCNlhv1TyH1vVb2pxkojiIWfpQdfSNtZIopx/vk92eecs4 GQAjRFI8y39D5Ek69Egl24GeNACCuC8mBf+lWtKX0W1uSoxEGy17ZbB1YdL7r0yfznUaLig5QhHI PVWczJ9VqfS3CLbCV960g/qGrb+XJ2WJMP9Azl5DmBTH4jW2mTAetWxHp1DZnm98ORK1Vk33fcEi LS81IK+QGcWlj6/dDcaDVsQ7+d/IzwVVZJ6kYe3tocrv9zkx6iAm1v49PK2u9RuMhS9DduokAaip BPK3OZt9okMhOnFafgiu31MOXeeBH41m3qR76UhxVuQQiwv2NxvwdA1qPIf9N0BwPdeJuW/3AbNd Yk8P89Vy4vnXd7iEyFX7ccNpOC1FJ8qVvx8wl64p6bcrRowWsDNx1CFcg37Gu3BrdyrkyaYj8D7k W2cDRumufsRly0j7+NdOAakZD9K1J6 X-QQ-XMRINFO: MSVp+SPm3vtS1Vd6Y4Mggwc= From: Zhao Zhili Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.200.91.1.1\)) Date: Sat, 25 Nov 2023 01:01:15 +0800 References: To: FFmpeg development discussions and patches In-Reply-To: X-OQ-MSGID: X-Mailer: Apple Mail (2.3774.200.91.1.1) Subject: Re: [FFmpeg-devel] [PATCH] libavcodec/videotoolboxenc.c: Only log the EncoderID on macOS >= 10.13. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > On Nov 24, 2023, at 23:40, David Bohman wrote: > > This is to fix a build failure on macOS < 10.13. > > This is a build failure in release 6.1. The issue also exists at the > top of the master branch, and the patch applies there. > --- > libavcodec/videotoolboxenc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c > index b0e827d14a..b72eb470fd 100644 > --- a/libavcodec/videotoolboxenc.c > +++ b/libavcodec/videotoolboxenc.c > @@ -1172,7 +1172,6 @@ static int vtenc_create_encoder(AVCodecContext *avctx, > return AVERROR_EXTERNAL; > } > } > -#endif > > // Dump the init encoder > { > @@ -1201,6 +1200,7 @@ static int vtenc_create_encoder(AVCodecContext *avctx, > if (encoderID != NULL) > CFRelease(encoderID); > } > +#endif It looks like kVTCompressionPropertyKey_EncoderID is the root cause of build failure. I prefer use compat_keys, so it can be build on macOS < 10.13, get the key at runtime and run on macOS >= 10.13. > > if (avctx->flags & AV_CODEC_FLAG_QSCALE && !vtenc_qscale_enabled()) { > av_log(avctx, AV_LOG_ERROR, "Error: -q:v qscale not available > for encoder. Use -b:v bitrate instead.\n"); > -- > 2.43.0 > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".