From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id ED4F440656 for ; Thu, 27 Jan 2022 08:11:31 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3C7C268B1F3; Thu, 27 Jan 2022 10:11:29 +0200 (EET) Received: from out203-205-221-202.mail.qq.com (out203-205-221-202.mail.qq.com [203.205.221.202]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id EB48A68B08E for ; Thu, 27 Jan 2022 10:11:20 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1643271077; bh=EqeMoWR1f+tR/CwwF1RzRYo3YKdP5SDmlsFn2g5e6MQ=; h=From:To:Cc:Subject:Date; b=H1teETiaWJQvWWnDAuv/05rn66X498IjmqgBB5nshIcl/fThPpxe7XzdBTHZSFQ+X KFhXydVxFmscy7KQWb6NiOppAcMxznJf1T8zevD8xZMOIk+pLL8tej8Mcro06iKVwf qfdUr8f2/NTfymB5KvxLsik3h6XhDI+Y1xV2ajX8= Received: from ZHILIZHAO-MB2.tencent.com ([113.108.77.72]) by newxmesmtplogicsvrszc6.qq.com (NewEsmtp) with SMTP id 2CFB70B7; Thu, 27 Jan 2022 16:11:15 +0800 X-QQ-mid: xmsmtpt1643271075tigdf0gpb Message-ID: X-QQ-XMAILINFO: MklzYC+sb6GFspCSIoKEXmsbhyCM/GJIcYatDcpXNqRriJd1c52Ehs/+BrJKQT dD9jJh46/Xymsn2FhTYmevLCOPMHYnHLDozaDQopGQlcndt7j1Mg9tQ43VV6PCxkfT3LGW2OzQ81 xWYp3jYNE0342sHUrfJsGfvmlPb+fpIC0USqTG+OQI/dMFXUW6W+NdS6u+pYVSi8SeDEHDCR37f8 KF2eqMgGba083otFBE/Zl31GdQowtfRexX2cJ5DtF10+ev/TKnjVxHCKUe9SX2+UKKE5anZavmUA HgtYtq3RvUatLB4BcXR1ZdROK0NrWxTiGb+cmTVMStP037l43YMdD1xe9t6c2NWGpvo9CWKN189n SWFAXJV4UwTM/LC6+XkuxXw6imIj1zIu5bhQdeWR/vcFPkQpx771c3ZBNSsqb5kWBsCV52321IXd nfgVniytykyzqkSf1Z8kyN/2U0ov7pVKgssA6vqqyUfRD2tFBO/4YLgwvN5HPNK2GiytJPb1p/+b SGbENDBqrj1b88ZruWyvopof7KGw+jBC9WQc+OAeI5JFOS5usQaPsl7M1IIZAlh2Ex7OTe84FBzc kLVemwem49NIWRtHy3X27h2PItl6B0idaYv4DFb/mbPprsCpkNptP7F+dVYwqP9CTho1y5S2HyMo hpS8F0iy4iUMzXwhVe6EXQYo7Vh/yN4wxyZECkml45b9y1/klWuNloLrZhvw5lHg4Uf7Xp2vp4c0 cckvIMWPwiSyWbkkMqKjFn0fAnYXrnh2U9jOhb4Gj1bp9wG8VlvlJub8ki0M/CI2eeJWDSyXtPZM jXqvXpyz56vW3SAztPvyQIM43tgRcxEF7GXrNkIqUGwslIOUQ6kELR6ehMDGaGB+G8aqqhpK/hUg == From: Zhao Zhili To: ffmpeg-devel@ffmpeg.org Date: Thu, 27 Jan 2022 16:11:13 +0800 X-OQ-MSGID: <20220127081113.49094-1-quinkblack@foxmail.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] hwcontext_vulkan: workaround MoltenVK's bug which leads to segmentation fault X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Zhao Zhili Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: MoltenVK doesn't reset instance pointer when CreateInstance() failed, then DestroyInstance() leads to segmentation fault. MoltenVK's bug has been fixed by [1], which doesn't available on homebrew yet. Regardless MoltenVK's bug, we shouldn't call DestroyInstance() in the case of CreateInstance() failed, so reset instance making sense. [1] https://github.com/KhronosGroup/MoltenVK/commit/86a1fbdb8 --- libavutil/hwcontext_vulkan.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavutil/hwcontext_vulkan.c b/libavutil/hwcontext_vulkan.c index 2e219511c9..ac8e00003a 100644 --- a/libavutil/hwcontext_vulkan.c +++ b/libavutil/hwcontext_vulkan.c @@ -719,6 +719,8 @@ static int create_instance(AVHWDeviceContext *ctx, AVDictionary *opts) if (ret != VK_SUCCESS) { av_log(ctx, AV_LOG_ERROR, "Instance creation failure: %s\n", vk_ret2str(ret)); + /* Workaround MoltenVK's bug which doesn't reset instance pointer. */ + hwctx->inst = (VkInstance) { 0 }; err = AVERROR_EXTERNAL; goto fail; } -- 2.31.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".