From: Zhao Zhili <quinkblack@foxmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Zhao Zhili <zhilizhao@tencent.com>
Subject: Re: [FFmpeg-devel] [PATCH 1/2] avutil/hwcontext_vulkan: add get_proc_addr option
Date: Thu, 2 Nov 2023 09:50:28 +0800
Message-ID: <tencent_5B5B9A68407B9A969F06AB494ED570A52D08@qq.com> (raw)
In-Reply-To: <169886233523.11195.1118382693128493683@lain.khirnov.net>
> 在 2023年11月2日,上午2:12,Anton Khirnov <anton@khirnov.net> 写道:
>
> Quoting Zhao Zhili (2023-11-01 17:56:46)
>> From: Zhao Zhili <zhilizhao@tencent.com>
>>
>> It allows to pass SDL_Vulkan_GetVkGetInstanceProcAddr to hwcontext.
>> ---
>> libavutil/hwcontext_vulkan.c | 14 ++++++++++++++
>> 1 file changed, 14 insertions(+)
>>
>> diff --git a/libavutil/hwcontext_vulkan.c b/libavutil/hwcontext_vulkan.c
>> index 8481427b42..155fe37a33 100644
>> --- a/libavutil/hwcontext_vulkan.c
>> +++ b/libavutil/hwcontext_vulkan.c
>> @@ -747,7 +747,21 @@ static int create_instance(AVHWDeviceContext *ctx, AVDictionary *opts)
>> .sType = VK_STRUCTURE_TYPE_INSTANCE_CREATE_INFO,
>> .pApplicationInfo = &application_info,
>> };
>> + AVDictionaryEntry *opt_d;
>> +
>> + opt_d = av_dict_get(opts, "get_proc_addr", NULL, 0);
>> + if (opt_d) {
>> + char *end = NULL;
>> + uintptr_t addr = strtoull(opt_d->value, &end, 16);
>
> This is madness.
Yes it is. Any better idea?
I can try to pass vulkan lib path, but it might impossible to get it in a portable way.
>
> --
> Anton Khirnov
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-11-02 1:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-01 16:56 Zhao Zhili
2023-11-01 18:12 ` Anton Khirnov
2023-11-02 1:50 ` Zhao Zhili [this message]
2023-11-03 7:09 ` Zhao Zhili
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_5B5B9A68407B9A969F06AB494ED570A52D08@qq.com \
--to=quinkblack@foxmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
--cc=zhilizhao@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git