From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 6D36244016 for ; Wed, 23 Nov 2022 16:50:18 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C8FEC68B78C; Wed, 23 Nov 2022 18:50:04 +0200 (EET) Received: from out203-205-221-239.mail.qq.com (out203-205-221-239.mail.qq.com [203.205.221.239]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id AD71368B155 for ; Wed, 23 Nov 2022 18:49:55 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1669222192; bh=LMCaTz3CyZR5VZSpnuZR3RBqVgSs0VBKSPApB9eOqqc=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=nS96/5bpyyL5iun7Zk029Dftqcuslr5EqtCri9DZXOEI5gObjoLLhAYgM29Zf7N7d fGwTi3GHAKObTX6OsNpOJ5sMFCtGBLP3Tmg/65KdkJ1/S13axMFrG8SxMOO6GBkQpq sBvJB/Bei9uMO2kSNpoa1ipmveoxcx2LjjsnlCL4= Received: from localhost.localdomain ([113.118.113.114]) by newxmesmtplogicsvrszc1-0.qq.com (NewEsmtp) with SMTP id C7281E6D; Thu, 24 Nov 2022 00:49:50 +0800 X-QQ-mid: xmsmtpt1669222191t8fm7sfmf Message-ID: X-QQ-XMAILINFO: MyirvGjpKb1jY0yCLrIxh5DA//hfykW1ef1wIBXezqcpSyHTtFED8iN+v8Yd5Q eNl/j4Ud/o81E+qAndDPZD0IVNIYrHTkQSIl4dnOHtgwwUbEjBvbk0Tf3jloQGy3Ec/sBOJ5lKyt 2y0yMhR4c6GY3lMKk8JirXZkIkXwV6rxSmqgql6emDl8+lmkDeHTt2y7wUbHqQEp2Fk8NdTuTC/5 gI3ghP+XToMh0J+k4xGwOWgBTMAlolaEjSe1IwojuAEjlWj1xIwCewvLjUSACZbKdv0iIPsvIATg xiEW0GzKZcsrLGtUy9R4QyxKkz6NZ8bSmSB7f/VEVM+EzjtfxSgMzC7GSZquY2Ezi+3Cds6FOs8M uMQG7c+dZyFaxRHqV05l0w2f1Jw3cAIjkxYIdkaEwRT9uxq0UMeXzfRWbDItQRDm8FQbWUwUpRh3 pG/IlJVAyzBI5dhqJSS/pdAEjRcrptFCxW9StaRzvqd4AB23cp9GPYViZkuO17rZxUggN8ZkHtmz GLCZngbDki1lZa+Td9fOQyK0SoWBb1ASbKvb5AZVlFSzhfMURjht3Q6oabJuOOFpbSYZWFn4mpvR mGcKD6/762frMbvIp94san53OZ9eyKNF87lqmMxWi8Wkwvtwuq01RhW6X+AxP4xBWUGnVZbejiPK 8wj9xCk2zsS/K2yXP6f+7y84WfNsfgkaM1njqIPBTCAkr+yqdpUPIiNuxammBI5A1/5s5TYxtpkt xw3ldo/CiqaZDDLJuAstQ6XTKFDvVzc6x/8USiKThj2I9aFd2PZb2mNutSuBhH4WTEc+bV+p9I/5 JTIBWwFWOdQQwVcjDuoflOtGc4Es+CwUS44TXak+HjYYzdBnrzsbfalEib1SbEWtSm5xx6FV55qe Pk1xV7Yw8mTdkuJk9lV88Btdn2JiO6B1mQs0W2USdMj2pTqcMQ4WxPVwfzM6/05G/ZXD3L9r3Ee/ hzHzDcjp2plO6IOGqDbQ== From: Zhao Zhili To: ffmpeg-devel@ffmpeg.org Date: Thu, 24 Nov 2022 00:49:26 +0800 X-OQ-MSGID: <20221123164926.25481-2-quinkblack@foxmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221123164926.25481-1-quinkblack@foxmail.com> References: <20221123164926.25481-1-quinkblack@foxmail.com> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 2/2] avcodec/mediacodecenc: check missing Surface X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Zhao Zhili Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: From: Zhao Zhili It's an invalid combination of Java MediaCodec with ANativeWindow. --- libavcodec/mediacodecenc.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/libavcodec/mediacodecenc.c b/libavcodec/mediacodecenc.c index 7cdde59945..a4390a9df6 100644 --- a/libavcodec/mediacodecenc.c +++ b/libavcodec/mediacodecenc.c @@ -167,6 +167,16 @@ static av_cold int mediacodec_init(AVCodecContext *avctx) av_log(avctx, AV_LOG_ERROR, "Missing hw_device_ctx or hwaccel_context for AV_PIX_FMT_MEDIACODEC\n"); goto bailout; } + /* Although there is a method ANativeWindow_toSurface() introduced in + * API level 26, it's easier and safe to always require a Surface for + * Java MediaCodec. + */ + if (!s->use_ndk_codec && !s->window->surface) { + ret = AVERROR(EINVAL); + av_log(avctx, AV_LOG_ERROR, "Missing jobject Surface for AV_PIX_FMT_MEDIACODEC. " + "Please note that Java MediaCodec doesn't work with ANativeWindow.\n"); + goto bailout; + } } for (int i = 0; i < FF_ARRAY_ELEMS(color_formats); i++) { -- 2.25.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".