From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 28D3645973 for ; Tue, 28 Feb 2023 12:02:55 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CF24268AD7D; Tue, 28 Feb 2023 14:02:33 +0200 (EET) Received: from out162-62-58-216.mail.qq.com (out162-62-58-216.mail.qq.com [162.62.58.216]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id F034368AA6D for ; Tue, 28 Feb 2023 14:02:26 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1677585743; bh=G2hF0EtuIcBXhA5iS8kbWtCLP7RnSwmzTLikCuNxiy8=; h=From:Subject:Date:References:To:In-Reply-To; b=cZtv9hw65HQuNldaK6BEPiBwIJMch7IxT5gjz+Laj+y8pn9T61pqTh4CxUdYQRfei 1k5rzQwxZFjeawFJLNNL/mYcvvYCxQsuBAeweNiouI9RF3js2ox95q89coYQw5VjzR YZfhmYdOMCGQTgqAJQqCXrJxkg9dPUTEYocBGycs= Received: from smtpclient.apple ([113.108.77.56]) by newxmesmtplogicsvrszb9-0.qq.com (NewEsmtp) with SMTP id 96840F7; Tue, 28 Feb 2023 20:02:22 +0800 X-QQ-mid: xmsmtpt1677585742tn2cinq92 Message-ID: X-QQ-XMAILINFO: MQ+wLuVvI2LQKECzNApzR+UXi0tkwwKgUUjQjHl4ysymoBpJLWfXlD8gS6GxcT oIf63ipG0Y7O0ndHU9PT6fxJYn9ccLNXbJATR/oHlj5zOUBHrWVsTVho7UHpldzq9C2l2N6eUPcc DzDl/rIXjlJL3tkow9vFYP8tI0GovqHQ+JsAqJiPFFQcy9Z4iyDzPKBiOEo5995pEEjLc1keOJCz RFkP74q49U4jBkeuR1EIraWo8axbA60ADfwvDJODwvsiMB0Y6sft0Yw9vQ9kCl9lbYxrYZbJrD5R Flr0cRpKt+v1hVonob38tTiQa48+TBMJI0+kDyWXjlu4Z21Vq69srxo6GZMX/RI8D/BvVEhp5Y0b tkiBLNXR70WpXq0w6fTC4s2fK2visvNkIQ83K/p8mp+gtzVKe+vocvHGndot16tfIvq5OfNUWQxh 8i2QdEnY2GWlJ35YC7EKJhQQGvDMmPxrUUeCKbuD5Q6X8O058nTtEfQ4Rxcoz4xFbzfCtyQza8Dr E5tPzJxfM6XBFJJNA3cRVi1w95j4I9ngf5SuNTwnepKMQrI3hefBON1luX7YpyQnoGKeAhfZ0tTo TLeUjbygHy9AFS6nLoVHVcKliiT34KCrdLQmABLR8jm+u6hukpowxKGmAFWd40XYa2grqdkywkhd 7sXJ7bGmMczQRbxvJxIB9hG/ffs4Ud1waU7TJ/rnuUABCiALi9pAeajVy3y4IjVScLgpXiW6Aj7o gXd7ZJGfgDM9cVumREn3CLVunrbxPYU4/KvTl3EoA/dPGH4kag2vA8Nms+N9Vd8FszjhhyteL8bQ +WbiyaKCRfHS3e+LdPPXEDujwA4ukToiOIar3MbQCpvUnU8PWzXClwvvAhqBFalyyyJs9WTe7o4z Ly31saZyITBsznaSdvPViatxSq6+Q1rMvjFKMzqsfO/AWlQsEPzchiOAD1wNPfb6VINY+PSH8wBl GDjkEhzoZCOJ4LZNPIPZN9lwaj9+vP From: =?utf-8?B?InpoaWxpemhhbyjotbXlv5fnq4spIg==?= Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Date: Tue, 28 Feb 2023 20:02:23 +0800 References: To: FFmpeg development discussions and patches In-Reply-To: X-OQ-MSGID: <379195EA-0E41-46C7-860E-F30C04856283@foxmail.com> X-Mailer: Apple Mail (2.3696.120.41.1.1) Subject: Re: [FFmpeg-devel] [PATCH 1/4] lavc/mediacodecenc: Add pix2color_fmt() and color2pix_fmt() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > +static int pix2color_fmt(AVCodecContext *avctx, enum AVPixelFormat pix_fmt) > +{ > + for (int i = 0; i < FF_ARRAY_ELEMS(color_formats); i++) { > + if (pix_fmt == color_formats[i].pix_fmt) { > + return color_formats[i].color_format; > + } > + } > + av_assert0(0); > +} After extracting to a general function, there is no hint that pix_fmt comes from avctx->pix_fmt. So I prefer return error code here. > + > +static enum AVPixelFormat color2pix_fmt(AVCodecContext *avctx, int color_format) > +{ > + for (int i = 0; i < FF_ARRAY_ELEMS(color_formats); i++) { > + if (color_format == color_formats[i].color_format) { > + return color_formats[i].pix_fmt; > + } > + } > + av_assert0(0); > +} _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".