From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTPS id DD7804E940
	for <ffmpegdev@gitmailbox.com>; Tue, 18 Mar 2025 13:08:21 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A65F3687A22;
	Tue, 18 Mar 2025 15:08:17 +0200 (EET)
Received: from out203-205-221-240.mail.qq.com (out203-205-221-240.mail.qq.com
 [203.205.221.240])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1E6DA687A04
 for <ffmpeg-devel@ffmpeg.org>; Tue, 18 Mar 2025 15:08:09 +0200 (EET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com;
 s=s201512; t=1742303287;
 bh=7kPI6dBe92jzpdag2RXCpNB9C1giHmMuFYjtezyHZMg=;
 h=From:Subject:Date:References:To:In-Reply-To;
 b=ysGkfPZlOSg9Hh6DznXdgWqOaB6eAp/XDaVxikOHBOtC6dC0GNGgUEnH8qHK8IeEI
 WLBa0NfHKEyN4cTMkdnAj7+oDEHrB7hNAp6Ket9NzTD6YKhNYP+V8zla1D2UnfIZnk
 9CVMovbWEEHcfcst7TGB9Qpi4fKCkNYr58H4qneE=
Received: from smtpclient.apple ([119.147.10.242])
 by newxmesmtplogicsvrsza36-0.qq.com (NewEsmtp) with SMTP
 id 2061F825; Tue, 18 Mar 2025 21:08:06 +0800
X-QQ-mid: xmsmtpt1742303286tih8507v7
Message-ID: <tencent_59212DE69A0E40D99A5B9F52AB2B4E557008@qq.com>
X-QQ-XMAILINFO: NvH2zBBgt3uTTIYJ2WzfRJTd3v/TtiSlZOe0z5uyZVdAFXX7ltRrPZ1hxeGPXI
 FQbhtGo0nlmQTdggIf9+CDGJsZrCmltWw0n5lzw0HJTnVnzxLmt9VbHVLNGvaEeZl1BY2g7VL0z9
 l5TCBjSMoPm7MW213CC0sA1UJxaATIsm6W04zw4e3akWgOjiqg4THLHPuD43tQvv7cMv2KdWlvpy
 Pz8IC+L/rG3Dj1bLGuTZMVelpOodYvBrlGX1XgyQ/q7uA2E8Rr1WZCfeRKUcKsmv3HxttbY/UhFy
 CvH2oeupbl2UuoMjLQQSOwe2WiZGN6mvNDE1SDz8QRFc+pgo9NwETnmgHqU9DO7xSgupUpoqECrN
 GK6XsHeS9NQ+JohFdI99DPLsmXoQ6DTMKiYZrulfrhkKNaKF40lAWpP+HZth3mjo0dVGu1d+FWqu
 FB1n45/h5rr+tSjJLQNu4CO6+XrtXueDfCKXuGJIRnNk/9Ix3kQkoP8eRF+5brfJMuoWBmbOCpkg
 CueCDZ8TIPOGePut0nq5tQc1o98RWCey/4OWsgO8EKInl0uMwCOuiLxxCVgbHhnNDJS0zZ6b26pJ
 f5F/T6Qg/iVWWcUOkzZc7W1KIbVnO+tnkxDxmaeFMJSQ6YFnjkskxJY/brm+t0zia3GVZeFlfLnS
 XvinpqbyFhrg3UsajVxLNSCS7RQXQuRK5EZI92t2OzRMWirdhau9uzMNdBnq3W938T//KVT6qvIH
 RZX1qNbQhKFk4qElh08xrUSY0BuOTuseh+66uGG9DnlfQEdxrTQIAKItTRfAYNMluQk/yJnbtPFM
 w8LEc8yFvzvqdV/XLz4dgTgBVmOOX9kPvomyc0ji869bY0Tva5KZdSVUVVqJO9oK+J9yP1vHBj+V
 pr0rnGcLbgt0f2UNSF95FVUBTQgnP85m659Y1EME/q6oXD1yA+OjJeNa6YaO2cW3ZlNHaazzqijJ
 GVbxY9lPX140JtMklyOXfNzqCYHp6CsJIH5fV6a0k=
X-QQ-XMRINFO: NyFYKkN4Ny6FSmKK/uo/jdU=
From: Zhao Zhili <quinkblack-at-foxmail.com@ffmpeg.org>
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3818.100.11.1.3\))
Date: Tue, 18 Mar 2025 21:07:55 +0800
References: <tencent_4F40F79A859F25AB544E1C70172D469AAF08@qq.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
In-Reply-To: <tencent_4F40F79A859F25AB544E1C70172D469AAF08@qq.com>
X-OQ-MSGID: <65BEEC6B-EDF7-41B4-9A33-8883ECD5AEB6@foxmail.com>
X-Mailer: Apple Mail (2.3818.100.11.1.3)
Subject: Re: [FFmpeg-devel] [PATCH RFC 0/6] MP4 editlist and HEVC decoder
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/tencent_59212DE69A0E40D99A5B9F52AB2B4E557008@qq.com/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>



> On Mar 18, 2025, at 20:58, Zhao Zhili <quinkblack-at-foxmail.com@ffmpeg.org> wrote:
> 
> From: Zhao Zhili <zhilizhao@tencent.com>
> 
> Fix #11510
> 
> #11510 revealed multiple issues related to mp4 demuxer, hevc decoder
> and videotoolbox.
> 
> 1. mp4 demuxer output packets have rewind due to editlist,
> 
> POC		 POC
> 916 -----------> 944
> 
> then rewind back to
> 
> 916 -----------> 944 942
> 
> 2. Both POC 916 and POC 944 are CRA nalu, so no flush on output.
> 
> 3. When decoding POC the second time, POC still inside DPB buffer.

I mean when decoding POC 944 the second time, POC 944 still inside
DPB buffer.

> 
> Patch 1/6 fix videotoolbox which shouldn't reset when confronted with
>    ReferenceMissingErr
> 
> Patch 2/6 is trial.
> 
> Patch 3/6 allow duplicated POC in DPB buffer. I'm not quite sure the
> side effect.
> 
> Patch 4 to 6 add a flag to indicate the start of a new sequence, so
> the decoder can flush on output. I know it looks suspicious, please
> comment.
> 
> There are more general stream rewind issues to be resolved.
> 
> Zhao Zhili (6):
>  avcodec/vt: Don't restart decoder when confronted with
>    ReferenceMissingErr
>  avformat/mov: generalize sgpd_sync index lookup
>  avcodec/hevc: Don't drop packet with duplicate POC
>  avcodec/packet: Add AV_PKT_FLAG_NEW_SEQUENCE flag
>  avformat/mov: Notify new sequence at the start of editlist
>  avcodec/hevc: Check AV_PKT_FLAG_NEW_SEQUENCE and flush pictures out
> 
> libavcodec/hevc/hevcdec.c |  3 +++
> libavcodec/hevc/refs.c    |  4 ++--
> libavcodec/packet.h       | 10 ++++++++++
> libavcodec/videotoolbox.c | 10 ++++++----
> libavformat/avformat.h    |  2 ++
> libavformat/mov.c         | 21 ++++++++++++++-------
> 6 files changed, 37 insertions(+), 13 deletions(-)
> 
> -- 
> 2.46.0
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".