[FFmpeg-devel] [PATCH] fftools/ffmpeg: reset pointer, which could be reused by Android and iOS

[FFmpeg-devel] [PATCH] fftools/ffmpeg: reset pointer, which could be reused by Android and iOS

[xufuji456]

---
 fftools/ffmpeg.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c
index 743bc0c6b6..0ce9531235 100644
--- a/fftools/ffmpeg.c
+++ b/fftools/ffmpeg.c
@@ -569,6 +569,13 @@ static void ffmpeg_cleanup(int ret)
     av_freep(&input_files);
     av_freep(&output_files);
 
+    nb_input_files    = 0;
+    nb_output_files   = 0;
+    nb_filtergraphs   = 0;
+    input_files       = NULL;
+    output_files      = NULL;
+    filtergraphs      = NULL;
+
     uninit_opts();
 
     avformat_network_deinit();
-- 
2.32.0 (Apple Git-132)

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: reset pointer, which could be reused by Android and iOS

["zhilizhao(赵志立)"]

> On Mar 3, 2023, at 14:51, xufuji456 <839789740@qq.com> wrote:
> 
> ---
> fftools/ffmpeg.c | 7 +++++++
> 1 file changed, 7 insertions(+)
> 
> diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c
> index 743bc0c6b6..0ce9531235 100644
> --- a/fftools/ffmpeg.c
> +++ b/fftools/ffmpeg.c
> @@ -569,6 +569,13 @@ static void ffmpeg_cleanup(int ret)
>     av_freep(&input_files);
>     av_freep(&output_files);
> 
> +    nb_input_files    = 0;
> +    nb_output_files   = 0;
> +    nb_filtergraphs   = 0;
> +    input_files       = NULL;
> +    output_files      = NULL;
> +    filtergraphs      = NULL;
> +

Until we decided to make ffmpeg cmd works as a library,
it doesn’t matter. I’m interested on the idea to make fftools
work like a library. But it depends on the community.

https://patchwork.ffmpeg.org/project/ffmpeg/patch/tencent_929F62AB2F4E5E70082DE99AE040769A1008@qq.com/

>     uninit_opts();
> 
>     avformat_network_deinit();
> -- 
> 2.32.0 (Apple Git-132)
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: reset pointer, which could be reused by Android and iOS

[Nicolas George]

"zhilizhao(赵志立)" (12023-03-03):
> >     av_freep(&input_files);
> >     av_freep(&output_files);
> > +    input_files       = NULL;
> > +    output_files      = NULL;
> Until we decided to make ffmpeg cmd works as a library,
> it doesn’t matter.

It is worse than that: the patch completely ignores the semantic of
av_freep().

Useless patch with no explanations at all in the mail => just ignore the
mail.

>		      I’m interested on the idea to make fftools
> work like a library. But it depends on the community.

That would be more or less what an extended libavfilter with movie
source and sink would be.

Regards,

-- 
  Nicolas George
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] =?gb18030?b?u9i4tKO6ICBbUEFUQ0hdIGZmdG9vbHMvZmZt?= =?gb18030?q?peg=3A_reset_pointer=2C_which_could_be_reused_by_Android_and_iOS?=

[=?gb18030?B?0Oy4o8Kh?=]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="gb18030", Size: 1846 bytes --]

Thank you for your reminding, George.
I really ignore av_freep() above.
Please ignore this patch.


// xufuji456


------------------ Ô­Ê¼Óʼþ ------------------
·¢¼þÈË:                                                                                                                        "ffmpeg-devel"                                                                                    <george@nsup.org&gt;;
·¢ËÍʱ¼ä:&nbsp;2023Äê3ÔÂ3ÈÕ(ÐÇÆÚÎå) ÏÂÎç5:31
ÊÕ¼þÈË:&nbsp;"FFmpeg development discussions and patches"<ffmpeg-devel@ffmpeg.org&gt;;
³­ËÍ:&nbsp;"Ð츣¡"<839789740@qq.com&gt;;
Ö÷Ìâ:&nbsp;Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: reset pointer, which could be reused by Android and iOS



"zhilizhao(ÕÔÖ¾Á¢)" (12023-03-03):
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp; av_freep(&amp;input_files);
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp; av_freep(&amp;output_files);
&gt; &gt; +&nbsp;&nbsp;&nbsp; input_files&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; = NULL;
&gt; &gt; +&nbsp;&nbsp;&nbsp; output_files&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; = NULL;
&gt; Until we decided to make ffmpeg cmd works as a library,
&gt; it doesn¡¯t matter.

It is worse than that: the patch completely ignores the semantic of
av_freep().

Useless patch with no explanations at all in the mail =&gt; just ignore the
mail.

&gt;		&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; I¡¯m interested on the idea to make fftools
&gt; work like a library. But it depends on the community.

That would be more or less what an extended libavfilter with movie
source and sink would be.

Regards,

-- 
&nbsp; Nicolas George
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".