From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id DFB8A49482 for ; Fri, 12 Apr 2024 09:56:01 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 403F168CEEB; Fri, 12 Apr 2024 12:55:58 +0300 (EEST) Received: from out203-205-221-210.mail.qq.com (out203-205-221-210.mail.qq.com [203.205.221.210]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9E37968D11B for ; Fri, 12 Apr 2024 12:55:50 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1712915747; bh=797amCNyLqx9NlZHKU+9dKUKv4zBn0a6ugGK8vRUVsQ=; h=Subject:From:In-Reply-To:Date:Cc:References:To; b=lmvLQUtAMS25f4D+CmkzKqQUV5FrBr5XhUfDZ6hkoD+pgt+f0KwRWnSJ7uuFRcDAr 94rfyrYKQoE/dRu+hkS+59NvTkDeGrkxIcEo+Pox6xDlkA/pXciWa1onKOJBWMyE6y nvT0GRA6gk6gbuY2p0ZiYQTw7IzYPBN4v6e+/FjY= Received: from smtpclient.apple ([113.108.77.63]) by newxmesmtplogicsvrszc6-0.qq.com (NewEsmtp) with SMTP id C68B4623; Fri, 12 Apr 2024 17:49:40 +0800 X-QQ-mid: xmsmtpt1712915380tnbw835ox Message-ID: X-QQ-XMAILINFO: MziGzrjZeogZbkFcY0swmdj5tQHj6zOnClgwqF9O1G+oTKvmqwKZZPC0xUQRev QxypSA1D1TKN3jHQfWnlLgta4CviFi2RvKnXC4J701A3TajpArJD3sYOgAebfGhty89nX43u4ryX den6MY0wKN1EQdnPOwi/cnq5sbzlcR4LzOon+rqMqDMWGPmk9SLM79fMK+ghvWNfFpk1i1Xeb1uW 9sN/2FYZef9YPQ4E+RIm3YwqjybRxUzesGd7HMoANzC55aaG0ou+A2uZrg/xHLztYZgGWTMMrmRX HsLTwsesPNNI89NBEKqI6mF59w8/ezD/2H2dKkwA0aj7oGnea/DcmlfBv+NsSmmuTjj8HIisofZq bIOMZ0FYLB6RVlYdQ8lAmYIQrtV+7QIbnTEWlCrHt6VbueM6bfjFOSO0A0H+UVjOdlQvAl/T87eU rpy11uqTY2UH55j/4EkeKuOfJuFkNFDrFGPaf9lntrb2YmFUiP1jM8K8xttPWMjMeQYs0HnVbAoD 8LzobnX//Wa7Ti9J6Sa5Z8k2bF/15IRUaCe+InbC8L+49erPkZXDBAF5uj2KWAV1ej/jW0Xw8B37 M+pPHiZBcArTmfvePlxKpsGOtXLbxOl2zNMzmk9ODi07+LmKpDytE8hOddJlZ7/ERDyLGDWamBuL GfJQF2The+VJ09b80sjUldRR/F2XE91iBq7wKCthbuGjhrDCCLS8jGyr6Y1aWqCUOZAkqKW5auhM BGPGauzhn/0ByOzVViQV6IHwsLgdtWLJmt5loQ8m+Koyk5VGQvEPTNLdVHP/QU4IRv1UF45BOL9n 35NCFLoAxB9NwVPf3bKdnLseP7o6DLoCYKowGj6cXqE2wpGifN5d6dBVAeXYOLaBeNla4j7XhWH9 FXTrw8VGd+cmWZgSeAowr7ZAT10xlfEWsOVEghsi3B5Q4ZvZuv1iI2xFzRFc+mbeuym2IoE/t+EO uwAz+mkW4zGo1G/LrzGPL8rxH+gJtUd22XR5UjMB7XVOKIrgcgTg== X-QQ-XMRINFO: NI4Ajvh11aEj8Xl/2s1/T8w= Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.200.91.1.1\)) From: Zhao Zhili In-Reply-To: <20240412091923.1046792-1-lumingyindetect@163.com> Date: Fri, 12 Apr 2024 17:49:30 +0800 X-OQ-MSGID: References: <20240412091923.1046792-1-lumingyindetect@163.com> To: FFmpeg development discussions and patches X-Mailer: Apple Mail (2.3774.200.91.1.1) Subject: Re: [FFmpeg-devel] [PATCH v1] libavfilter/af_channelsplit.c:fix memory leak X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: lumingyindetect@163.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > On Apr 12, 2024, at 17:19, LuMingYin wrote: > > Signed-off-by: LuMingYin > --- > libavfilter/af_channelsplit.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/libavfilter/af_channelsplit.c b/libavfilter/af_channelsplit.c > index d18d91dcb6..2cfac19cd3 100644 > --- a/libavfilter/af_channelsplit.c > +++ b/libavfilter/af_channelsplit.c > @@ -163,8 +163,10 @@ static int filter_frame(AVFilterLink *outlink, AVFrame *buf) > > buf_out->data[0] = buf_out->extended_data[0] = buf_out->extended_data[s->map[i]]; > ret = av_channel_layout_from_mask(&buf_out->ch_layout, 1ULL << channel); > - if (ret < 0) > + if (ret < 0){ > + av_frame_free(&buf_out); > return ret; > + } LGTM. Please pay attention to the coding style. I can fix it manually this time. > > return ff_filter_frame(ctx->outputs[i], buf_out); > } > -- > 2.25.1 > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".