From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTP id 99B5646469
	for <ffmpegdev@gitmailbox.com>; Fri, 19 May 2023 01:57:28 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 13D4568C13A;
	Fri, 19 May 2023 04:57:26 +0300 (EEST)
Received: from out203-205-251-53.mail.qq.com (out203-205-251-53.mail.qq.com
 [203.205.251.53])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 16A2668C092
 for <ffmpeg-devel@ffmpeg.org>; Fri, 19 May 2023 04:57:18 +0300 (EEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qq.com; s=s201512;
 t=1684461429; bh=qzhytnBUYLT2WN6htmxFG2QUDgtt9zsMqOm3vMfqTAQ=;
 h=In-Reply-To:References:From:To:Cc:Subject:Date;
 b=IfUSlFfqc4ldNLkS7eXMZxp8/Fd0MH//XGUye+MajfuZicZ0sEsLvycdVkqnac2eM
 ACCVqwI7XixSFf9GCu13rFDBpZ/KbwrjI60AZLxGV1uJHu0D3deT8IjLUDF6f1zom6
 3pQPKESYjnxjOKbJqiH1gaRswwgdixCQJtJ8nXTA=
X-QQ-FEAT: oHWrrGTW1dDc6WqWDAkbuvNXljmAAGFi
X-QQ-SSF: 00000000000000F0000000000000
X-QQ-XMAILINFO: MiPTq5wGoKOmk9X26jFDAbOkolVG5qSzsKEpDnga1+vAReEEzqH6QngmtGWFfv
 228N4S8UDFbhMYVL3HB4shZnmLV172ZiNRCkClf2XuIiUJQdcl9LRovMaqnklmSdVYpf4bQ57Ddwg
 5xK0axeADituKcHlUrdyo0uqfeNeseWkGDST1PF/VZ5WJtrOVFhgdCarP4437ugSPFv6dFiXMTnSR
 Ue4jhQevjcYuzHQXH5xEBtCzslY6jK4sEW68CIqE2lur/gpydsxZJXM1vbUp02y+ZJ+wWrPR4rBB1
 d3uAiJ+wTcJrzr/wmb8EJM0cotUirM10B9hDyi57uSY6rDJtwzpt2zoSar3YjcSajwbr1ulryDQDW
 TWSSFCbIehwPvkZqVkXyCat33lKn4HtPWh/IGXfK1kEYodxlnwyGWXyzbLT9MgaJ78SYh94MhGtWc
 +oKsphHsrmAnBxtb4E0VDLI9scB1z1/DKXEZWs8Q7SfRYD5Nm+Va/HHj2Or5Qt/aKyx6Cj4mosLWf
 Zluwils2aJl2jTFzHMGJFQoplw4aH89CmT4jlEOxF0TPmtANoBRgTz1VV7iGoJgiaFIbFEu77r7c6
 1E7tsQxvsFedV/uoP3Uj+qG6ydsLI/L7Ha4xFg6u+O2nazP64arG4x29dK11TEfrmrKCWCbJ9t9dA
 +Ot5dEYZrf+OLrzI5EnrdYqvZ8kedaqBFDDFDVwZrvvmbyWF2zw/hRJIWFfyZgeXl795CHhsFsg5s
 IKk/bW6tVodCGNML6sD40j9GJGLaWUseSkVTx59POOGdzpp012Svno5323skeEz39/xHISC48tVqk
 6bLg7bwOuVvWJPvyyRDtjkwjP7yLmP20fzz5DFx1d55h7hoV5fECq8lJ4pe1Yn1Rwz+KA9bLEqyOB
 EZpE9Y4RT2QfhCo8dclgBn20TtJ21yUUg5dEFH73JgeSF2ygzCUO5UpaQ6xzyTy
X-HAS-ATTACH: no
X-QQ-BUSINESS-ORIGIN: 2
X-Originating-IP: 113.66.47.200
In-Reply-To: <df1f5456-4637-9be8-3fce-144f1f19e845@gmail.com>
References: <tencent_82D472A0D076F6490C36630EB84136429E06@qq.com>
 <df1f5456-4637-9be8-3fce-144f1f19e845@gmail.com>
X-QQ-STYLE: 
X-QQ-mid: webmail444t1684461428t4656959
From: "=?gb18030?B?0Oy4o8Kh?=" <839789740@qq.com>
To: "=?gb18030?B?RkZtcGVnIGRldmVsb3BtZW50IGRpc2N1c3Npb25zIGFuZCBwYXRjaGVz?="
 <ffmpeg-devel@ffmpeg.org>
Mime-Version: 1.0
Date: Fri, 19 May 2023 09:57:08 +0800
X-Priority: 3
Message-ID: <tencent_534F0A7564D7C43032A6806765CFE6FD2D0A@qq.com>
X-QQ-MIME: TCMime 1.0 by Tencent
X-Mailer: QQMail 2.x
X-QQ-Mailer: QQMail 2.x
X-Content-Filtered-By: Mailman/MimeDel 2.1.29
Subject: Re: [FFmpeg-devel] [PATCH] avcodec/videotoolboxenc: add low-latency
 encoding
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: =?gb18030?B?amFtcmlhbA==?= <jamrial@gmail.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/tencent_534F0A7564D7C43032A6806765CFE6FD2D0A@qq.com/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

Thank you for your review, James.
I will use AV_CODEC_FLAG_LOW_DELAY flag instead, and submit a new patch.


------------------&nbsp;Original&nbsp;------------------
From:                                                                                                                        "FFmpeg development discussions and patches"                                                                                    <jamrial@gmail.com&gt;;
Date:&nbsp;Thu, May 18, 2023 07:36 PM
To:&nbsp;"ffmpeg-devel"<ffmpeg-devel@ffmpeg.org&gt;;

Subject:&nbsp;Re: [FFmpeg-devel] [PATCH] avcodec/videotoolboxenc: add low-latency encoding



On 5/18/2023 7:15 AM, xufuji456 wrote:
&gt; Signed-off-by: xufuji456 <839789740@qq.com&gt;
&gt; ---
&gt;&nbsp;&nbsp; libavcodec/videotoolboxenc.c | 12 ++++++++++++
&gt;&nbsp;&nbsp; 1 file changed, 12 insertions(+)
&gt; 
&gt; diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c
&gt; index c6f22723d6..88334f1851 100644
&gt; --- a/libavcodec/videotoolboxenc.c
&gt; +++ b/libavcodec/videotoolboxenc.c
&gt; @@ -251,6 +251,8 @@ typedef struct VTEncContext {
&gt;&nbsp;&nbsp; 
&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; /* can't be bool type since AVOption will access it as int */
&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; int a53_cc;
&gt; +
&gt; +&nbsp;&nbsp;&nbsp; int low_latency;
&gt;&nbsp;&nbsp; } VTEncContext;
&gt;&nbsp;&nbsp; 
&gt;&nbsp;&nbsp; static int vtenc_populate_extradata(AVCodecContext&nbsp;&nbsp; *avctx,
&gt; @@ -1441,6 +1443,16 @@ static int vtenc_create_encoder(AVCodecContext&nbsp;&nbsp; *avctx,
&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; }
&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; }
&gt;&nbsp;&nbsp; 
&gt; +&nbsp;&nbsp;&nbsp; if (vtctx-&gt;low_latency) {

Nothing seems to set this?

Also, you should check the existing AV_CODEC_FLAG_LOW_DELAY flag instead.

&gt; +&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; status = VTSessionSetProperty(vtctx-&gt;session,
&gt; +&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; kVTVideoEncoderSpecification_EnableLowLatencyRateControl,
&gt; +&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; kCFBooleanTrue);
&gt; +
&gt; +&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; if (status) {
&gt; +&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; av_log(avctx, AV_LOG_ERROR, "Error setting low latency property: %d\n", status);
&gt; +&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; }
&gt; +&nbsp;&nbsp;&nbsp; }
&gt; +
&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; status = VTCompressionSessionPrepareToEncodeFrames(vtctx-&gt;session);
&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; if (status) {
&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; av_log(avctx, AV_LOG_ERROR, "Error: cannot prepare encoder: %d\n", status);
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".