Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
* [FFmpeg-devel] [PATCH] libavdevice/avfoundation.m: Fix potential format selection error in configure_video_device
@ 2025-02-14  3:53 infiniteice-at-foxmail.com
  0 siblings, 0 replies; only message in thread
From: infiniteice-at-foxmail.com @ 2025-02-14  3:53 UTC (permalink / raw)
  To: ffmpeg-devel; +Cc: infiniteice

From: Hong Changbin <infiniteice@foxmail.com>

The loop continues even if the correct format is selected, which may result in the selected_range is not in selected_format, finally failed to configure video device.
---
 libavdevice/avfoundation.m | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/libavdevice/avfoundation.m b/libavdevice/avfoundation.m
index 61dac4b713..1318ce4a15 100644
--- a/libavdevice/avfoundation.m
+++ b/libavdevice/avfoundation.m
@@ -375,6 +375,9 @@ static int configure_video_device(AVFormatContext *s, AVCaptureDevice *video_dev
                         break;
                     }
                 }
+
+                if (selected_range)
+                    break;
             }
         }
 
-- 
2.38.1.windows.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2025-02-14  3:55 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-02-14  3:53 [FFmpeg-devel] [PATCH] libavdevice/avfoundation.m: Fix potential format selection error in configure_video_device infiniteice-at-foxmail.com

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git