From: infiniteice-at-foxmail.com@ffmpeg.org
To: ffmpeg-devel@ffmpeg.org
Cc: infiniteice@foxmail.com
Subject: [FFmpeg-devel] [PATCH] libavdevice/avfoundation.m: Fix potential format selection error in configure_video_device
Date: Fri, 14 Feb 2025 11:53:07 +0800
Message-ID: <tencent_52E3A9C9A92D17E57D90C26499D08AE00F0A@qq.com> (raw)
From: Hong Changbin <infiniteice@foxmail.com>
The loop continues even if the correct format is selected, which may result in the selected_range is not in selected_format, finally failed to configure video device.
---
libavdevice/avfoundation.m | 3 +++
1 file changed, 3 insertions(+)
diff --git a/libavdevice/avfoundation.m b/libavdevice/avfoundation.m
index 61dac4b713..1318ce4a15 100644
--- a/libavdevice/avfoundation.m
+++ b/libavdevice/avfoundation.m
@@ -375,6 +375,9 @@ static int configure_video_device(AVFormatContext *s, AVCaptureDevice *video_dev
break;
}
}
+
+ if (selected_range)
+ break;
}
}
--
2.38.1.windows.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
reply other threads:[~2025-02-14 3:55 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_52E3A9C9A92D17E57D90C26499D08AE00F0A@qq.com \
--to=infiniteice-at-foxmail.com@ffmpeg.org \
--cc=ffmpeg-devel@ffmpeg.org \
--cc=infiniteice@foxmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git