From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 07E1C43E4D for ; Tue, 16 Aug 2022 07:19:07 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5037B68B82E; Tue, 16 Aug 2022 10:19:04 +0300 (EEST) Received: from out162-62-57-64.mail.qq.com (out162-62-57-64.mail.qq.com [162.62.57.64]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B311B68B3B2 for ; Tue, 16 Aug 2022 10:18:56 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1660634333; bh=up0Xo14tC/bOkk73+U9H3uzjjm9N9Ju/RL2vWq1s+Nc=; h=From:Subject:Date:References:To:In-Reply-To; b=ENXDbpYTLyfWcgKSRIbA5V9ggYKYTnkl8DvL0+6Ge2FRfj+BkXPVYWwR7JCHSi7jN 4aBdBC/4Y3KwROi8A0TJU7XFK5j2ZiiKV+7U6dJdoqzCevNsKCYwS49nul9RPLxOtp fcS5QAjjTUPWGP8Qbo8svch/OmnR+/qzoq+CLA/0= Received: from [192.168.255.10] ([113.108.77.66]) by newxmesmtplogicsvrszc11.qq.com (NewEsmtp) with SMTP id 4B408E0F; Tue, 16 Aug 2022 15:18:52 +0800 X-QQ-mid: xmsmtpt1660634332t42s7ssau Message-ID: X-QQ-XMAILINFO: OXqwjl1DvaGd+h81Va3LL3HaphB2JA2LN4n0L/DOGAGfnVOIDD7F3XeOtHyk11 +iV3BFrnLE/fFx30jyXZ3LjzGfq2kxQnHmH2QXoxeVw3DBWRDec5PchXMTpzGDYc3RRTD+hUOmEs SAkTMaz2NOSiaO5BWzfpIZe8mpXRMHm0sij8Kiwcdv+RN0HOlxbR8i9A1wO4H/HVG07b8RPbxpkM +Dw091SUZt60w2XHHmJC99QJR1deevh5ujH9XrB+y33iCH9Q0NsgixjqzbE/E4Dap6Qn5e/xw6jw r5v8RNCXdlpwLlULbrhdFI+oWTojT0QM0ISJoNUsz8IKEMKT+NB9S0s2TOzpisRF/WA1pEvG+cxi uWHNKXsXfwRl8F7nfvyv4KJChWpopFd4VOjZdICjeZzEIu8t0qehZP/ZJKVzD3mR1IIcrVJu+TSJ lvTWBLF0RmLPbqjb1O9+lrBbJI7xh6Y9Q2JwtaQstUwNMJBdjTxr2SYcaLIbPf6UiB5+S2s9e3rP RLKlbR/R3bn7XqWva437nYJ9lasizQiAB5ueKTtm+FK6CNThJ9QBgD0XCQ6TaqbJR7x7UtOykVsd /2mQHvegm+TTMMq8a/9Sfr/ziIneYCx3JSsvyEkN4zJQ+QTCOoY985BTEa51S3U1kZEAJsL+J8LK Fa31kat6h+ubowELM3zNuq0gdtF0Il+TJJbZASlnPabTkcqXaCfIKHW+ItvC3I/s+lC0WjjHfBkk kTqG+DVwxhCqW5Qw5aCiPuGDp409TG/d8dxdEXjBdy6pZEQU2Ka6V0vfAd01AJtfMqqrIgow7dhc 5NwMKCNdniCZwE10KFU96Ul/+AJgJnIhjaJ1ZGoZEr6XkoJJ6arKm43zXOjlaEbVQv3nSfQbg7mi YX3myiLZbEDzpSmWrApL2pdWiH5ZrfFtLwUIQilcib8dt1B1V43zazhVChlC+Qsoy9AzNLvlDS4X tdfWrw6PhGMNl+T1AJLA== From: =?utf-8?B?InpoaWxpemhhbyjotbXlv5fnq4spIg==?= Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\)) Date: Tue, 16 Aug 2022 15:18:53 +0800 References: <20220815231442.1976-1-jamrial@gmail.com> To: FFmpeg development discussions and patches In-Reply-To: <20220815231442.1976-1-jamrial@gmail.com> X-OQ-MSGID: X-Mailer: Apple Mail (2.3654.60.0.2.21) Subject: Re: [FFmpeg-devel] [PATCH] avformat/mov: don't read duration from mvhd atom X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > On Aug 16, 2022, at 7:14 AM, James Almer wrote: > > This duration is equal to the longest duration in all track's tkhd atoms, which > may be comprised of the sum of all edit lists in each track. Empty edit lists > in tracks represent start_time, and the actual media duration is stored in the > mdhd atom. > This change lets the generic demux code derive the longest track duration taken > from mdhd atoms, so the correct duration and start_time combination will be > reported. > > Should fix ticket #9775. The patch LGTM. However, does the ticket indicts some issue related to the mov muxer, which may be hidden by the patch? > > Signed-off-by: James Almer > --- > libavformat/mov.c | 4 ---- > tests/ref/fate/gaplessenc-itunes-to-ipod-aac | 2 +- > 2 files changed, 1 insertion(+), 5 deletions(-) > > diff --git a/libavformat/mov.c b/libavformat/mov.c > index 6ee6ed0950..fee9c39f39 100644 > --- a/libavformat/mov.c > +++ b/libavformat/mov.c > @@ -1516,10 +1516,6 @@ static int mov_read_mvhd(MOVContext *c, AVIOContext *pb, MOVAtom atom) > av_log(c->fc, AV_LOG_TRACE, "time scale = %i\n", c->time_scale); > > c->duration = (version == 1) ? avio_rb64(pb) : avio_rb32(pb); /* duration */ > - // set the AVFormatContext duration because the duration of individual tracks > - // may be inaccurate > - if (!c->trex_data) > - c->fc->duration = av_rescale(c->duration, AV_TIME_BASE, c->time_scale); > avio_rb32(pb); /* preferred scale */ > > avio_rb16(pb); /* preferred volume */ > diff --git a/tests/ref/fate/gaplessenc-itunes-to-ipod-aac b/tests/ref/fate/gaplessenc-itunes-to-ipod-aac > index f967ac05bc..1f89e9af85 100644 > --- a/tests/ref/fate/gaplessenc-itunes-to-ipod-aac > +++ b/tests/ref/fate/gaplessenc-itunes-to-ipod-aac > @@ -5,7 +5,7 @@ duration_ts=103326 > [/STREAM] > [FORMAT] > start_time=0.000000 > -duration=2.344000 > +duration=2.342993 > [/FORMAT] > packet|pts=-1024|dts=-1024|duration=1024|flags=KD|side_data| > > -- > 2.37.1 > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".