* [FFmpeg-devel] [PATCH] avcodec/arm/hevc: remove duplicate mov of deblock neon
@ 2023-03-16 6:58 xufuji456
2023-03-22 7:47 ` Martin Storsjö
2023-03-23 7:40 ` Martin Storsjö
0 siblings, 2 replies; 3+ messages in thread
From: xufuji456 @ 2023-03-16 6:58 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: xufuji456
---
libavcodec/arm/hevcdsp_deblock_neon.S | 2 --
1 file changed, 2 deletions(-)
diff --git a/libavcodec/arm/hevcdsp_deblock_neon.S b/libavcodec/arm/hevcdsp_deblock_neon.S
index 7cb7487ef6..ebcd056430 100644
--- a/libavcodec/arm/hevcdsp_deblock_neon.S
+++ b/libavcodec/arm/hevcdsp_deblock_neon.S
@@ -107,7 +107,6 @@
vshl.s16 q5, q5, #1
vcgt.s16 q3, q0, q4
- vmovn.i16 d6, q3
vshr.s16 q1, q0, #2
vmovn.i16 d6, q3
vcgt.s16 q5, q1, q5
@@ -146,7 +145,6 @@
vtrn.32 q2, q5
vand q5, q2
vneg.s16 q6, q7
- vmovn.i16 d4, q5
vmovn.i16 d4, q2
vmov r8, s8
--
2.32.0 (Apple Git-132)
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [FFmpeg-devel] [PATCH] avcodec/arm/hevc: remove duplicate mov of deblock neon
2023-03-16 6:58 [FFmpeg-devel] [PATCH] avcodec/arm/hevc: remove duplicate mov of deblock neon xufuji456
@ 2023-03-22 7:47 ` Martin Storsjö
2023-03-23 7:40 ` Martin Storsjö
1 sibling, 0 replies; 3+ messages in thread
From: Martin Storsjö @ 2023-03-22 7:47 UTC (permalink / raw)
To: FFmpeg development discussions and patches; +Cc: xufuji456
On Thu, 16 Mar 2023, xufuji456 wrote:
> ---
> libavcodec/arm/hevcdsp_deblock_neon.S | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/libavcodec/arm/hevcdsp_deblock_neon.S b/libavcodec/arm/hevcdsp_deblock_neon.S
> index 7cb7487ef6..ebcd056430 100644
> --- a/libavcodec/arm/hevcdsp_deblock_neon.S
> +++ b/libavcodec/arm/hevcdsp_deblock_neon.S
> @@ -107,7 +107,6 @@
> vshl.s16 q5, q5, #1
> vcgt.s16 q3, q0, q4
>
> - vmovn.i16 d6, q3
> vshr.s16 q1, q0, #2
> vmovn.i16 d6, q3
> vcgt.s16 q5, q1, q5
> @@ -146,7 +145,6 @@
> vtrn.32 q2, q5
> vand q5, q2
> vneg.s16 q6, q7
> - vmovn.i16 d4, q5
> vmovn.i16 d4, q2
> vmov r8, s8
>
> --
> 2.32.0 (Apple Git-132)
LGTM, pushed.
// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [FFmpeg-devel] [PATCH] avcodec/arm/hevc: remove duplicate mov of deblock neon
2023-03-16 6:58 [FFmpeg-devel] [PATCH] avcodec/arm/hevc: remove duplicate mov of deblock neon xufuji456
2023-03-22 7:47 ` Martin Storsjö
@ 2023-03-23 7:40 ` Martin Storsjö
1 sibling, 0 replies; 3+ messages in thread
From: Martin Storsjö @ 2023-03-23 7:40 UTC (permalink / raw)
To: FFmpeg development discussions and patches; +Cc: xufuji456
On Thu, 16 Mar 2023, xufuji456 wrote:
> ---
> libavcodec/arm/hevcdsp_deblock_neon.S | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/libavcodec/arm/hevcdsp_deblock_neon.S b/libavcodec/arm/hevcdsp_deblock_neon.S
> index 7cb7487ef6..ebcd056430 100644
> --- a/libavcodec/arm/hevcdsp_deblock_neon.S
> +++ b/libavcodec/arm/hevcdsp_deblock_neon.S
> @@ -107,7 +107,6 @@
> vshl.s16 q5, q5, #1
> vcgt.s16 q3, q0, q4
>
> - vmovn.i16 d6, q3
> vshr.s16 q1, q0, #2
> vmovn.i16 d6, q3
> vcgt.s16 q5, q1, q5
> @@ -146,7 +145,6 @@
> vtrn.32 q2, q5
> vand q5, q2
> vneg.s16 q6, q7
> - vmovn.i16 d4, q5
> vmovn.i16 d4, q2
> vmov r8, s8
>
> --
> 2.32.0 (Apple Git-132)
This patch broke the fate-hevc tests (there is currently no checkasm
coverage for this function), so I had to push a revert for it.
Please do run the fate-hevc tests before submitting patches.
// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-03-23 7:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-16 6:58 [FFmpeg-devel] [PATCH] avcodec/arm/hevc: remove duplicate mov of deblock neon xufuji456
2023-03-22 7:47 ` Martin Storsjö
2023-03-23 7:40 ` Martin Storsjö
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git