Re: [FFmpeg-devel] [PATCH 3/3] tests/hevc: Fix concat input when running in MSYS2 shell

From: Zhao Zhili <quinkblack-at-foxmail.com@ffmpeg.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: softworkz <softworkz@hotmail.com>
Subject: Re: [FFmpeg-devel] [PATCH 3/3] tests/hevc: Fix concat input when running in MSYS2 shell
Date: Tue, 13 May 2025 00:53:03 +0800
Message-ID: <tencent_4970FD2D419A29404B9AF69F42ABE44ED108@qq.com> (raw)
In-Reply-To: <520f9af365f550aefc3e9abfacab83cfc8817b8e.1747043988.git.ffmpegagent@gmail.com>

> On May 12, 2025, at 17:59, softworkz <ffmpegagent@gmail.com> wrote:
> 
> From: softworkz <softworkz@hotmail.com>
> 
> MSYS2 considers the colon (:) as path separator (=separating multiple
> paths) and thinks it needs to convert it to a Windows
> path separator (;).
> 
> Setting the MSYS2_ARG_CONV_EXCL environment variable
> keeps MSYS2 from doing this replacement.

Doesn’t work for me.

The test failed if when set

—samples=/home/quink/ffmpeg-fate-sample

but success when set

—samples=D:/bin/msys/home/quink/ffmpeg-fate-sample

Other test case don’t have this issue. With a single input,
msys can convert the unix path to Windows path before pass
to ffmpeg, but failed for concat.

> 
> Signed-off-by: softworkz <softworkz@hotmail.com>
> ---
> tests/fate/hevc.mak | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/fate/hevc.mak b/tests/fate/hevc.mak
> index e432345ef7..dee34e940d 100644
> --- a/tests/fate/hevc.mak
> +++ b/tests/fate/hevc.mak
> @@ -283,7 +283,7 @@ $(TARGET_SAMPLES)/hevc-conformance/LS_A_Orange_2.bit|$\
> $(TARGET_SAMPLES)/hevc/mv_nuh_layer_id.bit|$\
> $(TARGET_SAMPLES)/hevc-conformance/NoOutPrior_B_Qualcomm_1.bit|$\
> $(TARGET_SAMPLES)/hevc-conformance/MVHEVCS_A.bit
> -fate-hevc-mv-switch: CMD = framecrc -i "concat:$(INPUT)" -fps_mode passthrough -map 0:vidx:0 -map 0:vidx:1 -sws_flags +accurate_rnd+bitexact
> +fate-hevc-mv-switch: CMD = MSYS2_ARG_CONV_EXCL=concat: framecrc -i "concat:$(INPUT)" -fps_mode passthrough -map 0:vidx:0 -map 0:vidx:1 -sws_flags +accurate_rnd+bitexact
> FATE_HEVC-$(call FRAMECRC, HEVC, HEVC, SCALE_FILTER CONCAT_PROTOCOL) += fate-hevc-mv-switch
> 
> # multiview stream, select view by position
> -- 
> ffmpeg-codebot
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".