Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Zhao Zhili <quinkblack@foxmail.com>
To: ffmpeg-devel@ffmpeg.org
Cc: Zhao Zhili <zhilizhao@tencent.com>
Subject: [FFmpeg-devel] [PATCH 5/6] avformat/movenc: write ChannelLayout box for PCM
Date: Fri, 24 Feb 2023 20:25:22 +0800
Message-ID: <tencent_42D5E7D02ABD130D5C5A0B86A63C908C2606@qq.com> (raw)
In-Reply-To: <20230224122523.143571-1-quinkblack@foxmail.com>

From: Zhao Zhili <zhilizhao@tencent.com>

Signed-off-by: Zhao Zhili <zhilizhao@tencent.com>
---
 libavformat/movenc.c | 44 +++++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 43 insertions(+), 1 deletion(-)

diff --git a/libavformat/movenc.c b/libavformat/movenc.c
index 99b93c1d5b..2b84ed1afa 100644
--- a/libavformat/movenc.c
+++ b/libavformat/movenc.c
@@ -1203,6 +1203,43 @@ static int is_mp4_pcm_codec(enum AVCodecID codec)
     return 0;
 }
 
+static int mov_write_chnl_tag(AVFormatContext *s, AVIOContext *pb, MOVTrack *track)
+{
+    int64_t pos = avio_tell(pb);
+    int layout = 0;
+    int ret;
+    uint8_t speaker_pos[64] = { };
+
+    ret = ff_mov_get_channel_config_from_layout(&track->par->ch_layout, &layout);
+    if (ret || !layout) {
+        layout = 0;
+        ret = ff_mov_get_channel_positions_from_layout(&track->par->ch_layout,
+                speaker_pos, FF_ARRAY_ELEMS(speaker_pos));
+        if (ret) {
+            char buf[128] = {};
+
+            av_channel_layout_describe(&track->par->ch_layout, buf, sizeof(buf));
+            av_log(s, AV_LOG_WARNING, "unsupported channel layout %s, skip 'chnl'\n", buf);
+            return 0;
+        }
+    }
+
+    avio_wb32(pb, 0); /* size */
+    ffio_wfourcc(pb, "chnl");
+    avio_wb32(pb, 0); /* version & flags */
+
+    avio_w8(pb, 1); /* stream_structure */
+    avio_w8(pb, layout);
+    if (layout) {
+        avio_wb64(pb, 0);
+    } else {
+        for (int i = 0; i < track->par->ch_layout.nb_channels; i++)
+            avio_w8(pb, speaker_pos[i]);
+    }
+
+    return update_size(pb, pos);
+}
+
 static int mov_write_pcmc_tag(AVFormatContext *s, AVIOContext *pb, MOVTrack *track)
 {
     int64_t pos = avio_tell(pb);
@@ -1353,8 +1390,13 @@ static int mov_write_audio_tag(AVFormatContext *s, AVIOContext *pb, MOVMuxContex
         ret = mov_write_dmlp_tag(s, pb, track);
     else if (track->vos_len > 0)
         ret = mov_write_glbl_tag(pb, track);
-    else if (track->mode == MODE_MP4 && is_mp4_pcm_codec(track->par->codec_id))
+    else if (track->mode == MODE_MP4 && is_mp4_pcm_codec(track->par->codec_id)) {
+        if (track->par->ch_layout.nb_channels > 1)
+            ret = mov_write_chnl_tag(s, pb, track);
+        if (ret < 0)
+            return ret;
         ret = mov_write_pcmc_tag(s, pb, track);
+    }
 
     if (ret < 0)
         return ret;
-- 
2.25.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  parent reply	other threads:[~2023-02-24  4:26 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20230224122523.143571-1-quinkblack@foxmail.com>
2023-02-24 12:25 ` [FFmpeg-devel] [PATCH 1/6] avformat/movenc: add PCM in mp4 support Zhao Zhili
2023-02-24  9:41   ` Tomas Härdin
2023-02-24 18:29     ` Zhao Zhili
2023-02-24 12:25 ` [FFmpeg-devel] [PATCH 2/6] avformat/mov: fix ISO/IEC 23003-5 support Zhao Zhili
2023-02-24  9:41   ` Tomas Härdin
2023-02-24 12:25 ` [FFmpeg-devel] [PATCH 3/6] avformat/isom_tags: remove ipcm from movaudio_tags Zhao Zhili
2023-02-24  9:42   ` Tomas Härdin
2023-02-24 12:25 ` [FFmpeg-devel] [PATCH 4/6] avformat/mov: parse ISO-14496-12 ChannelLayout Zhao Zhili
2023-02-24  9:42   ` Tomas Härdin
2023-02-24 18:37     ` Zhao Zhili
2023-02-24 13:49   ` Jan Ekström
2023-02-25  4:31     ` Zhao Zhili
2023-10-31  3:15     ` Zhao Zhili
2023-10-31  3:15     ` Zhao Zhili
2023-02-24 12:25 ` Zhao Zhili [this message]
2023-02-24  9:42   ` [FFmpeg-devel] [PATCH 5/6] avformat/movenc: write ChannelLayout box for PCM Tomas Härdin
2023-02-24 12:25 ` [FFmpeg-devel] [PATCH 6/6] fate/mov: add PCM in mp4 test Zhao Zhili

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tencent_42D5E7D02ABD130D5C5A0B86A63C908C2606@qq.com \
    --to=quinkblack@foxmail.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    --cc=zhilizhao@tencent.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git