From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id B8D50411BD for ; Tue, 19 Apr 2022 05:13:14 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 21FD068B20C; Tue, 19 Apr 2022 08:13:11 +0300 (EEST) Received: from out203-205-221-210.mail.qq.com (out203-205-221-210.mail.qq.com [203.205.221.210]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 92D1A68B137 for ; Tue, 19 Apr 2022 08:13:03 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1650345178; bh=wfVc70usXcUXKGh0GATDUukOeGJ956B8AkGZjFwkvxo=; h=From:To:Cc:Subject:Date; b=S6vLGrEJ8gF2qWv9sXouGX56Sfly042s7FXkfRGyrTFvrErauB+k1B/iazjRg4aQF R2PGfx4tTaR64GAhVr37Ue8a3mNjQ558UHnZP21Fy+VBY5phJoURcEnvo7I1EAyBnH brsbJaLXphqEHM9ACkddTD9Nl/Ghe3apS2D/Yvk8= Received: from ZHILIZHAO-MB2.tencent.com ([113.108.77.53]) by newxmesmtplogicsvrszb7.qq.com (NewEsmtp) with SMTP id 33215C33; Tue, 19 Apr 2022 13:12:50 +0800 X-QQ-mid: xmsmtpt1650345170t8ja023b3 Message-ID: X-QQ-XMAILINFO: MmpliBmRb3iCf6uGpEnr+out1mqYEbUDkgGc3ud75lKligxU2QX0tGt3zcvs2w fOe0G2YViSAefsaHPNSNNgO96v5k+yRZUyzWXz7O9NbF7mVLohrMVwS/UoPYnqWQT6dOQ6QTWjwR 0Hhc1KOBTj8+wKu3DATI6bQanIWZ/YxvX5bYJhx569kBjZN2utqB1d/861FRKhQEtruoGpF0Udqx 4PK2JpGtWyWkuFNJTADZ9NUJUIiRDOC1zpJBn8Dr+qqgYSA8ZPhx/eyUSLojzHq8/IfBdh4BzXb8 ZgMOil8RcOPniOfb9/OXmsWcUE2jIe4Y8J7iheEJPvTIQsmaDnk9CaBs1QOTFY4I2XBlR16UzCYB kTWbF7DBJcNCiVdv/ZqJ7GdkQSxuwo2I6lGK/x+G0jGYxNc/WJY3Rev7ufaC2yne7APMWcxsQ9r4 eN7Wk/YZ1htqSad++cnCN8YmeY0gPl2veWpiUWyKEa4ZaMMNIj6B0Fg3LTOr0/oG/ewqa6xWHgm+ MvQZU8dD+O4zWEq+FpkW6kUdlQHN1+2CANImHnekEYNYWVFihBN57corpZFS4ThFwppdpjpRWxjJ QoQk1zUbBIANOZcwOQPjAeCbt/OZV+OVMuFS5QoNSbmDHJX9gM/nneoYd2nlIMXxqZSCJS/heXRv HZEDSjiPezKlnxgplWjCeKL6fKpiVbvpiOoZbAnrdL0V13iRmLQs+8DUi+EOHeqd8fe4S/oNT3+i IpYr2+Zk2CuGK2y6qf1pet41Cxsv7fkFqDVVe/DtFa/x5eP/51gQ4zUjWAwVVy6TMOUDggmFRO+7 dCQFFflcMHqR+IkColF2T5HnG1hzMyqtTmDRqi0HFnkjaYZkb3LuT+tytYt2vU5opy9oE9ZpsCJR arSVBGOZJEZzYD47i+S5VPkACnigtnlWpN4YxD2LZDMlxOkxaarvo= From: Zhao Zhili To: ffmpeg-devel@ffmpeg.org Date: Tue, 19 Apr 2022 13:12:49 +0800 X-OQ-MSGID: <20220419051249.22018-1-quinkblack@foxmail.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] avformat/mov: skip call ff_codec_get_id if possible X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Zhao Zhili Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: ff_codec_get_id loops over ff_codec_movvideo_tags (which is a large array) two times. The result is unused most of the cases. --- libavformat/mov.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index 6c847de164..bdc8c84bae 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -2487,8 +2487,6 @@ static int mov_skip_multiple_stsd(MOVContext *c, AVIOContext *pb, int codec_tag, int format, int64_t size) { - int video_codec_id = ff_codec_get_id(ff_codec_movvideo_tags, format); - if (codec_tag && (codec_tag != format && // AVID 1:1 samples with differing data format and codec tag exist @@ -2497,7 +2495,7 @@ static int mov_skip_multiple_stsd(MOVContext *c, AVIOContext *pb, codec_tag != AV_RL32("apcn") && codec_tag != AV_RL32("apch") && // so is dv (sigh) codec_tag != AV_RL32("dvpp") && codec_tag != AV_RL32("dvcp") && - (c->fc->video_codec_id ? video_codec_id != c->fc->video_codec_id + (c->fc->video_codec_id ? ff_codec_get_id(ff_codec_movvideo_tags, format) != c->fc->video_codec_id : codec_tag != MKTAG('j','p','e','g')))) { /* Multiple fourcc, we skip JPEG. This is not correct, we should * export it as a separate AVStream but this needs a few changes -- 2.35.3 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".