* [FFmpeg-devel] [PATCH] avfilter/vf_blackdetect: Fix header guard
@ 2025-07-18 11:32 Zhao Zhili
2025-07-18 11:45 ` Niklas Haas
0 siblings, 1 reply; 3+ messages in thread
From: Zhao Zhili @ 2025-07-18 11:32 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: Zhao Zhili
From: Zhao Zhili <zhilizhao@tencent.com>
Fix fate-source failure.
---
libavfilter/vf_blackdetect.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavfilter/vf_blackdetect.h b/libavfilter/vf_blackdetect.h
index 361da2c5bc..2842084ec3 100644
--- a/libavfilter/vf_blackdetect.h
+++ b/libavfilter/vf_blackdetect.h
@@ -16,8 +16,8 @@
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
*/
-#ifndef AVFILTER_VF_BLACKDETECT_H
-#define AVFILTER_VF_BLACKDETECT_H
+#ifndef AVFILTER_BLACKDETECT_H
+#define AVFILTER_BLACKDETECT_H
#include <stddef.h>
#include <stdint.h>
--
2.46.0
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [FFmpeg-devel] [PATCH] avfilter/vf_blackdetect: Fix header guard
2025-07-18 11:32 [FFmpeg-devel] [PATCH] avfilter/vf_blackdetect: Fix header guard Zhao Zhili
@ 2025-07-18 11:45 ` Niklas Haas
2025-07-18 11:51 ` Zhao Zhili
0 siblings, 1 reply; 3+ messages in thread
From: Niklas Haas @ 2025-07-18 11:45 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: Zhao Zhili
On Fri, 18 Jul 2025 19:32:42 +0800 Zhao Zhili <quinkblack@foxmail.com> wrote:
> From: Zhao Zhili <zhilizhao@tencent.com>
>
> Fix fate-source failure.
> ---
> libavfilter/vf_blackdetect.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/libavfilter/vf_blackdetect.h b/libavfilter/vf_blackdetect.h
> index 361da2c5bc..2842084ec3 100644
> --- a/libavfilter/vf_blackdetect.h
> +++ b/libavfilter/vf_blackdetect.h
> @@ -16,8 +16,8 @@
> * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
> */
>
> -#ifndef AVFILTER_VF_BLACKDETECT_H
> -#define AVFILTER_VF_BLACKDETECT_H
> +#ifndef AVFILTER_BLACKDETECT_H
> +#define AVFILTER_BLACKDETECT_H
>
> #include <stddef.h>
> #include <stdint.h>
Should update also the comment on the #endif.
I can do that locally and push the modified commit if you agree.
> --
> 2.46.0
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [FFmpeg-devel] [PATCH] avfilter/vf_blackdetect: Fix header guard
2025-07-18 11:45 ` Niklas Haas
@ 2025-07-18 11:51 ` Zhao Zhili
0 siblings, 0 replies; 3+ messages in thread
From: Zhao Zhili @ 2025-07-18 11:51 UTC (permalink / raw)
To: FFmpeg development discussions and patches
> On Jul 18, 2025, at 19:45, Niklas Haas <ffmpeg@haasn.xyz> wrote:
>
> On Fri, 18 Jul 2025 19:32:42 +0800 Zhao Zhili <quinkblack@foxmail.com> wrote:
>> From: Zhao Zhili <zhilizhao@tencent.com>
>>
>> Fix fate-source failure.
>> ---
>> libavfilter/vf_blackdetect.h | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/libavfilter/vf_blackdetect.h b/libavfilter/vf_blackdetect.h
>> index 361da2c5bc..2842084ec3 100644
>> --- a/libavfilter/vf_blackdetect.h
>> +++ b/libavfilter/vf_blackdetect.h
>> @@ -16,8 +16,8 @@
>> * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
>> */
>>
>> -#ifndef AVFILTER_VF_BLACKDETECT_H
>> -#define AVFILTER_VF_BLACKDETECT_H
>> +#ifndef AVFILTER_BLACKDETECT_H
>> +#define AVFILTER_BLACKDETECT_H
>>
>> #include <stddef.h>
>> #include <stdint.h>
>
> Should update also the comment on the #endif.
>
> I can do that locally and push the modified commit if you agree.
Yes please.
vf_colordetect has the same issue. It has already been detected by patchwork.
https://patchwork.ffmpeg.org/check/132469/
>
>> --
>> 2.46.0
>>
>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel@ffmpeg.org
>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>
>> To unsubscribe, visit link above, or email
>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-07-18 11:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-07-18 11:32 [FFmpeg-devel] [PATCH] avfilter/vf_blackdetect: Fix header guard Zhao Zhili
2025-07-18 11:45 ` Niklas Haas
2025-07-18 11:51 ` Zhao Zhili
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git