From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C3A3E4383B for ; Thu, 30 Jun 2022 09:42:30 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E50C668B609; Thu, 30 Jun 2022 12:42:27 +0300 (EEST) Received: from out203-205-221-191.mail.qq.com (out203-205-221-191.mail.qq.com [203.205.221.191]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0E91268B056 for ; Thu, 30 Jun 2022 12:42:20 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1656582135; bh=FA5DAatPaPi/AbO7XhJBugBM9nNMcQuWo8JiqLZetsY=; h=From:Subject:Date:References:To:In-Reply-To; b=KdhlG547JxysyLa8ySDx/gNbUNyjqPFyIOsDMB1mhBc4t+lsodlHKgelJ7tq0EkhJ SyI9NhRO+XBky4RxG9OVaKqbzxVipt+kJWIv60Xvfhe/GeCuN44mOF/p/rKZ1fqzfx wwjZ9m+HyR2K8g/EkSdWmX+UFM2xLVAhH9jfZeZI= Received: from [192.168.255.10] ([113.108.77.63]) by newxmesmtplogicsvrsza30.qq.com (NewEsmtp) with SMTP id A8E20E3B; Thu, 30 Jun 2022 17:42:14 +0800 X-QQ-mid: xmsmtpt1656582134tobzizdb8 Message-ID: X-QQ-XMAILINFO: OQhZ3T0tjf0aU9hfYZGXK8JsUsJRtUwe8einFnJ3yAr52/UIzN6p2EK/nCKiJf 4EnFJGgeZJmxa9mdQnQ7lSVWC6Os1GEqMg2+a37/e5uIjmn16QeW2Mdm1NITMiQ6MoQzPMi5zq4q hA+J8hrSbDo/dKc2wWV47Gy/UoyAIWxp1qObpoLtTr5c3aq/dGIE9eCHPCQp5MtIEx7kBuUKEls0 8wFLE6WscI00v3k25EzwwZMPvOCHOAv7SO2hHFwVDsTiy0SHskJ3zbRiqe2wcVR+yhOygOZ5oo3n JlvofiF55cDXvAYdvB85hko1qDtPDGwXxctqlhhi2AP/tt+AcG7OYJLoIn5Qcu8/qCW+SuaBqzvg rgkaHDX7ld4Jfs8a/3yMLHbWH21ZZeVJItqT2D5K+/Qr8bNXPmPRnTv+YiipfiFtlMwuS5HZmnjD n0/MhT/xTpuVRtWqo+uvpXkhcaoDsGg95BhWWdfYLtK77ybnorbWcRUcTw05Q0vQzq9VerhY55h+ hgFsSeJxdRG2mcHXY0Oy2g63tFZo8zo+j2cqxQ20laNfM03j0B4b6TuQ38q5FVwtoYs2GXgnTjxo BLHDoi1TzC2AA2AS3GqEoI7wiITCHPhTZpQk3jjxkhzP3eOgkbfFX1DRs5ErosdCACQg2F5Vsco1 lpZ5RAxYw8pIQxG0MAfkL22z2q9GH4V4PSwfCoKYvX8lw3nyQr3D1V1eAwtlhjgL88WDggtRUlvu IL6+EPHS/LM3siYDtEx5fh77K0JatPCofDuW59C5yaalV9ZrI25XkUty69c+SOOpwY93aKxZdObz oEAjuGmQvdzh2f8mvAvJvkRH4nCBiGJCpYaDYna7D01oGrwlBR6Afly7wEfYQhzgpZ4Woks8lOlh Q7So2R6PxWYJZ4jtSrjd+TK37dihbhycnJazPXXME7zRm4bGav6AqdzPzMnncHTpkZ/DrYDPb4I6 7NFTuSW6U= From: =?utf-8?B?InpoaWxpemhhbyjotbXlv5fnq4spIg==?= Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\)) Date: Thu, 30 Jun 2022 17:42:13 +0800 References: To: FFmpeg development discussions and patches In-Reply-To: X-OQ-MSGID: <3BF52FBC-34D8-467D-BF41-C5677950B0A0@foxmail.com> X-Mailer: Apple Mail (2.3654.60.0.2.21) Subject: Re: [FFmpeg-devel] [PATCH v2] avcodec/apedec: fix prediction X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > On Jun 30, 2022, at 5:09 PM, Zhao Zhili wrote: > > From: Zhao Zhili > > Regression since ed0001482a74b60f3d5bc5. > > Tested with: > ./ffmpeg -i foo.ape -f md5 - > for samples in #9816 and #2239. > > It gives the same result as before ed0001482a for ticket #9816, > and doesn't break ticket #2239. OK, It did break #8918. The compression_level is different between #9816 and #8918, I have no idea if it can be used as the condition, or just some random bug in the encoders which created those files. > > Signed-off-by: Zhao Zhili > --- > libavcodec/apedec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/apedec.c b/libavcodec/apedec.c > index a7c38bce1b..f5c0f75f7f 100644 > --- a/libavcodec/apedec.c > +++ b/libavcodec/apedec.c > @@ -1198,7 +1198,7 @@ static av_always_inline int predictor_update_filter(APEPredictor64 *p, > p->buf[delayB - 3] * p->coeffsB[filter][3] + > p->buf[delayB - 4] * p->coeffsB[filter][4]; > > - p->lastA[filter] = decoded + ((int64_t)((uint64_t)predictionA + (predictionB >> 1)) >> 10); > + p->lastA[filter] = decoded + ((int32_t)((uint32_t)predictionA + ((int32_t)predictionB >> 1)) >> 10); > p->filterA[filter] = p->lastA[filter] + ((int64_t)(p->filterA[filter] * 31ULL) >> 5); > > sign = APESIGN(decoded); > -- > 2.35.3 > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".