* [FFmpeg-devel] [PATCH 2/3] avcodec/videotoolboxenc: pass error code through
[not found] <20230103101832.98747-1-quinkblack@foxmail.com>
@ 2023-01-03 10:18 ` Zhao Zhili
2023-01-03 18:11 ` Tomas Härdin
2023-01-03 10:18 ` [FFmpeg-devel] [PATCH 3/3] avutil/hwcontext_videotoolbox: BGRA should be full range Zhao Zhili
1 sibling, 1 reply; 5+ messages in thread
From: Zhao Zhili @ 2023-01-03 10:18 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: Zhao Zhili
From: Zhao Zhili <zhilizhao@tencent.com>
Signed-off-by: Zhao Zhili <zhilizhao@tencent.com>
---
libavcodec/videotoolboxenc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c
index 27db4e0d5e..3b00e542cb 100644
--- a/libavcodec/videotoolboxenc.c
+++ b/libavcodec/videotoolboxenc.c
@@ -2156,7 +2156,7 @@ static int get_cv_pixel_info(
status = get_cv_pixel_format(avctx, av_format, av_color_range, color, &range_guessed);
if (status)
- return AVERROR(EINVAL);
+ return status;
if (range_guessed) {
if (!vtctx->warned_color_range) {
@@ -2338,7 +2338,7 @@ static int create_cv_pixel_buffer(AVCodecContext *avctx,
status
);
- return AVERROR_EXTERNAL;
+ return status;
}
pix_buf_pool = VTCompressionSessionGetPixelBufferPool(vtctx->session);
--
2.35.3
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 5+ messages in thread
* [FFmpeg-devel] [PATCH 3/3] avutil/hwcontext_videotoolbox: BGRA should be full range
[not found] <20230103101832.98747-1-quinkblack@foxmail.com>
2023-01-03 10:18 ` [FFmpeg-devel] [PATCH 2/3] avcodec/videotoolboxenc: pass error code through Zhao Zhili
@ 2023-01-03 10:18 ` Zhao Zhili
1 sibling, 0 replies; 5+ messages in thread
From: Zhao Zhili @ 2023-01-03 10:18 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: Zhao Zhili
From: Zhao Zhili <zhilizhao@tencent.com>
HEVC alpha layer encoding is broken without the patch.
Signed-off-by: Zhao Zhili <zhilizhao@tencent.com>
---
libavutil/hwcontext_videotoolbox.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavutil/hwcontext_videotoolbox.c b/libavutil/hwcontext_videotoolbox.c
index e442a95007..b8e6bb407f 100644
--- a/libavutil/hwcontext_videotoolbox.c
+++ b/libavutil/hwcontext_videotoolbox.c
@@ -44,7 +44,7 @@ static const struct {
} cv_pix_fmts[] = {
{ kCVPixelFormatType_420YpCbCr8Planar, false, AV_PIX_FMT_YUV420P },
{ kCVPixelFormatType_422YpCbCr8, false, AV_PIX_FMT_UYVY422 },
- { kCVPixelFormatType_32BGRA, false, AV_PIX_FMT_BGRA },
+ { kCVPixelFormatType_32BGRA, true, AV_PIX_FMT_BGRA },
#ifdef kCFCoreFoundationVersionNumber10_7
{ kCVPixelFormatType_420YpCbCr8BiPlanarVideoRange, false, AV_PIX_FMT_NV12 },
{ kCVPixelFormatType_420YpCbCr8BiPlanarFullRange, true, AV_PIX_FMT_NV12 },
--
2.35.3
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [FFmpeg-devel] [PATCH 2/3] avcodec/videotoolboxenc: pass error code through
2023-01-03 10:18 ` [FFmpeg-devel] [PATCH 2/3] avcodec/videotoolboxenc: pass error code through Zhao Zhili
@ 2023-01-03 18:11 ` Tomas Härdin
2023-01-04 2:35 ` "zhilizhao(赵志立)"
0 siblings, 1 reply; 5+ messages in thread
From: Tomas Härdin @ 2023-01-03 18:11 UTC (permalink / raw)
To: FFmpeg development discussions and patches
tis 2023-01-03 klockan 18:18 +0800 skrev Zhao Zhili:
> From: Zhao Zhili <zhilizhao@tencent.com>
>
> Signed-off-by: Zhao Zhili <zhilizhao@tencent.com>
> ---
> libavcodec/videotoolboxenc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/libavcodec/videotoolboxenc.c
> b/libavcodec/videotoolboxenc.c
> index 27db4e0d5e..3b00e542cb 100644
> --- a/libavcodec/videotoolboxenc.c
> +++ b/libavcodec/videotoolboxenc.c
> @@ -2156,7 +2156,7 @@ static int get_cv_pixel_info(
>
> status = get_cv_pixel_format(avctx, av_format, av_color_range,
> color, &range_guessed);
> if (status)
> - return AVERROR(EINVAL);
> + return status;
>
> if (range_guessed) {
> if (!vtctx->warned_color_range) {
> @@ -2338,7 +2338,7 @@ static int
> create_cv_pixel_buffer(AVCodecContext *avctx,
> status
> );
>
> - return AVERROR_EXTERNAL;
> + return status;
Are these guaranteed to always be negative?
/Tomas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [FFmpeg-devel] [PATCH 2/3] avcodec/videotoolboxenc: pass error code through
2023-01-03 18:11 ` Tomas Härdin
@ 2023-01-04 2:35 ` "zhilizhao(赵志立)"
2023-01-11 3:22 ` "zhilizhao(赵志立)"
0 siblings, 1 reply; 5+ messages in thread
From: "zhilizhao(赵志立)" @ 2023-01-04 2:35 UTC (permalink / raw)
To: FFmpeg development discussions and patches
> On Jan 4, 2023, at 02:11, Tomas Härdin <git@haerdin.se> wrote:
>
> tis 2023-01-03 klockan 18:18 +0800 skrev Zhao Zhili:
>> From: Zhao Zhili <zhilizhao@tencent.com>
>>
>> Signed-off-by: Zhao Zhili <zhilizhao@tencent.com>
>> ---
>> libavcodec/videotoolboxenc.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/libavcodec/videotoolboxenc.c
>> b/libavcodec/videotoolboxenc.c
>> index 27db4e0d5e..3b00e542cb 100644
>> --- a/libavcodec/videotoolboxenc.c
>> +++ b/libavcodec/videotoolboxenc.c
>> @@ -2156,7 +2156,7 @@ static int get_cv_pixel_info(
>>
>> status = get_cv_pixel_format(avctx, av_format, av_color_range,
>> color, &range_guessed);
>> if (status)
>> - return AVERROR(EINVAL);
>> + return status;
>>
>> if (range_guessed) {
>> if (!vtctx->warned_color_range) {
>> @@ -2338,7 +2338,7 @@ static int
>> create_cv_pixel_buffer(AVCodecContext *avctx,
>> status
>> );
>>
>> - return AVERROR_EXTERNAL;
>> + return status;
>
> Are these guaranteed to always be negative?
Yes.
>
> /Tomas
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [FFmpeg-devel] [PATCH 2/3] avcodec/videotoolboxenc: pass error code through
2023-01-04 2:35 ` "zhilizhao(赵志立)"
@ 2023-01-11 3:22 ` "zhilizhao(赵志立)"
0 siblings, 0 replies; 5+ messages in thread
From: "zhilizhao(赵志立)" @ 2023-01-11 3:22 UTC (permalink / raw)
To: FFmpeg development discussions and patches
> On Jan 4, 2023, at 10:35, zhilizhao(赵志立) <quinkblack@foxmail.com> wrote:
>
>
>
>> On Jan 4, 2023, at 02:11, Tomas Härdin <git@haerdin.se> wrote:
>>
>> tis 2023-01-03 klockan 18:18 +0800 skrev Zhao Zhili:
>>> From: Zhao Zhili <zhilizhao@tencent.com>
>>>
>>> Signed-off-by: Zhao Zhili <zhilizhao@tencent.com>
>>> ---
>>> libavcodec/videotoolboxenc.c | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/libavcodec/videotoolboxenc.c
>>> b/libavcodec/videotoolboxenc.c
>>> index 27db4e0d5e..3b00e542cb 100644
>>> --- a/libavcodec/videotoolboxenc.c
>>> +++ b/libavcodec/videotoolboxenc.c
>>> @@ -2156,7 +2156,7 @@ static int get_cv_pixel_info(
>>>
>>> status = get_cv_pixel_format(avctx, av_format, av_color_range,
>>> color, &range_guessed);
>>> if (status)
>>> - return AVERROR(EINVAL);
>>> + return status;
>>>
>>> if (range_guessed) {
>>> if (!vtctx->warned_color_range) {
>>> @@ -2338,7 +2338,7 @@ static int
>>> create_cv_pixel_buffer(AVCodecContext *avctx,
>>> status
>>> );
>>>
>>> - return AVERROR_EXTERNAL;
>>> + return status;
>>
>> Are these guaranteed to always be negative?
>
> Yes.
Patchset applied, thanks for the review.
>
>>
>> /Tomas
>>
>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel@ffmpeg.org
>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>
>> To unsubscribe, visit link above, or email
>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-01-11 3:22 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20230103101832.98747-1-quinkblack@foxmail.com>
2023-01-03 10:18 ` [FFmpeg-devel] [PATCH 2/3] avcodec/videotoolboxenc: pass error code through Zhao Zhili
2023-01-03 18:11 ` Tomas Härdin
2023-01-04 2:35 ` "zhilizhao(赵志立)"
2023-01-11 3:22 ` "zhilizhao(赵志立)"
2023-01-03 10:18 ` [FFmpeg-devel] [PATCH 3/3] avutil/hwcontext_videotoolbox: BGRA should be full range Zhao Zhili
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git