From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id B385D434E9 for ; Thu, 14 Jul 2022 11:33:32 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 40E0768BA46; Thu, 14 Jul 2022 14:33:30 +0300 (EEST) Received: from out162-62-58-211.mail.qq.com (out162-62-58-211.mail.qq.com [162.62.58.211]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1EA7B68B7D3 for ; Thu, 14 Jul 2022 14:33:22 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1657798399; bh=aTXOKZY8Hw4163G6OnXaHVIeXWQs2bE9eMJ10QzS4+M=; h=From:Subject:Date:References:To:In-Reply-To; b=gik63O2+Jz7E5L6KRa56wZporhSeEO5gcRX1olvUOVcHp3KmG/REAVT/ZpQH5GjLg 6/XAczq6/uCUonQ8ZjAZocJ5h2B3agvQHK68J/CcAkHFrPrCTNxy20RwGjXpBn377X x6KKqxMpAGBUbDUSH9iRkjVRo//kZJrCQvld3KsE= Received: from [192.168.255.10] ([113.108.77.63]) by newxmesmtplogicsvrszc10.qq.com (NewEsmtp) with SMTP id 851BB85F; Thu, 14 Jul 2022 19:33:17 +0800 X-QQ-mid: xmsmtpt1657798397tp7ud42df Message-ID: X-QQ-XMAILINFO: NZzGjqyvvdMftf048vdyxRK95u8Z4f6ypjZoOj+C4l4oi3mU8GBN7fOqyoTs6S 8HVV/58ZIeGWpOEJ3F5/HNlwuOPdUSP7UjqT7le6COOg5US7Xkolzw3aj7FQfr6rucHIQLJE4kxC GNtv38UBnEBqVpObyU373x3vD2ysXeYz3GikFBqhJsAUGMWFzctubINotT5NLAJubs72uyJ0I6Lw n6ieqbUgUOmomSaDDqe4ptZ/bDld83PqfC9tSGxpH3V2fFCD/cxViYK+D6DH/oUUDhrbXkwvETRM Ekm/jCnHDAqVVsHMzcVEeueeT6jcOPGwkd9CS6jDrKDFnzxsIla3G8TsuxnfOcfFQXly6JS34KRK 2D+sw4na+i/sT0BLrsDN2EdmqZJ+Ywqx50HSYzwQiPGhi/D8W4JvQix8lAddF23DMHGcmo9NYp3T iUh08L8FHJQvVpjPciOC0bdfuf7yNaygnKe9fyJEDMoAPbcZkyg+fq2YDDR/iXZyC2BFI6SaQa50 3cTOoPL+hO7U69zdGhT7bcpM2/MjKyRBUTt2uW/f8iaut2JTpyRaGaBWGX2q5zidySgn+YvzVs31 BMzWRxzYQpDnSbe2plUEa4woKpn/aLXbYcTs2ZOsCdO4mXaQbcq0yDx/yf4ddsTlrVw636S6QyfR yv5XPlXJnWyyeF2Nrspy8OpMO4zfIzCQ6Pttye/hSCe+b9d3v9ErP/U3tlyJimiSMirh/DKS+dF8 9OcBglsLa0VX0RU9yFzH3ZCWNgAQmunzkj/ibYO/E1vYEPUcA/Wh4s2oJgNGo8CpLC6NCyRsfbNS 8nHQpOjDtfoLgCaOZQX+Bs0zVr5quqR59Rfyjy0O5CcCPojpJS6vojW2RjyTeYkqe3vrFk1uTEbC X23MFcYo9ISl5zVjdZNB69UUjfEiCulhPMSzY4k0+1NtkE5kxiy4PPvTUqoijDRukNM75TZoZyW6 0Qv2bfugByRa+RnALAIQ== From: =?utf-8?B?InpoaWxpemhhbyjotbXlv5fnq4spIg==?= Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\)) Date: Thu, 14 Jul 2022 19:33:16 +0800 References: <807fffd6-8a8f-e8db-43f2-a3a0c447dbd9@gyani.pro> To: FFmpeg development discussions and patches In-Reply-To: X-OQ-MSGID: <8D2FBFC7-D17D-459E-844A-2AC97ED05C43@foxmail.com> X-Mailer: Apple Mail (2.3654.60.0.2.21) Subject: Re: [FFmpeg-devel] [PATCH v3] avformat/mov: discard data streams with all zero sample_delta X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > On Jul 6, 2022, at 3:05 PM, Zhao Zhili wrote: > > From: Zhao Zhili > > Streams with all zero sample_delta in 'stts' have all zero dts. > They have higher chance be chose by mov_find_next_sample(), which > leads to seek again and again. > > For example, GoPro created a 'GoPro SOS' stream: > Stream #0:4[0x5](eng): Data: none (fdsc / 0x63736466), 13 kb/s (default) > Metadata: > creation_time : 2022-06-21T08:49:19.000000Z > handler_name : GoPro SOS > > With 'ffprobe -show_frames http://example.com/gopro.mp4', ffprobe > blocks until all samples in 'GoPro SOS' stream are consumed first. > > Signed-off-by: Zhao Zhili > --- > v3: 'for ffmpeg' -> 'for ffmpeg command.' > v2: suggest how to override discard flag in log message. > libavformat/mov.c | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/libavformat/mov.c b/libavformat/mov.c > index 88669faa70..9a24e5effa 100644 > --- a/libavformat/mov.c > +++ b/libavformat/mov.c > @@ -3062,6 +3062,21 @@ static int mov_read_stts(MOVContext *c, AVIOContext *pb, MOVAtom atom) > st->nb_frames= total_sample_count; > if (duration) > st->duration= FFMIN(st->duration, duration); > + > + // All samples have zero duration. They have higher chance be chose by > + // mov_find_next_sample, which leads to seek again and again. > + // > + // It's AVERROR_INVALIDDATA actually, but such files exist in the wild. > + // So only mark data stream as discarded for safety. > + if (!duration && sc->stts_count && > + st->codecpar->codec_type == AVMEDIA_TYPE_DATA) { > + av_log(c->fc, AV_LOG_WARNING, > + "All samples in data stream index:id [%d:%d] have zero " > + "duration, stream set to be discarded by default. Override " > + "using AVStream->discard or -discard for ffmpeg command.\n", > + st->index, st->id); > + st->discard = AVDISCARD_ALL; > + } > sc->track_end = duration; > return 0; > } Will apply tomorrow if no more comments. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".