From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 4987743774 for ; Fri, 24 Feb 2023 06:47:59 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id EBEA868C0E1; Fri, 24 Feb 2023 08:47:55 +0200 (EET) Received: from out162-62-57-87.mail.qq.com (out162-62-57-87.mail.qq.com [162.62.57.87]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E201668BF20 for ; Fri, 24 Feb 2023 08:47:48 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1677221265; bh=V0zOs+B71gmnFyn3TkwpJy/uHJhS15W4XHu6/VDKlE8=; h=From:Subject:Date:References:To:In-Reply-To; b=a10lP+HY1I5qk9FsrfMbizZY+NDp8X96ecnsw1wLyNrRqtKz/2/PChgTCE7E/WtVz 50scjrhOdAGgWgSAZL2oAEO99ffjtehVTiriRy1AmSP+CrHmWmNcTE/vdG0Lc7bh7T KizNSbfwjOmc0P578b8uxb1ULG3w8bOrgkl8Bafw= Received: from smtpclient.apple ([113.108.77.71]) by newxmesmtplogicsvrszc5-0.qq.com (NewEsmtp) with SMTP id BEC000D4; Fri, 24 Feb 2023 14:47:44 +0800 X-QQ-mid: xmsmtpt1677221264tlgl2w1z6 Message-ID: X-QQ-XMAILINFO: OCYbvBDBNb9rfkJN+eAGSAC35H6S/+7ndovfvL4VGJ2EL2TTbdZOPY8il1OKEO qozCCaDThffq0yEX077ahJ7I8OnTCsoJrYvxp9YrhnjbjQo5+GMYR0OMYqGEgka848/E+j8PMoVE e5UQQFQG1E9W1SKnDkGyRBp5OfoHASVwz2yj4/sGDgoUEuyWI0Fqq7xsn5rAMJV/X0BzutJkUruf Hw9wWTn7fcmNapaAnCek9NyzEXnbK1yhrgtjBtD3KZdfQa+qQYZ2exGX8BkvXqgI7QN8qjAeK8k8 5P3HzFXNSpEUrMbnLuNS+AtmX78e8a3pNUN+WmkPd0AaF2usz4YzBYGS2aQH10L8QPrljgRfUD/O 16ycYqL/5Ky6RXoGWix4Lak5bDr5nBHXBNQzyEAqO4K4oimUCPfjnioGcowo9ghq9V2zwIZR7nx+ kSbUSquGQ1Oa1PCujZBOuGcEUvUnRNihDzlkCj3BpIrT/uViwk5HBStEILkJRYFG9CS0GLlemnxF CqGCxPfBsr3nF5B0bAQgdeP3ic1mBGOx1hjNncZdAO/pQA1tiEtQQXZ7tSyI/hnKK9G9GdY7LUvb ki6hXVzxa8cCoiHZXDSzcko4Avegi3WA8S6sRKP9xTpwUx5Kn7Sv1suEV+PrnRoc1CO8dty764YK TIMBmlQ69a+ZwO/WTH7VA3FdPy5lVeCsPrHq5qlRjOTh3AJ8gXhqFHgrnwKdXlZewH8cHjzdnXiG eW8MaXsCdgZwSljxqVMPdnf4HdcyG9xDXZpcsc1Ska79ba6dobApbJi32/mHpetvMCfegsTsH+v6 mizlDjIFjRXor3Qlfpo0YbAsI4CLirLxEeTkDaXgao+O+mZ0+xNpmADu7CIIXtQ4q7AMbAynqecS mPgFkdHbDdjrZcrIjfKU2/tqZnDf9eix3gbjiGgbKJu5q66yxWCMvQoi+llLAD9+1bCcjrZ4i27n +8roaL3JsXXt7XQaquvEGY2NRInmWAIFT8iJx9bfa+J7AE3P144U2xwtlu/uZx From: =?utf-8?B?InpoaWxpemhhbyjotbXlv5fnq4spIg==?= Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Date: Fri, 24 Feb 2023 14:47:43 +0800 References: <20230224054549.863132-1-fei.w.wang@intel.com> To: FFmpeg development discussions and patches In-Reply-To: <20230224054549.863132-1-fei.w.wang@intel.com> X-OQ-MSGID: <045F6130-BC04-47F9-8AB0-EEBFF182BF85@foxmail.com> X-Mailer: Apple Mail (2.3696.120.41.1.1) Subject: Re: [FFmpeg-devel] [PATCH v1] lavu/hwcontext_vaapi: sync surface before export its DRM handle X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > On Feb 24, 2023, at 13:45, Fei Wang wrote: > > According to description of vaExportSurfaceHandle in libva, vaSyncSurface > must be called if the contents of the surface will be read. > > Fixes ticket #9967. > > Signed-off-by: Fei Wang > --- > libavutil/hwcontext_vaapi.c | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/libavutil/hwcontext_vaapi.c b/libavutil/hwcontext_vaapi.c > index 938bd5447d..90c2c191d9 100644 > --- a/libavutil/hwcontext_vaapi.c > +++ b/libavutil/hwcontext_vaapi.c > @@ -1319,8 +1319,17 @@ static int vaapi_map_to_drm_esh(AVHWFramesContext *hwfc, AVFrame *dst, > surface_id = (VASurfaceID)(uintptr_t)src->data[3]; > > export_flags = VA_EXPORT_SURFACE_SEPARATE_LAYERS; > - if (flags & AV_HWFRAME_MAP_READ) > + if (flags & AV_HWFRAME_MAP_READ) { > export_flags |= VA_EXPORT_SURFACE_READ_ONLY; > + > + vas = vaSyncSurface(hwctx->display, surface_id); > + if (vas != VA_STATUS_SUCCESS) { > + av_log(hwfc, AV_LOG_ERROR, "Failed to sync surface " > + "%#x: %d (%s).\n", surface_id, vas, vaErrorStr(vas)); > + return AVERROR(EIO); > + } > + } > + > if (flags & AV_HWFRAME_MAP_WRITE) > export_flags |= VA_EXPORT_SURFACE_WRITE_ONLY; LGTM. > > -- > 2.25.1 > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".