From: Zhao Zhili <quinkblack@foxmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] tests: Remove fate-libx265-hdr10
Date: Tue, 26 Mar 2024 10:30:21 +0800
Message-ID: <tencent_3509A752B8A49633CD42A0464DC9CFB8D507@qq.com> (raw)
In-Reply-To: <CAEu79SbKRw=x1pa_gWn6f2+3q47UvJQ8Reepz=hRFOX59zzhRw@mail.gmail.com>
Ping. Is it OK to apply the patch as it is?
> On Mar 23, 2024, at 06:36, Jan Ekström <jeebjp@gmail.com> wrote:
>
> On Fri, Mar 22, 2024 at 10:18 PM Anton Khirnov <anton@khirnov.net> wrote:
>>
>> Quoting Zhao Zhili (2024-03-22 13:43:43)
>>> From: Zhao Zhili <zhilizhao@tencent.com>
>>>
>>> The test depends on the compile option of x265. It failed when
>>> HIGH_BIT_DEPTH isn't enabled. It also failed when asan is enabled
>>> because of memory issue inside of x265, which I don't think can
>>> be fixed within FFmpeg.
>>
>> I suggested some time ago we should mark x265 as experimental. It didn't
>> receive much enthusiasm, and some probably considered it a joke, but I
>> was mostly serious. It has major memory safety issues that have been
>> ignored for years.
>>
>
> Yea, I recall when I was testing my patch set with valgrind about half
> a year ago, some of the memory issues showed up there as well. The
> problem being that most users are happily oblivious to these issues as
> long as the piece of software "seems to work". Which is a line that
> x265 does cross.
>
> Thus at least on my side the reason for not much enthusiasm for
> marking it experimental at this point came from it being on the output
> side (and thus not handling random input/being a parser) as well as it
> most likely receiving much less understanding from users than just
> complaints about command lines which had worked for ages suddenly
> breaking.
>
> Jan
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-03-26 2:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-22 12:43 Zhao Zhili
2024-03-22 20:18 ` Anton Khirnov
2024-03-22 22:36 ` Jan Ekström
2024-03-26 2:30 ` Zhao Zhili [this message]
2024-03-26 7:22 ` Anton Khirnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_3509A752B8A49633CD42A0464DC9CFB8D507@qq.com \
--to=quinkblack@foxmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git