From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id CFEEA4CFDA for ; Fri, 14 Feb 2025 09:57:23 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1153168C14E; Fri, 14 Feb 2025 11:57:19 +0200 (EET) Received: from out162-62-57-87.mail.qq.com (out162-62-57-87.mail.qq.com [162.62.57.87]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4202D68BEA6 for ; Fri, 14 Feb 2025 11:57:11 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1739527026; bh=42gxNJ6y+buMoQeeYJjjF2iKfHb6mlNpP8R5FzGl3JQ=; h=From:Subject:Date:References:To:In-Reply-To; b=buzlOXDm+fHeH941JwnSmXSX4F3HjAVaw3so7IXClwzj/C+fVFK9HpHi+ln10w+Jr /RdZVtuZcqvrFXZNvstvgaIREKsMk/G6CtPfScleImz6aLyFRIfwHPFUJuVNM7NVkS O1AFlLJ9IhF4F+jYnXG7FUDYmQFn70FvL5ilXUfo= Received: from smtpclient.apple ([119.147.10.242]) by newxmesmtplogicsvrszc13-0.qq.com (NewEsmtp) with SMTP id E4532E0D; Fri, 14 Feb 2025 17:57:05 +0800 X-QQ-mid: xmsmtpt1739527025t5n93kyg8 Message-ID: X-QQ-XMAILINFO: NPZcszwnKSXOwfRLQGYYgNEmpDlCZePz9jrtmWme5qgt5w8zaZX6oDCIBneRxD qqopw7GppXDZvTi9rtL4ayBPuzNcyLXyAcPwzgb7/5CAVmDQBMRU1ZEeslHJNPWayrBYeWXy50bV fAbyd6McNAu8iSEnlnxhcGw+yVrFvTol8rn2NPvHb9H/A5A7DftMT9P0igghP7abE3E7EueDjHPJ l4U3yVGwKUl3oc9W7tX7PiAZV8jgEiB5j6Q4hPuC5bnOXeyzqzaRucgo4S5SFWKn1lU+mCmclbcb pGtm3HU+MgM00/bBzBvsLOoNtVX5l7vOMotYohX0YgERrzktLDU++08wBntr8CirXzW+3Gj+hxmH +AFt/Kbo0eJGtUwFGX5yDOVNc94D2JvuXv6SJDFS5BFzAyePM7sZYkmNxImA3xSvZoiDbW/1ZTxe zZrtSZvbPoW6x9zkoRiTRGOGyHk4du/W84q9FmMIXaEx0q4aowep7LLfrleWrcdv5uu5hYx4m3ON ZQokDQybMHUvVjnjzaiIxNMZlzj68MNd7nOdnDUCTadJWkBf+DCpPx6tfoM37vU0o7rlyw3I0BsK qteIFfshZgRW1SaJW5w6DnUIdwwsDKh6XArCsBlP9rLjh2DiLBz3hUkgdoMOuKW48DxGB1+4OD7B B502nE3O2ypMdm9YHoQygL41qQ02uY8ac1BabXNCkYzqs7dQmWBGWnT5APgJ7R6rQBgNQ3X88/ig NzJhwji8L8EmFKudnNJVNAhiJJJzdQpgtgjlYL3zObKTWY1NBfQUU9LBBhhA3HhIrCS0ESI35e4k VAnRjVYetpYinHHGDA51GbDEZPLemdD2FETRaYLbEFoJXGPB3lks9giJR4IXtDQKyrY7fvVF8wZY AI/uV590fKuLitrWNyn3lhg+SbE25sf8Wz3PmTHsi7GFRaK0u55vF7R/E/k7CQSAiYjE/4HdS0Jl dU2k1rQEz5fN+PcxA9Hcm/AriVzsTIvxh/zp19pTcw4YpPrawejQ== X-QQ-XMRINFO: Mp0Kj//9VHAxr69bL5MkOOs= From: Zhao Zhili Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3818.100.11.1.3\)) Date: Fri, 14 Feb 2025 17:56:55 +0800 References: <95067355-1e79-4d4e-96e4-57257d04552d@gmail.com> To: FFmpeg development discussions and patches In-Reply-To: <95067355-1e79-4d4e-96e4-57257d04552d@gmail.com> X-OQ-MSGID: <283A4FB6-7CF0-4262-BE1A-729A53812843@foxmail.com> X-Mailer: Apple Mail (2.3818.100.11.1.3) Subject: Re: [FFmpeg-devel] [PATCH] avutil/detection_bbox: Cleanup: Remove unneeded bbox_size struct member X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > On Feb 14, 2025, at 16:47, Leandro Santiago wrote: > > There is no need to store this field in the struct, > as it can be computed as sizeof(AVDetectionBBox). > > Signed-off-by: Leandro Santiago > --- > libavutil/detection_bbox.c | 1 - > libavutil/detection_bbox.h | 7 +------ > 2 files changed, 1 insertion(+), 7 deletions(-) > > diff --git a/libavutil/detection_bbox.c b/libavutil/detection_bbox.c > index cb157b355b..456c35f87a 100644 > --- a/libavutil/detection_bbox.c > +++ b/libavutil/detection_bbox.c > @@ -40,7 +40,6 @@ AVDetectionBBoxHeader *av_detection_bbox_alloc(uint32_t nb_bboxes, size_t *out_s > return NULL; > > header->nb_bboxes = nb_bboxes; > - header->bbox_size = bbox_size; > header->bboxes_offset = bboxes_offset; > > if (out_size) > diff --git a/libavutil/detection_bbox.h b/libavutil/detection_bbox.h > index 011988052c..7844fb05da 100644 > --- a/libavutil/detection_bbox.h > +++ b/libavutil/detection_bbox.h > @@ -70,11 +70,6 @@ typedef struct AVDetectionBBoxHeader { > * the array of bounding boxes starts. > */ > size_t bboxes_offset; > - > - /** > - * Size of each bounding box in bytes. > - */ > - size_t bbox_size; > } AVDetectionBBoxHeader; > > /* > @@ -85,7 +80,7 @@ av_get_detection_bbox(const AVDetectionBBoxHeader *header, unsigned int idx) > { > av_assert0(idx < header->nb_bboxes); > return (AVDetectionBBox *)((uint8_t *)header + header->bboxes_offset + > - idx * header->bbox_size); > + idx * sizeof(AVDetectionBBox)); > } No, this field is for ABI compatibility. New fields can be added at the end of AVDetectionBBox, sizeof(AVDetectionBBox) can be different between API user of libavutil and libavutil internal. > > /** > -- > 2.48.1 > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".