From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
by master.gitmailbox.com (Postfix) with ESMTPS id 833204AAB8
for <ffmpegdev@gitmailbox.com>; Thu, 24 Apr 2025 02:52:31 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 58E8568B745;
Thu, 24 Apr 2025 05:52:21 +0300 (EEST)
Received: from out162-62-57-49.mail.qq.com (out162-62-57-49.mail.qq.com
[162.62.57.49])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 58B0168A2D8
for <ffmpeg-devel@ffmpeg.org>; Thu, 24 Apr 2025 05:51:56 +0300 (EEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com;
s=s201512; t=1745463103;
bh=QkYDW5VjnblIN60Xi18VsGAtkA8uNm6ttFL8VxuhUUE=;
h=Subject:From:In-Reply-To:Date:Cc:References:To;
b=kz8+qnAG3V3S/fPsYDVcZAwzFJkj+FhycAWswDFqGxsNf3DMRHWvOl0yXOUATcPuT
LB3l/WDVybG1F9HlYWCKQE8HTLcXgXbvGJOSAFMdL2k5/2GJ6tWFdTI91fwtUq9wrs
Dc4LSA+RDi5j2SVbWRJZNeKdWhCuh+lpRlC2hj7w=
Received: from smtpclient.apple ([119.147.10.242])
by newxmesmtplogicsvrszc11-0.qq.com (NewEsmtp) with SMTP
id CE99C4CF; Thu, 24 Apr 2025 10:51:41 +0800
X-QQ-mid: xmsmtpt1745463101t3q9hs49j
Message-ID: <tencent_30F74F81D579272438EA96114D00A048CD07@qq.com>
X-QQ-XMAILINFO: NQR8mRxMnur9oFsr+Ed94oie2OZvDd8YNZKkntJydcHrQRrhulfO0KAy2m9kGp
VLtMpVrDSJoVoUo9vIXl6nrNLkuAAogKvpQJN1oXz3VtiJ2nabixlx/QYS7IB+LlKsq8o5F/FyUF
hisYwYjhBDnTUM+sY+5lhk793+ee8zKvoWOonWDZNB+iRDvRDo6AldvuaHTPqoSxJ6SS2tgZwyNm
C4LLaO/mPFqTK6ayxrzSp/KMhYXbK501IIslSOHkDqT1euqXkjYS393YRJ5ny82C+k4LTDkCjuD+
/Usm5dKbEbb+Mk98HGIjJRG41x5HjCrS3weqYEphBpm7tdu+QG1tflG3XcRHkcAvV3TTQEHMcBKd
P+YwEbIdywvtJncRMUBbQ0m2WknnfTfp+j9RSJkuv8N12xnK8CXCTKNvf1F3FfvK9kchOAjS3CPe
v9ixKY5LSMpyxy7HpB4SAq2lqX9Ns3PrAXTZPxtg6TsjkqvXDTjqQYDGT0tLYDsbke7pzMI/jjHJ
n4yOPKqiM0MXiupISalZPdCJRiQ3snnTqkh4wRW7sCruxnbJV2AFIQNE9aZzu3Avz+Q+wYSBMscY
fZ7SqfiZtemZezQPJxJPneAz3GuwZdYWL/+Yt0MvuqLqmdrX68NZw/8nsWg+GOlcof7LMTCVDmgC
KVnbjrfkgMwBh4aYTGPPAEkzuj1/rG8QNbV68yE6Pbn1/znguHt+Wdrm6ZDIi/+TM/kA0kZy+8/N
uM2lfp6PhXBzE8/kKJcmx2F0Sc36X83gBceEVQ7BS5imAFtxko8QITOhdgIR2NfMZjQIaZOpgJG/
TWeGN3aau1tQn/2ub2EzxsNVIQUnKEb4KhwrFCpWDK/+bLxRSIa5igXoRrV0R8mbIkXEwnAcDWzj
fvziy3u1TnHP0kclfuEVBWkv+EqDeJyuTowhOIbApjOk4IjE5bITfGx1ump9H/5ZceVloimLZMJr
tAe77LcPxb2TRwNBR3W3S0VGZHsYSqLRvMCqUeSUa2LzgE9tQDusRc6IQIqSHpN1wY/CG/IAs/wl
M+OKGwJx/oIGTQ3qL+u2l2rcj8/4MkCSekiKFsdA==
X-QQ-XMRINFO: OWPUhxQsoeAVDbp3OJHYyFg=
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.400.131.1.6\))
From: Zhao Zhili <quinkblack-at-foxmail.com@ffmpeg.org>
In-Reply-To: <9505F77B-E07E-4C00-B1DC-CB8215CF3DBC@chinaffmpeg.org>
Date: Thu, 24 Apr 2025 10:51:31 +0800
X-OQ-MSGID: <6FF2A383-9ADF-46A6-A654-AC579E4FCDCF@foxmail.com>
References: <tencent_FCCD17A003CDE7CFD35572A73038C6961A07@qq.com>
<9505F77B-E07E-4C00-B1DC-CB8215CF3DBC@chinaffmpeg.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
X-Mailer: Apple Mail (2.3826.400.131.1.6)
Subject: Re: [FFmpeg-devel] [PATCH 2/3] avformat/hls: Show error info when
read key file failed
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Steven Liu <lq@chinaffmpeg.org>,
=?utf-8?Q?Martin_Storsj=C3=B6?= <martin@martin.st>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/tencent_30F74F81D579272438EA96114D00A048CD07@qq.com/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>
> On Apr 24, 2025, at 10:24, Steven Liu <lq@chinaffmpeg.org> wrote:
>
>
>> On Apr 23, 2025, at 20:59, Zhao Zhili <quinkblack-at-foxmail.com@ffmpeg.org> wrote:
> Hi Zhili,
>>
>> From: Zhao Zhili <zhilizhao@tencent.com>
>>
>> ---
>> libavformat/hls.c | 12 +++++++-----
>> 1 file changed, 7 insertions(+), 5 deletions(-)
>>
>> diff --git a/libavformat/hls.c b/libavformat/hls.c
>> index 6623c80309..45c1b283c9 100644
>> --- a/libavformat/hls.c
>> +++ b/libavformat/hls.c
>> @@ -1353,16 +1353,18 @@ static int open_input(HLSContext *c, struct playlist *pls, struct segment *seg,
>> if (seg->key_type == KEY_AES_128 || seg->key_type == KEY_SAMPLE_AES) {
>> if (strcmp(seg->key, pls->key_url)) {
>> AVIOContext *pb = NULL;
>> - if (open_url(pls->parent, &pb, seg->key, &c->avio_opts, NULL, NULL) == 0) {
>> +
>> + ret = open_url(pls->parent, &pb, seg->key, &c->avio_opts, NULL, NULL);
>> + if (ret >= 0) {
>> ret = avio_read(pb, pls->key, sizeof(pls->key));
>> if (ret != sizeof(pls->key)) {
>> - av_log(pls->parent, AV_LOG_ERROR, "Unable to read key file %s\n",
>> - seg->key);
>> + av_log(pls->parent, AV_LOG_ERROR, "Unable to read key file %s, %s\n",
>> + seg->key, av_err2str(ret));
>> }
>> ff_format_io_close(pls->parent, &pb);
>> } else {
>> - av_log(pls->parent, AV_LOG_ERROR, "Unable to open key file %s\n",
>> - seg->key);
>> + av_log(pls->parent, AV_LOG_ERROR, "Unable to open key file %s, %s\n",
>> + seg->key, av_err2str(ret));
>> }
> Why not jump to cleanup immediately after an output error?
Because I don't know why not return error when the code is added in 84465f21 since 2011, and not
changed since then. I'm worried return error might trigger unknown bugs.
Cc Martin. Is there some reason not to error out in this case? Does that reason still hold now?
>
> Thanks
> Steven
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".