From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 96049429A3 for ; Sun, 8 May 2022 10:22:29 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6659268B2F9; Sun, 8 May 2022 13:22:26 +0300 (EEST) Received: from out203-205-221-209.mail.qq.com (out203-205-221-209.mail.qq.com [203.205.221.209]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1FB4C6809C4 for ; Sun, 8 May 2022 13:22:18 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1652005332; bh=TtyoJ3lrCS/JPvzXhgvGEhEl4qeFHf4x68RaOUFnvDQ=; h=From:Subject:Date:References:To:In-Reply-To; b=T4J3m8cj5bUpNHN/7CKUc2kzRa38p0Rc4SB3LMhP3ge4AtgrLWFu9bMhjCvK10cEM bgWOlQmx5nBqGuclTWOAvM66TfqRI03fzWygUpNwlOzfEQ2txloUtxWbqoORL3Csx2 Vhtjw2h6UzPA+bXS/F/kuYZ9IallB3kCjrSG6w3Q= Received: from [192.168.255.10] ([113.118.103.200]) by newxmesmtplogicsvrszc9.qq.com (NewEsmtp) with SMTP id 58AA66F4; Sun, 08 May 2022 18:22:10 +0800 X-QQ-mid: xmsmtpt1652005330trmu75z01 Message-ID: X-QQ-XMAILINFO: MIAHdi1iQo+zH/AjhNrHufU8+JX47B1HpN2N/2dx/FfQKdTw08Jz5cUtkoXmB2 1A5QvAzw1Ac51ij4ZbtIAPNs80F56EQl5Z1yPtrjX8b67iuc/MaY+rAHUHO9MRW1/X4DACXrR1dW b4tLDAEqh4qs3vVEWqjCyYoLxmqZ38WyVJ3k39n9QKnLbwEpoXK8GDPTigZFl11FLJoKapGlLZrV NDCzcnCjdSr++yOmj+J+kqRYsrdCfc7J1EPh7QanaYCT1kUbQOuLonlR0B8LCWR3MyCGQ/uuI6oG TbryAYbNcGv+vb7FxE/OyttdW9w3baQ1TqtNn5K9rnsqrOXEhiyUTF+LITobEE8w5ISjHOwq//6u 4nZ1LIN0M176nBhLELOVrIhH33F/XgVPEKsnCkvahuMtiuWNxbtDGKV14IqqvJc2evvFuuxXnR31 CWyCsHBDrxbahHAydVVHnin2KjlUJqE97tGZnF5Dko9bPjHJLUk0GLIUaWoJXgFPES6BeSdnBGaY xge3DXanYqKmDwV7hnfiLD5fmyKLgeM1RTCTvUafy9U3jpZS/ZGy+EQM0HmHVxJlwHThG/XYGNJI lcOTfQVBWrne12fbEKGnvjPfrV+8tRshciU7pKqd5Dle/RcN7LP6h/PDKWOgN9uuI5D1R3xhEw+A PE+JbWk2pyafyeKxTYljlkdbRn87cgsjInr32qloFCPrwukfEjqSofmWU20QpsXWbaapdk2QLATE M8JuY5JkU+oh0571ynGlA8aJzwaaA34SATgWwy0izNux7AljlAvYko/J0YIaMejDxz+3HsIG0f07 EUZ17XiZo5mBLWyBhRHHF8BWWGZH1UbBGkVzeb5ggPxXcvIO+O22RNQxn5jfcXIXLUHH9L3PGwMr z5C6G4/F/O6p6kzai+pFEJk2Oyk7EcEcYe8d/uRfItebZ2MCsfRbHoPrXpqw7IKT3zFDaNrBRCaV XetCBX86+LXZQO6qWxUQ== From: =?utf-8?B?InpoaWxpemhhbyjotbXlv5fnq4spIg==?= Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\)) Date: Sun, 8 May 2022 18:22:10 +0800 References: <20220508011722.4072-1-lq@chinaffmpeg.org> <20220508011722.4072-2-lq@chinaffmpeg.org> To: FFmpeg development discussions and patches In-Reply-To: <20220508011722.4072-2-lq@chinaffmpeg.org> X-OQ-MSGID: <2F7CC213-BF8A-4310-8841-E51D8BC9EE86@foxmail.com> X-Mailer: Apple Mail (2.3654.60.0.2.21) Subject: Re: [FFmpeg-devel] [PATCH v2 2/2] avformat/hlsenc: expand the scope of flags from int32_t to int64_t X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > On May 8, 2022, at 9:17 AM, Steven Liu wrote: > > because the flags in AVOption support i64. > > Signed-off-by: Steven Liu > --- > libavformat/hlsenc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c > index b9f79e30d8..00645ae74e 100644 > --- a/libavformat/hlsenc.c > +++ b/libavformat/hlsenc.c > @@ -202,7 +202,7 @@ typedef struct HLSContext { > int64_t init_time; // Set by a private option. > int max_nb_segments; // Set by a private option. > int hls_delete_threshold; // Set by a private option. > - uint32_t flags; // enum HLSFlags > + uint64_t flags; // enum HLSFlags Actually it should be int here. Firstly, AV_OPT_TYPE_FLAGS is accessed as int in opt.c. uint64_t only works with little endian system. Secondly, enum HLSFlags cannot has value larger than int. > uint32_t pl_type; // enum PlaylistType > char *segment_filename; > char *fmp4_init_filename; > -- > 2.34.1 > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".