Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Zhao Zhili <quinkblack@foxmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: eaphone <cyfdel@hotmail.com>
Subject: Re: [FFmpeg-devel] [PATCH v1] libavdevice/gdigrab: change hwnd tail check fail logic to !=null
Date: Thu, 15 Aug 2024 20:12:11 +0800
Message-ID: <tencent_285EB8A3164CCD79200ACDA54FA15525A707@qq.com> (raw)
In-Reply-To: <tencent_E4DA6A9E1331DC464B8FA61890B366D5A706@qq.com>



> On Aug 8, 2024, at 23:46, Zhao Zhili <quinkblack@foxmail.com> wrote:
> 
> 
>> On Aug 7, 2024, at 23:58, cyfdel-at-hotmail.com@ffmpeg.org wrote:
>> 
>> From: eaphone <cyfdel@hotmail.com>
>> 
>> ---
>> libavdevice/gdigrab.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/libavdevice/gdigrab.c b/libavdevice/gdigrab.c
>> index c91661c556..08a41c304b 100644
>> --- a/libavdevice/gdigrab.c
>> +++ b/libavdevice/gdigrab.c
>> @@ -281,7 +281,7 @@ gdigrab_read_header(AVFormatContext *s1)
>> 
>>        hwnd = (HWND) strtoull(name, &p, 0);
>> 
>> -        if (p == NULL || p == name || p[0] == '\0')
>> +        if (p == NULL || p == name || p[0] != '\0')
>>        {
>>            av_log(s1, AV_LOG_ERROR,
>>                   "Invalid window handle '%s', must be a valid integer.\n", name);
> 
> LGTM.

Apply, thanks.

> 
>> -- 
>> 2.45.2.windows.1
>> 
>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel@ffmpeg.org
>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>> 
>> To unsubscribe, visit link above, or email
>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

      reply	other threads:[~2024-08-15 12:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20240807155816.1412-1-cyfdel@hotmail.com>
2024-08-07 15:58 ` cyfdel-at-hotmail.com
2024-08-07 16:57   ` [FFmpeg-devel] 回复: " Cai Eaphone
2024-08-08 15:46   ` [FFmpeg-devel] " Zhao Zhili
2024-08-15 12:12     ` Zhao Zhili [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tencent_285EB8A3164CCD79200ACDA54FA15525A707@qq.com \
    --to=quinkblack@foxmail.com \
    --cc=cyfdel@hotmail.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git