From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 98EA849E71 for ; Mon, 15 Apr 2024 02:48:11 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9B7F168D3DF; Mon, 15 Apr 2024 05:48:08 +0300 (EEST) Received: from out203-205-221-239.mail.qq.com (out203-205-221-239.mail.qq.com [203.205.221.239]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8299268D223 for ; Mon, 15 Apr 2024 05:48:00 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1713149268; bh=HGkEG8RFlDpj7w6LV7vky8RlopftGznTVSiBnoBm5hw=; h=Subject:From:In-Reply-To:Date:Cc:References:To; b=Rk+TtnZC8lZEHz7NRabeVU0lQcNI0P2P+cmQyk0ymI2z9mhoQ9Iz3I0H3EC5Bg4ow uIkoKzGBXfouhiUhlL/YYTqqjZWaypKZq3jz3kB+qqmzH8jt3RR7GIbRcsICuZUJGb 4nIXHAfy2Nrs2cz45Mk9DincbqshWqdSH/1wsHBo= Received: from smtpclient.apple ([113.108.77.59]) by newxmesmtplogicsvrszb16-0.qq.com (NewEsmtp) with SMTP id BEF3E4F2; Mon, 15 Apr 2024 10:47:47 +0800 X-QQ-mid: xmsmtpt1713149267tw1v9r6b7 Message-ID: X-QQ-XMAILINFO: MmwREtnQO1///7cOYlLgwRcaSpziPy4bGCJzYRny7lmeMD+Nfukobt8Ni+7fBh fLDa5ik5q0c9p4ZuGBBwIkkZ9fawLIYngnWMdSrZfY1xURqx7ViKlKHp4vwaHf02tozYOuGxlKf2 qXQBvA9ml2Ya3Lr9IXmuWUsj2hPIlg19Xl881UnReYGwj/4d+RoIg9Uzse1CqGhfk7rCDaaLLRqj v0SbRyjUYtBucGJ7Eoq6DIS6qAv9AW7HdgzJX/5sqrXgkZd09Mc8qnPrJgU5PPUDACzqT0ViFU3Q wAYFA6VK7Svo2Cb6jrgFBuFSJMYwHQebhu2ToIhc20Yj9reM7rui87a1I3/4NIl9V27dDT1Y9RQI u9Lqiv2wyo1h+Ezz8nxx+7/8vFXcoJV8KDpP/1skwk+wNS6cZqNZJujAJqPW41GirM77W85uTgmz 4ilbr2dxPA4rL2SU0As5pPxwKNG3Wt62GcC1oos2LE+bUm19otBsDuUlMTDH6fktyzxC2XViTdMx /FfHCmIlfE7gJNFh8ocDkSqjtlNx6Geq85S4ungNDWiFeqCY2AmUt12u0kBpmej6OvwMDItpxYM1 nS67FQd4/qejjszNB16LqCx6KQQyGbarPwmcAnz0MaB0marKteTZ5bhfHkmIgHsovnnAFLk4Yv5Q Dd9dytjlpHOx8gNVWlSsDzNCvKxSxrbIS70K/5/CmjdkvLEuvsPdAl8QQpetN3cyHsi6JBAGw0oF ZAyWhxPoBlwdr4092JyIItsahuy4hWZt7w3fDj3BBBjVcLHQQwXSVbfoj2QuuEegQoCLt7ulhuZw MJNcZcKhS7D/bSqENlIq4rD7PjlVoJIgec3StvXZpotC5MEwIfZks4Jf/xHuRJD1QG3ah/L65DGZ 4w9IVdMaKwM8qy0BfVF3JQN98lou+O5tvHb4Z1Kkooaai4u8fAqMhy8eZ1XYWEag0TGbZ9iL+fTr RgMU16hwNBRlgsfZuLAbdGn8KdOo7OQ+3qXg/OipIX9I42x53Lww== X-QQ-XMRINFO: NyFYKkN4Ny6FSmKK/uo/jdU= Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.200.91.1.1\)) From: Zhao Zhili In-Reply-To: Date: Mon, 15 Apr 2024 10:47:45 +0800 X-OQ-MSGID: References: <20240412091923.1046792-1-lumingyindetect@163.com> To: FFmpeg development discussions and patches X-Mailer: Apple Mail (2.3774.200.91.1.1) Subject: Re: [FFmpeg-devel] [PATCH v1] libavfilter/af_channelsplit.c:fix memory leak X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: lumingyindetect@163.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > On Apr 12, 2024, at 17:49, Zhao Zhili wrote: > > >> On Apr 12, 2024, at 17:19, LuMingYin wrote: >> >> Signed-off-by: LuMingYin >> --- >> libavfilter/af_channelsplit.c | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/libavfilter/af_channelsplit.c b/libavfilter/af_channelsplit.c >> index d18d91dcb6..2cfac19cd3 100644 >> --- a/libavfilter/af_channelsplit.c >> +++ b/libavfilter/af_channelsplit.c >> @@ -163,8 +163,10 @@ static int filter_frame(AVFilterLink *outlink, AVFrame *buf) >> >> buf_out->data[0] = buf_out->extended_data[0] = buf_out->extended_data[s->map[i]]; >> ret = av_channel_layout_from_mask(&buf_out->ch_layout, 1ULL << channel); >> - if (ret < 0) >> + if (ret < 0){ >> + av_frame_free(&buf_out); >> return ret; >> + } > > LGTM. Please pay attention to the coding style. I can fix it manually this time. Applied as 5e380bcdb13dd47ce9c358a4edb281f05fde3f24. > >> >> return ff_filter_frame(ctx->outputs[i], buf_out); >> } >> -- >> 2.25.1 >> >> _______________________________________________ >> ffmpeg-devel mailing list >> ffmpeg-devel@ffmpeg.org >> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel >> >> To unsubscribe, visit link above, or email >> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".