From: Zhao Zhili <quinkblack@foxmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: lumingyindetect@163.com
Subject: Re: [FFmpeg-devel] [PATCH v1] libavfilter/af_channelsplit.c:fix memory leak
Date: Mon, 15 Apr 2024 10:47:45 +0800
Message-ID: <tencent_2689133F1C4B8B99661FD09AA6C1A7D8EA06@qq.com> (raw)
In-Reply-To: <tencent_551B4EF5705F2DA69A7040E59AB19F8FAB08@qq.com>
> On Apr 12, 2024, at 17:49, Zhao Zhili <quinkblack@foxmail.com> wrote:
>
>
>> On Apr 12, 2024, at 17:19, LuMingYin <lumingyindetect@163.com> wrote:
>>
>> Signed-off-by: LuMingYin <lumingyindetect@163.com>
>> ---
>> libavfilter/af_channelsplit.c | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/libavfilter/af_channelsplit.c b/libavfilter/af_channelsplit.c
>> index d18d91dcb6..2cfac19cd3 100644
>> --- a/libavfilter/af_channelsplit.c
>> +++ b/libavfilter/af_channelsplit.c
>> @@ -163,8 +163,10 @@ static int filter_frame(AVFilterLink *outlink, AVFrame *buf)
>>
>> buf_out->data[0] = buf_out->extended_data[0] = buf_out->extended_data[s->map[i]];
>> ret = av_channel_layout_from_mask(&buf_out->ch_layout, 1ULL << channel);
>> - if (ret < 0)
>> + if (ret < 0){
>> + av_frame_free(&buf_out);
>> return ret;
>> + }
>
> LGTM. Please pay attention to the coding style. I can fix it manually this time.
Applied as 5e380bcdb13dd47ce9c358a4edb281f05fde3f24.
>
>>
>> return ff_filter_frame(ctx->outputs[i], buf_out);
>> }
>> --
>> 2.25.1
>>
>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel@ffmpeg.org
>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>
>> To unsubscribe, visit link above, or email
>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2024-04-15 2:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-12 9:19 LuMingYin
2024-04-12 9:49 ` Zhao Zhili
2024-04-15 2:47 ` Zhao Zhili [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_2689133F1C4B8B99661FD09AA6C1A7D8EA06@qq.com \
--to=quinkblack@foxmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
--cc=lumingyindetect@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git