From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 04E2F4E90D for ; Tue, 18 Mar 2025 12:59:11 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 77D99687A45; Tue, 18 Mar 2025 14:58:55 +0200 (EET) Received: from xmbghk7.mail.qq.com (xmbghk7.mail.qq.com [43.163.128.47]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 11CFB687A0C for ; Tue, 18 Mar 2025 14:58:45 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1742302715; bh=LS0FtEJcxjMrh5fxK7x1PEQFwHhWBlav+eXt45piido=; h=From:To:Cc:Subject:Date; b=pNv1qAyfDqzZP3amkTf+tPPeIra0wiqFVSbC7ijANels5iE7dcfAdTynxFdLeoBmY Pbwi8QLWNd4hEZJUK+RB5XijfzVaxuSpfsUO7hDB7YXqALLdrKqCNn9vi3qPPphJbv K6qLzYQqHPrH0EC+POmqxvfh+AtIx4ixEInzW1gY= Received: from localhost.localdomain ([119.147.10.242]) by newxmesmtplogicsvrszgpua8-1.qq.com (NewEsmtp) with SMTP id EA204E98; Tue, 18 Mar 2025 20:58:34 +0800 X-QQ-mid: xmsmtpt1742302714tpmw985gx Message-ID: X-QQ-XMAILINFO: OW8nL0XA5Gql5jrlmUtNbh9kAAEnsgVWvIIq4mfPaZJztko5HRMoFMpnTyw8b3 uBiSXZ6CuEzFNLWb8p9lnjhdBqW3LGidwEzJf9joacH5h6JWcoS40117x0siIbuSpNHJz5iBaeQJ vIvIQzG3Fmwl/SRY1WHHbxazN6kmAWbCLwd7V1wnuTCTJrGng9yIy5P15jXp87x78vaGk+6IFHxT CIdzkcX/1Dt0u1Quu27SXZM9qvfBmIItlS+TATBWqrd+v7VJsWnAm3HBVc7rV84C44v4y3WD4AsG pjbHATgTJeZWriozhqF0vrKGDg1n9HvIGkzL9Ztu6y9xxf/9dDQgc7cgKsIYE5HqzmBor4POr3fj URH78HDehx5IydDDQP4tMJj5X4tGXc0ICgRzQFwqVHL7Z9dYmcRdPM8GLm2m2BT9dGqsR7NUOEzI CFtucXF7OKRUd2xURSzY8I+L4QCps42x89LT+eNSE6K2kl7sntujE6CFXjQoeBf4UPSOSp8vJlqe /D6SAgIxi+XT1nOWAmdGYQHuQ/7OV1D8sxNclbotj9Wf337Qyd4f5wbfTUGR2Q15B9Bhoa7xHpAL Obf92nmExkU9Qk++OPub5F07/WK0rR4vKkNWYeJ3uQ6whmMlzU5HfIyrafakMfUcUXfSJjli/IOV BSQlLpG8bT5XBYmN8gLwtTyAqYtJAp8Kl472H8+yS9eW5Le/m/larfhR1tMANMmIZQJ1bDEAf3o7 GbAIwcrgCUfCXI5KF/VU9eh5lkEkl3rLNCpvJ5nNYavJ8+VQfFw8KdTjOqD3kktEnhPc95vgdo74 lCocfL7IiG9zfoKpWJ5bWPzVL1xTxhdE24vN5J4CfgJDd90Oak2My/+z9FIaoxTgXgS9Z1v+OEyk 0ANzeFDZN6Q5KJXzslUtnhG8KUmFpvt/2MPNWczMm5+KMAYf3BPXhiOrJiflr0Q12c2U+z6TJ203 1eiTiA3H3nXTq6wqG+I0UCwQRWBKLQbvmBpfgZIPW+PZSR4RxuLw== X-QQ-XMRINFO: Mp0Kj//9VHAxr69bL5MkOOs= From: Zhao Zhili To: ffmpeg-devel@ffmpeg.org Date: Tue, 18 Mar 2025 20:58:31 +0800 X-OQ-MSGID: <20250318125831.7665-1-quinkblack@foxmail.com> X-Mailer: git-send-email 2.46.0 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 1/6] avcodec/vt: Don't restart decoder when confronted with ReferenceMissingErr X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Zhao Zhili Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: From: Zhao Zhili Otherwise the decoder may enter an loop of repeated state resets. This can happen for streams with CRA but no IDR. --- libavcodec/videotoolbox.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/libavcodec/videotoolbox.c b/libavcodec/videotoolbox.c index 7c88555e0c..aaa6129576 100644 --- a/libavcodec/videotoolbox.c +++ b/libavcodec/videotoolbox.c @@ -728,8 +728,12 @@ static void videotoolbox_decoder_callback(void *opaque, } if (!image_buffer) { + if (status != kVTVideoDecoderReferenceMissingErr) + vtctx->reconfig_needed = true; + av_log(vtctx->logctx, status ? AV_LOG_WARNING : AV_LOG_DEBUG, - "vt decoder cb: output image buffer is null: %i\n", status); + "vt decoder cb: output image buffer is null: %i, reconfig %d\n", + status, vtctx->reconfig_needed); return; } @@ -1066,10 +1070,8 @@ int ff_videotoolbox_common_end_frame(AVCodecContext *avctx, AVFrame *frame) return AVERROR_UNKNOWN; } - if (!vtctx->frame) { - vtctx->reconfig_needed = true; + if (!vtctx->frame) return AVERROR_UNKNOWN; - } return videotoolbox_buffer_create(avctx, frame); } -- 2.46.0 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".