From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 40E05449F7 for ; Thu, 5 Jan 2023 09:34:45 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9CFAC68BCC1; Thu, 5 Jan 2023 11:34:41 +0200 (EET) Received: from out203-205-221-153.mail.qq.com (out203-205-221-153.mail.qq.com [203.205.221.153]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6703768BAA5 for ; Thu, 5 Jan 2023 11:34:33 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1672911270; bh=URhr4HfM2G2yCDDJ9L23it4rHLHsyBLCQGUdpAM84Q8=; h=Subject:From:In-Reply-To:Date:Cc:References:To; b=JQrZqiQXCfaAcEA4snQFn+tiX3RPyWnEschlv85HSvX5R4mUPvpB20SPIY3W9Tnof 9GgZrP19kgMuQMa46zuipURyhwb1JR/FQ8MDvPf7Yf81YUotBiVf4n/w0bXJn5JiGa X9KGOkuasJVfb5NNKXjrdd0uqrD9FoXtzeT9W5Dk= Received: from smtpclient.apple ([119.147.10.191]) by newxmesmtplogicsvrszc5-0.qq.com (NewEsmtp) with SMTP id 89D2123B; Thu, 05 Jan 2023 17:34:29 +0800 X-QQ-mid: xmsmtpt1672911269tqfr5acsh Message-ID: X-QQ-XMAILINFO: OZZSS56D9fAjsN/LB1k4UNv/ds0lWytZjppPyX/HmNIC5ysTZR0aNf7R8NaP0C aGyeiOGIaYOIkxC0jIE/bGm9IoMLLwRZtAXLVwdBCmE6WNYTujP3iyKxrble4gJvgBvpsXRI7Wlu Wta1IOc3hNJyAdO5Kkef4wMG/YNujUFe2JBO6OrFYndLixlBG39KcsMgyWaq2DDM9pzdWLXoJoVr ePbNMQBhE0cYOqqiER1AeiLgeaOHpRhBoJp0l3VoUxyplg5cMrk8cpAchE2kZs7FQFKiS2P6mMXb UiR3mtnmInksFGLsPvN+SF4ZQCyG3nico4eez3jLWqPy9LTFRY/ESLP9+HEfqZr8uz0AYcc6UWTu U7YUo5wbBuhGKqETCt6Nj5s2S0c7q6uoRYIHhVq1prnIzb7q/3x/0ENdinAlTznF+V2RP7hik4Ut MXbUIVkPGRGZxJ+9jv4wYHlneXgSil1SkhgK3CBQsHIbjxVaH7qF2kRtYffkn+jmpOto8IfniPaJ sxJ/vQo+ha7h6FByYR9OBClKR6fsum21qKyVnEz/C8he7mAMY/n+j0tS26SpxDuJRsxnixoX5vvf CPa3wdmnaI9UJ11vE3doR3Nz+bGsr4F9+Y5MGf/fcsKI2Zjs1f0C3L/Pz1i8s9me8my8PeC3E1u0 b+sc4Q6vRHcz0Qcy0uyAo+YDJZVzDm7BixwXHWhlzw59lAbGQAHL/Gf0ERzgTBPOZt/SysBadU8C tNl4E/UzQkJMAKTmNiJTHkjnpWQN3WUq4yfh0+V48AJ11f2INAq2Ai29vnKJs7ZZb1baAqdmoasa I+cY6dcOq7SphYT8wbRD4mlY3p1pnWvP/g220ik7dmukMvczt+QPD/TnTUWsP3DpWkQ+O0watrhm o92hUBgkfhYUKcJrj0tdcRtiBgnWT3evgthoclb3U4Ci+qCsMNrMJjcmHEtBGwc2TFTMFWv9DfM/ ROqvna+tEk9x8b1vHdGNedqLeqpAud01Wy/5GvzpCt9sOqTucnfQ== Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) From: =?utf-8?B?InpoaWxpemhhbyjotbXlv5fnq4spIg==?= In-Reply-To: <20230104221619.919110-1-vigneshv@google.com> Date: Thu, 5 Jan 2023 17:34:29 +0800 X-OQ-MSGID: <58B9957F-9910-425B-89F5-2C0FF09B444D@foxmail.com> References: <20230104221619.919110-1-vigneshv@google.com> To: FFmpeg development discussions and patches X-Mailer: Apple Mail (2.3696.120.41.1.1) Subject: Re: [FFmpeg-devel] [PATCH 1/2] avformat/movenc: Add movie_timescale option to AVIF X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Vignesh Venkatasubramanian Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > On Jan 5, 2023, at 06:16, Vignesh Venkatasubramanian wrote: > > Allow specifying the movie_timescale options to AVIF ouptut. > > This also makes sure that when movie_timescale is not specified, > the default value of 1000 is used instead of 0. Animated AVIF > files which don't specify the movie_timescale will have the > correct duration written in the track and movie headers after this > change (instead of writing 0). > > Signed-off-by: Vignesh Venkatasubramanian > --- > libavformat/movenc.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/libavformat/movenc.c b/libavformat/movenc.c > index 7d49892283..36c76f7f60 100644 > --- a/libavformat/movenc.c > +++ b/libavformat/movenc.c > @@ -7758,6 +7758,11 @@ static const AVCodecTag codec_f4v_tags[] = { > }; > > #if CONFIG_AVIF_MUXER > + > +static const AVOption avif_options[] = { > + { "movie_timescale", "set movie timescale", offsetof(MOVMuxContext, movie_timescale), AV_OPT_TYPE_INT, {.i64 = MOV_TIMESCALE}, 1, INT_MAX, AV_OPT_FLAG_ENCODING_PARAM}, > + { NULL }, > +}; If there is a chance to add more options which is shared with mov_isobmff_muxer_class, define a common option to avoid duplication. Otherwise keep it as this. > static const AVCodecTag codec_avif_tags[] = { > { AV_CODEC_ID_AV1, MKTAG('a','v','0','1') }, > { AV_CODEC_ID_NONE, 0 }, > @@ -7767,6 +7772,7 @@ static const AVCodecTag *const codec_avif_tags_list[] = { codec_avif_tags, NULL > static const AVClass mov_avif_muxer_class = { > .class_name = "avif muxer", > .item_name = av_default_item_name, > + .option = avif_options, > .version = LIBAVUTIL_VERSION_INT, > }; > #endif > -- > 2.39.0.314.g84b9a713c41-goog > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".