From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 77BE14C114 for ; Wed, 5 Feb 2025 18:04:41 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B863268B3FA; Wed, 5 Feb 2025 20:04:37 +0200 (EET) Received: from out162-62-57-137.mail.qq.com (out162-62-57-137.mail.qq.com [162.62.57.137]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0367068B3FA for ; Wed, 5 Feb 2025 20:04:29 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1738778666; bh=5OL39EAF5Sx0cKoPlqD+zE0uJKyj+SYxbC3/FbdliRM=; h=From:Subject:Date:References:To:In-Reply-To; b=H67wbtW5WD9IPZvlL+Rk82IwddqPK3S+7MwsNgJB+BxFORRLIRjcF5eVvxx8ztF2a u7l/rQzMdOPL4jFttBHeLVRWJGUfjCKYeB3qM+uTmmqx86+CUa6oZvnEyl5ozARrvf K1Vzevh/XA5VBjTnHLPADORz8mXwqATirUgeE3Tw= Received: from smtpclient.apple ([240e:3b7:3277:36f0:544a:7de:c82a:2aa2]) by newxmesmtplogicsvrszc11-0.qq.com (NewEsmtp) with SMTP id 119B7053; Thu, 06 Feb 2025 02:04:25 +0800 X-QQ-mid: xmsmtpt1738778665tuisvo6r8 Message-ID: X-QQ-XMAILINFO: NC4p7XQIBeah1gfKVjYjCpR5EeQn2z2a3tVSMHUEx6zAOhkepzAMPAPC9S2E+P XDXRh3Yv/Zuhoo6L9vd/4lbajGtFcjFYsjwCROTrcpvLo0/mmAREucCKSYsMdqZ9lnW2duzBxfHC ZDczdrGZzFHY9JHxbtKs7ilc7FnP0uGAfs499lpLc8/1afCgsWhpiDUhWMuFhAKi79nAGOR+upeW 7B7fY0fA96DJKAScdvYRzGbFwtak7dA3lwI6hIboqR2fKqwFKr1DmqiSBnTbke+wALPe4S/YNMWI Q3A84XPXqkaEQkYyeK4YHQbKHTCzhw833vx6sd939DUp28O8jRkb6LePy77HMy+YnvEOP7p4Z2B6 CagYvT8V1ZAbCaRRZ7itPqt0yRFpLWREIpsvtetH4drWXXnsWplTnzWZyZ/JhFDBVbmJ34o2LXZV kLj8jkjb6hK1HhFFHLzp1C1uOVcKT6lToES4OID+pf5TcqQc3MCi7nppOOhQR+xnpRr04PRlqhn6 vjk6PECfzqzmYJL/kSAcctmVoIcT4Yf4OqEpFiTdkspdVcjukdGcmxhg5Nua9KdMHBWxqGwvLru5 f07VT2fEFUOca8gOLU7Fah6ALz+BOHAZwI5aSQ1lHFTsvyIafLqurJuGdkfNBa7o8XboAvBoHlUV exlk5kz+xE6AEyE8KkGoHev+nfJZlybCDryuIdkxytvIv4O3aiVPReEOQxx5P2JOEgDrIWmcVrFI sfvwuG2S/gl65FDv7jjjZrUmFjlpFklWQa/eljmV+JxKLxHlJyP0DycX5A8dSP2kkBBCXseFfcY3 CpR33JSvUsKv8N02/Gd0GRnbZqCp4JJqdRyiLt3oXmsuEjypY7R+QFuRC32/rd69RL2+3HlNxN4D sStMQ5Z+1Q9xdDbCZeAoO718ZxZ+pAnD9zyfiwxI3W1lZWz9bSDOVqQuyrggMvrp5zGGco68QDEi +0QZ2YJwqqlozemsqLliMr4Z/QWYUh5NNgyNtF4jnKcvyIML8mAwL1/m5j0GbfFUdLQwTEmdXslx 7yc8ZicA== X-QQ-XMRINFO: NI4Ajvh11aEj8Xl/2s1/T8w= From: Zhao Zhili Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3818.100.11.1.3\)) Date: Thu, 6 Feb 2025 02:04:15 +0800 References: To: FFmpeg development discussions and patches In-Reply-To: X-OQ-MSGID: X-Mailer: Apple Mail (2.3818.100.11.1.3) Subject: Re: [FFmpeg-devel] [PATCH 2/3] avcodec/libx264: Set FFCodec.pix_fmts field and fix deprecation warning X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > On Feb 6, 2025, at 01:42, Andreas Rheinhardt wrote: > > Zhao Zhili: >> From: Zhao Zhili >> >> We can fix deprecation warning by not set p.pix_fmts, and copy >> FFCodec.pix_fmts to FFCodec.p.pix_fmts in av_codec_init_static(). >> However, that method requires non-const FFCodec. So I decided to >> set pix_fmts and p.pix_fmts both, and disable deprecation warning >> explicitly. >> --- >> libavcodec/libx264.c | 9 +++++++++ >> 1 file changed, 9 insertions(+) >> >> diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c >> index 409f45fc7d..9b8b32ef4e 100644 >> --- a/libavcodec/libx264.c >> +++ b/libavcodec/libx264.c >> @@ -1633,7 +1633,10 @@ const FFCodec ff_libx264_encoder = { >> .flush = X264_flush, >> .close = X264_close, >> .defaults = x264_defaults, >> + .pix_fmts = pix_fmts_all, >> +FF_DISABLE_DEPRECATION_WARNINGS >> .p.pix_fmts = pix_fmts_all, >> +FF_ENABLE_DEPRECATION_WARNINGS >> .color_ranges = AVCOL_RANGE_MPEG | AVCOL_RANGE_JPEG, >> .caps_internal = FF_CODEC_CAP_INIT_CLEANUP | FF_CODEC_CAP_AUTO_THREADS >> #if X264_BUILD < 158 >> @@ -1659,7 +1662,10 @@ const FFCodec ff_libx264rgb_encoder = { >> .p.capabilities = AV_CODEC_CAP_DR1 | AV_CODEC_CAP_DELAY | >> AV_CODEC_CAP_OTHER_THREADS | >> AV_CODEC_CAP_ENCODER_REORDERED_OPAQUE, >> + .pix_fmts = pix_fmts_8bit_rgb, >> +FF_DISABLE_DEPRECATION_WARNINGS >> .p.pix_fmts = pix_fmts_8bit_rgb, >> +FF_ENABLE_DEPRECATION_WARNINGS >> .p.priv_class = &rgbclass, >> .p.wrapper_name = "libx264", >> .priv_data_size = sizeof(X264Context), >> @@ -1691,7 +1697,10 @@ const FFCodec ff_libx262_encoder = { >> .p.capabilities = AV_CODEC_CAP_DR1 | AV_CODEC_CAP_DELAY | >> AV_CODEC_CAP_OTHER_THREADS | >> AV_CODEC_CAP_ENCODER_REORDERED_OPAQUE, >> + .pix_fmts = pix_fmts_8bit, >> +FF_DISABLE_DEPRECATION_WARNINGS >> .p.pix_fmts = pix_fmts_8bit, >> +FF_ENABLE_DEPRECATION_WARNINGS >> .color_ranges = AVCOL_RANGE_MPEG, >> .p.priv_class = &X262_class, >> .p.wrapper_name = "libx264", > > Only Clang emits these deprecation warnings; and IIRC GCC does not > support disabling deprecation warnings inside a definition like this > (compilation failure). The deprecation warnings can instead be fixed > like in fdff1b9cbfd8cf5a9810c29efa4baf13a4786742. OK. I decided just set -Wno-deprecated-declarations in my build environment and not continue addressing the depression warning. > > - Andreas > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".