Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: "\"zhilizhao(赵志立)\"" <quinkblack@foxmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] avformat/demux: in case of no timestamps, calculate dts based on previous dts and duration
Date: Fri, 5 May 2023 19:37:57 +0800
Message-ID: <tencent_2069AA7C8AAD4E3BFDC29DB5406ACA00D10A@qq.com> (raw)
In-Reply-To: <20230505113123.28404-1-jeebjp@gmail.com>



> On May 5, 2023, at 19:31, Jan Ekström <jeebjp@gmail.com> wrote:
> 
> From: Martin Machalek <martin.machalek@24i.com>
> 
> Adds DTS to packets which would otherwise break tbr calculation
> within libavformat, as well as packet rate calculation in ffmpeg.
> 
> An example of such input would be an MPEG-TS stream where a whole
> GOP is put into a single PES packet.
> 
> Co-authored-by: Jan Ekström <jan.ekstrom@24i.com>
> 
> Signed-off-by: Jan Ekström <jan.ekstrom@24i.com>
> ---
> libavformat/demux.c | 5 +++++
> 1 file changed, 5 insertions(+)
> 
> diff --git a/libavformat/demux.c b/libavformat/demux.c
> index 06de71cd6e..9a4ab28679 100644
> --- a/libavformat/demux.c
> +++ b/libavformat/demux.c
> @@ -1098,6 +1098,11 @@ static void compute_pkt_fields(AVFormatContext *s, AVStream *st,
>     if (!onein_oneout)
>         // This should happen on the first packet
>         update_initial_timestamps(s, pkt->stream_index, pkt->dts, pkt->pts, pkt);
> +
> +    if (pkt->dts == AV_NOPTS_VALUE && !is_relative(sti->cur_dts) &&
> +        sti->cur_dts != AV_NOPTS_VALUE && pkt->duration > 0)
> +        pkt->dts = sti->cur_dts + pkt->duration;
> +

It’s possible that the next dts < pkt->dts, how to prevent non-monotonic increasing?

>     if (pkt->dts > sti->cur_dts)
>         sti->cur_dts = pkt->dts;
> 
> -- 
> 2.40.1
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2023-05-05 11:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-05 11:31 Jan Ekström
2023-05-05 11:37 ` "zhilizhao(赵志立)" [this message]
2023-05-05 11:42 ` Anton Khirnov
2023-05-05 20:25 ` Michael Niedermayer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tencent_2069AA7C8AAD4E3BFDC29DB5406ACA00D10A@qq.com \
    --to=quinkblack@foxmail.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git