From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 789F3403EE for ; Fri, 25 Mar 2022 10:19:52 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3B26D68B1D4; Fri, 25 Mar 2022 12:19:50 +0200 (EET) Received: from out162-62-57-252.mail.qq.com (out162-62-57-252.mail.qq.com [162.62.57.252]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B4C7068B0F6 for ; Fri, 25 Mar 2022 12:19:43 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1648203580; bh=HfUl/JGg03d+uMAcfOY+vOo3Ggg9Y1BCpCdAWJS6/VU=; h=From:Subject:Date:References:To:In-Reply-To; b=vIwFCqsLqT308T7SiL9e4gdRS5V4zOYTgE6w9vIhkG53QpTq23HhwqCQJeJ/7q3vQ Q9Mcdc2SmSU9H7FXHYr3q6U/L5JYodzzOhzn6q0xMCCdKwBfnPY4m3uSn3m5z44LiR MlNYn6ivnLquAtkFZVJPTuCaPcQ8hoyYCzuUB52o= Received: from [192.168.255.10] ([119.123.75.155]) by newxmesmtplogicsvrsza7.qq.com (NewEsmtp) with SMTP id 49E15476; Fri, 25 Mar 2022 18:18:30 +0800 X-QQ-mid: xmsmtpt1648203510tbg29huod Message-ID: X-QQ-XMAILINFO: MB5+LsFw85NotOYoU6uUjrC7BmMAlTA+tokeZq08rwwFo5AE+VucfNHwZg/x9a Bno+YHChRp5dy8fK46CVoFDjTofml3I12Q7W+3uzGiyH0MQThM5oIZKBVxuKCGqTn9toioAAhnnk UmX3WpDsvjezjBGluusJ9LqtvIJZQUd6Ba/1sXkwFn6Dba/RQkfRnN4zcOb2L2n4rjotjAs43FB+ Z3CJZ8aM29pWBssT/h/SJi/ygq0MVnKx1TxnHo4/5wl3KcyBmAaNbhXOLVS8B1RMnRa2ZManC95H 4ALDxQjD7egyaeORJXmiv6CDdZucTJPiOfXeH8jI6fZSjbrDUGt9N2/zeAPn6pdlAYxPXCKHsnjo ykyXkF0ovLWt8at8DZPJWUXVOYAEZCUHUl/0JPOSANqCCd0dT23a8+EVKPfuplAQoRLTpltVLq8j bW4ggK54s5WdYGjliNDkRdWyLEfAPp6QThXgrFlTXhd5+5FfGshJ4SVaPIplYxY7dXmm7B6W2rvd FqhNrfjDFaRWcaftvlemgTSPWXeRdPdGpal6v6ZF+2N3h50aT3O8iIfMDRWUivNbYBmKE9o4p5Jp LbZQ6bmnLBWzIP7LQ+dNCWXdengFUCDfRp+sMtBj+xOihaQypnfar2ObX1he0V/8inOD2QGGSgFN nbNLQjBo29JTNa4CWDGeKo78SG3czTEaIv6UH5gaBMeEZC2IcumHq3HKMc/LNTvJkIDeBepf4A1T /QbabCD089GLxViUqGic84RFgiP/dQyt77RQBhZZLwfIFh0Ymno0cNt8ERy4dcM/xwZORO1fudGP QAO4vwiCNKkynOP7hhjkWFgF9+LwVId195gM/H6U8/AO6dTKSpMYm7unYfizGQBenoKq/IU95Noz i/0gWBMTmOcYwqpXVq4ay2brbVIYZAOWt7JOTbGK4PBiVJhsAwSxNHw6mVd3O+ug== From: =?utf-8?B?InpoaWxpemhhbyjotbXlv5fnq4spIg==?= Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\)) Date: Fri, 25 Mar 2022 18:18:29 +0800 References: <20220322182511.7747-1-kevin@muxable.com> To: FFmpeg development discussions and patches In-Reply-To: X-OQ-MSGID: X-Mailer: Apple Mail (2.3654.60.0.2.21) Subject: Re: [FFmpeg-devel] [PATCH] rtpenc_vp8: Use 15-bit PictureIDs X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > On Mar 25, 2022, at 5:13 PM, Kevin Wang wrote: > > Hi, ping on this patch? It's quite simple, happy to answer any questions. > > On Tue, Mar 22, 2022 at 2:25 PM wrote: > >> From: Kevin Wang >> >> 7-bit PictureIDs are not supported by WebRTC: >> https://groups.google.com/g/discuss-webrtc/c/333-L02vuWA >> >> In practice, 15-bit PictureIDs offer better compatibility. >> >> Signed-off-by: Kevin Wang >> --- >> libavformat/rtpenc_vp8.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/libavformat/rtpenc_vp8.c b/libavformat/rtpenc_vp8.c >> index 671d245758..655d44517e 100644 >> --- a/libavformat/rtpenc_vp8.c >> +++ b/libavformat/rtpenc_vp8.c >> @@ -35,7 +35,8 @@ void ff_rtp_send_vp8(AVFormatContext *s1, const uint8_t >> *buf, int size) >> // partition id 0 >> *s->buf_ptr++ = 0x90; >> *s->buf_ptr++ = 0x80; // Picture id present >> - *s->buf_ptr++ = s->frame_count++ & 0x7f; >> + *s->buf_ptr++ = ((s->frame_count & 0x7f00) >> 8) | 0x80; >> + *s->buf_ptr++ = s->frame_count++ & 0xff; >> // Calculate the number of remaining bytes >> header_size = s->buf_ptr - s->buf; >> max_packet_size = s->max_payload_size - header_size; >> -- LGTM. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".