* [FFmpeg-devel] [PATCH] rtpenc_vp8: Use 15-bit PictureIDs
@ 2022-03-22 18:25 kevin
2022-03-25 9:13 ` Kevin Wang
2022-03-25 22:43 ` Martin Storsjö
0 siblings, 2 replies; 4+ messages in thread
From: kevin @ 2022-03-22 18:25 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: martin, Kevin Wang, Kevin Wang
From: Kevin Wang <kevmo314@gmail.com>
7-bit PictureIDs are not supported by WebRTC:
https://groups.google.com/g/discuss-webrtc/c/333-L02vuWA
In practice, 15-bit PictureIDs offer better compatibility.
Signed-off-by: Kevin Wang <kevin@muxable.com>
---
libavformat/rtpenc_vp8.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/libavformat/rtpenc_vp8.c b/libavformat/rtpenc_vp8.c
index 671d245758..655d44517e 100644
--- a/libavformat/rtpenc_vp8.c
+++ b/libavformat/rtpenc_vp8.c
@@ -35,7 +35,8 @@ void ff_rtp_send_vp8(AVFormatContext *s1, const uint8_t *buf, int size)
// partition id 0
*s->buf_ptr++ = 0x90;
*s->buf_ptr++ = 0x80; // Picture id present
- *s->buf_ptr++ = s->frame_count++ & 0x7f;
+ *s->buf_ptr++ = ((s->frame_count & 0x7f00) >> 8) | 0x80;
+ *s->buf_ptr++ = s->frame_count++ & 0xff;
// Calculate the number of remaining bytes
header_size = s->buf_ptr - s->buf;
max_packet_size = s->max_payload_size - header_size;
--
2.34.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [FFmpeg-devel] [PATCH] rtpenc_vp8: Use 15-bit PictureIDs
2022-03-22 18:25 [FFmpeg-devel] [PATCH] rtpenc_vp8: Use 15-bit PictureIDs kevin
@ 2022-03-25 9:13 ` Kevin Wang
2022-03-25 10:18 ` "zhilizhao(赵志立)"
2022-03-25 22:43 ` Martin Storsjö
1 sibling, 1 reply; 4+ messages in thread
From: Kevin Wang @ 2022-03-25 9:13 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: martin, Kevin Wang
Hi, ping on this patch? It's quite simple, happy to answer any questions.
On Tue, Mar 22, 2022 at 2:25 PM <kevin@muxable.com> wrote:
> From: Kevin Wang <kevmo314@gmail.com>
>
> 7-bit PictureIDs are not supported by WebRTC:
> https://groups.google.com/g/discuss-webrtc/c/333-L02vuWA
>
> In practice, 15-bit PictureIDs offer better compatibility.
>
> Signed-off-by: Kevin Wang <kevin@muxable.com>
> ---
> libavformat/rtpenc_vp8.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/libavformat/rtpenc_vp8.c b/libavformat/rtpenc_vp8.c
> index 671d245758..655d44517e 100644
> --- a/libavformat/rtpenc_vp8.c
> +++ b/libavformat/rtpenc_vp8.c
> @@ -35,7 +35,8 @@ void ff_rtp_send_vp8(AVFormatContext *s1, const uint8_t
> *buf, int size)
> // partition id 0
> *s->buf_ptr++ = 0x90;
> *s->buf_ptr++ = 0x80; // Picture id present
> - *s->buf_ptr++ = s->frame_count++ & 0x7f;
> + *s->buf_ptr++ = ((s->frame_count & 0x7f00) >> 8) | 0x80;
> + *s->buf_ptr++ = s->frame_count++ & 0xff;
> // Calculate the number of remaining bytes
> header_size = s->buf_ptr - s->buf;
> max_packet_size = s->max_payload_size - header_size;
> --
> 2.34.1
>
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [FFmpeg-devel] [PATCH] rtpenc_vp8: Use 15-bit PictureIDs
2022-03-25 9:13 ` Kevin Wang
@ 2022-03-25 10:18 ` "zhilizhao(赵志立)"
0 siblings, 0 replies; 4+ messages in thread
From: "zhilizhao(赵志立)" @ 2022-03-25 10:18 UTC (permalink / raw)
To: FFmpeg development discussions and patches
> On Mar 25, 2022, at 5:13 PM, Kevin Wang <kevin@muxable.com> wrote:
>
> Hi, ping on this patch? It's quite simple, happy to answer any questions.
>
> On Tue, Mar 22, 2022 at 2:25 PM <kevin@muxable.com> wrote:
>
>> From: Kevin Wang <kevmo314@gmail.com>
>>
>> 7-bit PictureIDs are not supported by WebRTC:
>> https://groups.google.com/g/discuss-webrtc/c/333-L02vuWA
>>
>> In practice, 15-bit PictureIDs offer better compatibility.
>>
>> Signed-off-by: Kevin Wang <kevin@muxable.com>
>> ---
>> libavformat/rtpenc_vp8.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/libavformat/rtpenc_vp8.c b/libavformat/rtpenc_vp8.c
>> index 671d245758..655d44517e 100644
>> --- a/libavformat/rtpenc_vp8.c
>> +++ b/libavformat/rtpenc_vp8.c
>> @@ -35,7 +35,8 @@ void ff_rtp_send_vp8(AVFormatContext *s1, const uint8_t
>> *buf, int size)
>> // partition id 0
>> *s->buf_ptr++ = 0x90;
>> *s->buf_ptr++ = 0x80; // Picture id present
>> - *s->buf_ptr++ = s->frame_count++ & 0x7f;
>> + *s->buf_ptr++ = ((s->frame_count & 0x7f00) >> 8) | 0x80;
>> + *s->buf_ptr++ = s->frame_count++ & 0xff;
>> // Calculate the number of remaining bytes
>> header_size = s->buf_ptr - s->buf;
>> max_packet_size = s->max_payload_size - header_size;
>> --
LGTM.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [FFmpeg-devel] [PATCH] rtpenc_vp8: Use 15-bit PictureIDs
2022-03-22 18:25 [FFmpeg-devel] [PATCH] rtpenc_vp8: Use 15-bit PictureIDs kevin
2022-03-25 9:13 ` Kevin Wang
@ 2022-03-25 22:43 ` Martin Storsjö
1 sibling, 0 replies; 4+ messages in thread
From: Martin Storsjö @ 2022-03-25 22:43 UTC (permalink / raw)
To: Kevin Wang; +Cc: Kevin Wang, ffmpeg-devel
On Tue, 22 Mar 2022, kevin@muxable.com wrote:
> From: Kevin Wang <kevmo314@gmail.com>
>
> 7-bit PictureIDs are not supported by WebRTC:
> https://groups.google.com/g/discuss-webrtc/c/333-L02vuWA
>
> In practice, 15-bit PictureIDs offer better compatibility.
>
> Signed-off-by: Kevin Wang <kevin@muxable.com>
> ---
> libavformat/rtpenc_vp8.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/libavformat/rtpenc_vp8.c b/libavformat/rtpenc_vp8.c
> index 671d245758..655d44517e 100644
> --- a/libavformat/rtpenc_vp8.c
> +++ b/libavformat/rtpenc_vp8.c
> @@ -35,7 +35,8 @@ void ff_rtp_send_vp8(AVFormatContext *s1, const uint8_t *buf, int size)
> // partition id 0
> *s->buf_ptr++ = 0x90;
> *s->buf_ptr++ = 0x80; // Picture id present
> - *s->buf_ptr++ = s->frame_count++ & 0x7f;
> + *s->buf_ptr++ = ((s->frame_count & 0x7f00) >> 8) | 0x80;
> + *s->buf_ptr++ = s->frame_count++ & 0xff;
> // Calculate the number of remaining bytes
> header_size = s->buf_ptr - s->buf;
> max_packet_size = s->max_payload_size - header_size;
> --
> 2.34.1
LGTM, thanks!
// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-03-25 22:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-22 18:25 [FFmpeg-devel] [PATCH] rtpenc_vp8: Use 15-bit PictureIDs kevin
2022-03-25 9:13 ` Kevin Wang
2022-03-25 10:18 ` "zhilizhao(赵志立)"
2022-03-25 22:43 ` Martin Storsjö
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git