From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
by master.gitmailbox.com (Postfix) with ESMTPS id 395B74C6F8
for <ffmpegdev@gitmailbox.com>; Wed, 9 Apr 2025 03:07:04 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8FA5768A4C3;
Wed, 9 Apr 2025 06:06:59 +0300 (EEST)
Received: from out162-62-57-87.mail.qq.com (out162-62-57-87.mail.qq.com
[162.62.57.87])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id BA0DD687BA6
for <ffmpeg-devel@ffmpeg.org>; Wed, 9 Apr 2025 06:06:51 +0300 (EEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com;
s=s201512; t=1744168002;
bh=7xej4MVC391xxf8FDPTRbI8cLe+VsibV9/vAGdn1zhU=;
h=Subject:From:In-Reply-To:Date:Cc:References:To;
b=ctblQrqRdKBjvbYqIUxsrDtJ0FqzOajOksZb7zs4xkVUsAffoFfAMt5BWxu2p+k/p
qow++1R/Do404eV3ilmUleTuaJr83HizZxprLblob/9UyzHrn0fKBVZ1qtB1DFQRHH
ReadXc7J4JBzvrzYHk3HkWlvps8i5xArd1DT3c7E=
Received: from smtpclient.apple ([119.147.10.242])
by newxmesmtplogicsvrsza29-0.qq.com (NewEsmtp) with SMTP
id 1A9262BE; Wed, 09 Apr 2025 11:06:41 +0800
X-QQ-mid: xmsmtpt1744168001twcap6ge4
Message-ID: <tencent_1FD968BE7C06AF6A3945C19DB4BC689A020A@qq.com>
X-QQ-XMAILINFO: Mdc3TkmnJyI/2VewYRTL6YBKOvdZG0WzKpHdaHa1bAF/LEKh2Y7+dRKj0eAqGu
S81We3mxddgK9YyOPcSIyCyOFZ5QoEhpE7Mnndi/GFuwt10hiPLcBZkJR5M/y/tjayM41XF47wQr
7v33RJyDxWWqpK4C77ci/RBKkG27Z6TEOQcGFRZxmnDSymm+0FUdgTN1IlcafxLLjMJHV7G0Kk3o
722Cr54elQLWa+b3ho8ETixT68CkuZQIgfBTPqUjOANshKL6RgrIKInCPSJCuIR9rLGgTn8dxRRZ
13sfnM1rpxGQSllLGthQFXXVaqFYd2yDS2GmST+F7sRwyIpm8ISdlOfybOtzBqGSsPpIg+coIPE6
Fy9KwE8lYvLQGlZSM5KgcYcLjSmx11yF3XU6Kb61UtiIjlqLzLFcUR0ATgKhH2zyHL4fY2BGhdGx
PRDJmrres4RaS8x6ry9F07O2kS74HkTyrIHEWOVuT4Pst4KywRjhDhvi70+nlyML11M6uU63yqPr
Kw1eg6Z22dMgLjyfv62ba62cpIBPJIlXoFZ7pLqxBnGfYq67Z01M+762IYQs2uDbviwkClmX7g/U
j2j/ofb2Rf2RHYIKz1supfc9GVoBS7sIWeqzfzGaJckWeyAVdRIMAFmz0Nrtw2DsTuaeaxSzCaSG
9Ri0LDiEXAXfm7qNwzysJSSchgDNFGd2uDYkDOCANCS+OyCmI4Z87mBpA71jx0nXPioTPolbWBmW
9YWv1QJ41eukZh24p1tx8QMdYZMVZE4OAd00CBTjWxR5GsHXVB+xqZ9ciY5LQy2/7oMewXC1/rUV
lZxdTfmrJoKmdtA79CUbMGQxmcu69EiH24X1o1Y5XB0QoGJkEAlkZrloXbMebDNxkKJmQ52HUKGw
Y4cYNnNK7MDl8TWT6hbX3eY/WbxXDhIvUmoOwmolzSzD559qlj0Q/alqI4jNT7VfjjaGIB+Pi1Kj
pvdbAf3jU2drlYyRfk2Tacr7BVOgiJTkW5t+8Xuik=
X-QQ-XMRINFO: OWPUhxQsoeAVDbp3OJHYyFg=
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3818.100.11.1.3\))
From: Zhao Zhili <quinkblack-at-foxmail.com@ffmpeg.org>
In-Reply-To: <tencent_4C958DF143216885BDA89D908C8CCE92F30A@qq.com>
Date: Wed, 9 Apr 2025 11:06:31 +0800
X-OQ-MSGID: <D5AA6B87-15C7-4EAE-B2A2-95D7A2BAD655@foxmail.com>
References: <tencent_4C958DF143216885BDA89D908C8CCE92F30A@qq.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
X-Mailer: Apple Mail (2.3818.100.11.1.3)
Subject: Re: [FFmpeg-devel] [PATCH] avformat/rtpdec_mpeg4: add need_parsing
for rtsp AAC
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Jack Lau <jacklau1222@qq.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/tencent_1FD968BE7C06AF6A3945C19DB4BC689A020A@qq.com/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>
> On Apr 9, 2025, at 08:07, Jack Lau via ffmpeg-devel <ffmpeg-devel@ffmpeg.org> wrote:
>
> fix ticket #11531
>
> the rtsp aac did not marked keyframe which cannot easy copy to output.
> because f265f9c9d04863180503707bfad285f48e6bf080 commit change the AAC props to match xHE-AAC.
> in some formats like MOV, need_parsing is set, so AAC can be still parsed be keyframe
> but rtsp did not, so this patch add it
>
> Signed-off-by: Jack Lau <jacklau1222@qq.com>
> ---
> libavformat/rtpdec_mpeg4.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/libavformat/rtpdec_mpeg4.c b/libavformat/rtpdec_mpeg4.c
> index 6531632b2d..c506bcbed1 100644
> --- a/libavformat/rtpdec_mpeg4.c
> +++ b/libavformat/rtpdec_mpeg4.c
> @@ -363,6 +363,7 @@ const RTPDynamicProtocolHandler ff_mpeg4_generic_dynamic_handler = {
> .enc_name = "mpeg4-generic",
> .codec_type = AVMEDIA_TYPE_AUDIO,
> .codec_id = AV_CODEC_ID_AAC,
> + .need_parsing = AVSTREAM_PARSE_HEADERS,
> .priv_data_size = sizeof(PayloadContext),
> .parse_sdp_a_line = parse_sdp_line,
> .close = close_context,
LGTM, thanks.
> --
> 2.49.0
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".