[FFmpeg-devel] [PATCH] avformat/rtpdec_mpeg4: add need_parsing for rtsp AAC

[FFmpeg-devel] [PATCH] avformat/rtpdec_mpeg4: add need_parsing for rtsp AAC

[Jack Lau via ffmpeg-devel]

fix ticket #11531

the rtsp aac did not marked keyframe which cannot easy copy to output.
because f265f9c9d04863180503707bfad285f48e6bf080 commit change the AAC props to match xHE-AAC.
in some formats like MOV, need_parsing is set, so AAC can be still parsed be keyframe
but rtsp did not, so this patch add it

Signed-off-by: Jack Lau <jacklau1222@qq.com>
---
 libavformat/rtpdec_mpeg4.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/libavformat/rtpdec_mpeg4.c b/libavformat/rtpdec_mpeg4.c
index 6531632b2d..c506bcbed1 100644
--- a/libavformat/rtpdec_mpeg4.c
+++ b/libavformat/rtpdec_mpeg4.c
@@ -363,6 +363,7 @@ const RTPDynamicProtocolHandler ff_mpeg4_generic_dynamic_handler = {
     .enc_name           = "mpeg4-generic",
     .codec_type         = AVMEDIA_TYPE_AUDIO,
     .codec_id           = AV_CODEC_ID_AAC,
+    .need_parsing       = AVSTREAM_PARSE_HEADERS,
     .priv_data_size     = sizeof(PayloadContext),
     .parse_sdp_a_line   = parse_sdp_line,
     .close              = close_context,
-- 
2.49.0

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avformat/rtpdec_mpeg4: add need_parsing for rtsp AAC

[Zhao Zhili]

> On Apr 9, 2025, at 08:07, Jack Lau via ffmpeg-devel <ffmpeg-devel@ffmpeg.org> wrote:
> 
> fix ticket #11531
> 
> the rtsp aac did not marked keyframe which cannot easy copy to output.
> because f265f9c9d04863180503707bfad285f48e6bf080 commit change the AAC props to match xHE-AAC.
> in some formats like MOV, need_parsing is set, so AAC can be still parsed be keyframe
> but rtsp did not, so this patch add it
> 
> Signed-off-by: Jack Lau <jacklau1222@qq.com>
> ---
> libavformat/rtpdec_mpeg4.c | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/libavformat/rtpdec_mpeg4.c b/libavformat/rtpdec_mpeg4.c
> index 6531632b2d..c506bcbed1 100644
> --- a/libavformat/rtpdec_mpeg4.c
> +++ b/libavformat/rtpdec_mpeg4.c
> @@ -363,6 +363,7 @@ const RTPDynamicProtocolHandler ff_mpeg4_generic_dynamic_handler = {
>     .enc_name           = "mpeg4-generic",
>     .codec_type         = AVMEDIA_TYPE_AUDIO,
>     .codec_id           = AV_CODEC_ID_AAC,
> +    .need_parsing       = AVSTREAM_PARSE_HEADERS,
>     .priv_data_size     = sizeof(PayloadContext),
>     .parse_sdp_a_line   = parse_sdp_line,
>     .close              = close_context,

LGTM, thanks.

> -- 
> 2.49.0
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".